You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by paul-guo- <gi...@git.apache.org> on 2016/06/29 03:19:01 UTC
[GitHub] incubator-hawq pull request #759: HAWQ-878. Add googletest cases for the ao ...
GitHub user paul-guo- opened a pull request:
https://github.com/apache/incubator-hawq/pull/759
HAWQ-878. Add googletest cases for the ao snappy compression support.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul-guo-/incubator-hawq snappy
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/759.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #759
----
commit 2c8243d5cf9f9662f367d1f5f54514041d17ccc3
Author: Paul Guo <pa...@gmail.com>
Date: 2016-06-29T02:38:20Z
HAWQ-878. Add googletest cases for the ao snappy compression support.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #759: HAWQ-878. Add googletest cases for the ao ...
Posted by wengyanqing <gi...@git.apache.org>.
Github user wengyanqing commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/759#discussion_r69062485
--- Diff: src/test/feature/ao/TestAoSnappy.cpp ---
@@ -0,0 +1,126 @@
+#include "gtest/gtest.h"
+
+#include "lib/sql_util.h"
+
+using std::string;
+
+class TestAOSnappy: public ::testing::Test
+{
+ public:
+ const string initFile = "ao/sql/init_file";
+ TestAOSnappy() { }
+ ~TestAOSnappy() {}
+};
+
+TEST_F(TestAOSnappy, Create1048576)
+{
+ hawq::test::SQLUtility util;
--- End diff --
need to check whether util can reuse in the class level
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #759: HAWQ-878. Add googletest cases for the ao ...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- closed the pull request at:
https://github.com/apache/incubator-hawq/pull/759
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #759: HAWQ-878. Add googletest cases for the ao snappy ...
Posted by yaoj2 <gi...@git.apache.org>.
Github user yaoj2 commented on the issue:
https://github.com/apache/incubator-hawq/pull/759
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #759: HAWQ-878. Add googletest cases for the ao snappy ...
Posted by wengyanqing <gi...@git.apache.org>.
Github user wengyanqing commented on the issue:
https://github.com/apache/incubator-hawq/pull/759
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---