[GitHub] [hadoop-ozone] bharatviswa504 commented on a change in pull request #176: HDDS-2495 Sonar "notify" may not wake up the appropriate thread

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #176: HDDS-2495 Sonar "notify" may not wake up the appropriate thread
URL: https://github.com/apache/hadoop-ozone/pull/176#discussion_r346602347
 
 

 ##########
 File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManager.java
 ##########
 @@ -192,7 +192,7 @@ public boolean isRunning() {
   @SuppressFBWarnings(value="NN_NAKED_NOTIFY",
       justification="Used only for testing")
   public synchronized void processContainersNow() {
-    notify();
+    notifyAll();
 
 Review comment:
   Here replication manager is a single thread, I think notify should be fine here. Replacing with notifyAll should not cause any harm here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org