You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/01/03 17:06:31 UTC

[GitHub] [netbeans] matthiasblaesing commented on pull request #2633: [NETBEANS-5181] Update NbBundle to read bundle files like JDK9 does (UTF-1 then ISO-8859-1)

matthiasblaesing commented on pull request #2633:
URL: https://github.com/apache/netbeans/pull/2633#issuecomment-753647005


   For the unittest: That job is flaky - I restartet the test.
   
   For the commit:
   
   Please adjust the title (it is UTF-8, not UTF-1). What I'm missing is a reasoning for the possible issues introduced by this change. How probable is it, that some one used a ISO-8859-1 char from the high range (with the highest bit set) and that that character (or this character and the following characters) form a valid UTF-8 sequence?
   
   For example the sequence `À§` encoded as ISO-8859-1 will yield:
   
   ```
   À       §
   C   0   A   7
   1100000010100111
   ```
   
   That correctly decodes as UTF-8 to 삧 (Hangul Bbic). So this might introduce regressions. 
   
   How does the JDK handle this situation?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists