You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/07 17:40:29 UTC

[GitHub] [incubator-nuttx] v01d opened a new pull request #2492: procfs: make array const to reduce memory use

v01d opened a new pull request #2492:
URL: https://github.com/apache/incubator-nuttx/pull/2492


   ## Summary
   
   Make an array const (not only an array of const elements) so that it is placed on flash and reduces memory requirements.
   
   ## Impact
   
   Reduces memory use
   
   ## Testing
   
   procfs builds OK
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on pull request #2492: procfs: make array const to reduce memory use

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2492:
URL: https://github.com/apache/incubator-nuttx/pull/2492#issuecomment-740197740


   I don't understand the question


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on pull request #2492: procfs: make array const to reduce memory use

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #2492:
URL: https://github.com/apache/incubator-nuttx/pull/2492#issuecomment-740202877


   I think this is part of basic language. Wouldn't expect it to be only part of a specific standard.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #2492: procfs: make array const to reduce memory use

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on pull request #2492:
URL: https://github.com/apache/incubator-nuttx/pull/2492#issuecomment-740202019


   I think the architecture-independent portions of NuttX need to conform to C89. I was asking if C89 supports the use of 'const' in this way.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] hartmannathan edited a comment on pull request #2492: procfs: make array const to reduce memory use

Posted by GitBox <gi...@apache.org>.
hartmannathan edited a comment on pull request #2492:
URL: https://github.com/apache/incubator-nuttx/pull/2492#issuecomment-740202019


   I think the architecture-independent portions of NuttX need to conform to C89. I was asking if C89 supports the use of 'const' in this way. Meanwhile I looked it up. It seems it is C89, so the change looks fine to me.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] hartmannathan merged pull request #2492: procfs: make array const to reduce memory use

Posted by GitBox <gi...@apache.org>.
hartmannathan merged pull request #2492:
URL: https://github.com/apache/incubator-nuttx/pull/2492


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #2492: procfs: make array const to reduce memory use

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on pull request #2492:
URL: https://github.com/apache/incubator-nuttx/pull/2492#issuecomment-740197055


   Is this usage consistent with C89?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #2492: procfs: make array const to reduce memory use

Posted by GitBox <gi...@apache.org>.
hartmannathan commented on pull request #2492:
URL: https://github.com/apache/incubator-nuttx/pull/2492#issuecomment-740203159


   Yes, it's fine. I approved it. Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org