You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Suresh Srinivas (Created) (JIRA)" <ji...@apache.org> on 2011/10/26 19:33:32 UTC
[jira] [Created] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Add support for protocol buffer based RPC engine
------------------------------------------------
Key: HADOOP-7773
URL: https://issues.apache.org/jira/browse/HADOOP-7773
Project: Hadoop Common
Issue Type: Improvement
Components: ipc
Affects Versions: 0.23.0, 0.24.0
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7773:
------------------------------------
Attachment: HADOOP-7773.txt
I added test for protobuf RPC engine.
Sanjay as regards to your comment, it is better to be done starting the base class RpcEngine.Server
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Sanjay Radia (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136669#comment-13136669 ]
Sanjay Radia commented on HADOOP-7773:
--------------------------------------
Agree - making the parameter types use generics can only be done if the lower layer also supports it. Separate Jira.
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7773:
------------------------------------
Attachment: HADOOP-7773.txt
The filter change did not seem to work. Doing it in another way.
For some reason, my local build gives 179 findbugs warnings!
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7773:
------------------------------------
Fix Version/s: 0.24.0
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136682#comment-13136682 ]
Hadoop QA commented on HADOOP-7773:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12500987/HADOOP-7773.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 17 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/327//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/327//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/327//console
This message is automatically generated.
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7773:
------------------------------------
Attachment: HADOOP-7773.txt
Updated patch.
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138945#comment-13138945 ]
Hudson commented on HADOOP-7773:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #1193 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1193/])
HADOOP-7773. Add support for protocol buffer based RPC engine. Contributed by Suresh Srinivas.
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190611
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto/hadoop_rpc.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136791#comment-13136791 ]
Hadoop QA commented on HADOOP-7773:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501033/HADOOP-7773.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 17 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/329//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/329//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/329//console
This message is automatically generated.
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7773:
------------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I committed the patch.
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139273#comment-13139273 ]
Hudson commented on HADOOP-7773:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #878 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/878/])
HADOOP-7773. Add support for protocol buffer based RPC engine. Contributed by Suresh Srinivas.
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190611
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto/hadoop_rpc.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Sanjay Radia (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137817#comment-13137817 ]
Sanjay Radia commented on HADOOP-7773:
--------------------------------------
Thanks for adding the test.
+1
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138805#comment-13138805 ]
Suresh Srinivas commented on HADOOP-7773:
-----------------------------------------
I am going to commit the patch, since I could not fix findbugs issue from the generated code with a filter. This probably is a build issue.
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137666#comment-13137666 ]
Hadoop QA commented on HADOOP-7773:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12501167/HADOOP-7773.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 17 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/335//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/335//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/335//console
This message is automatically generated.
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136163#comment-13136163 ]
Todd Lipcon commented on HADOOP-7773:
-------------------------------------
Nice! Are you planning to add some unit tests as well?
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138936#comment-13138936 ]
Hudson commented on HADOOP-7773:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #1269 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1269/])
HADOOP-7773. Add support for protocol buffer based RPC engine. Contributed by Suresh Srinivas.
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190611
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto/hadoop_rpc.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Suresh Srinivas (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136185#comment-13136185 ]
Suresh Srinivas commented on HADOOP-7773:
-----------------------------------------
I tested it by moving JournalProtocol in HDFS to protobuf and testing it. Unfortunately I had to hack a lot of things in HDFS to have two RPC servers one for writable and one for protobuf (currently both protocols cannot be supported by the same RPC server, since an RPC engine is chosen as Writable or Protobuf but not both).
Writing test means, having a test.proto etc. Thought I can avoid that work, since HDFS will move to protobuf and this gets tested as a part of that. If we still feel it is worth having tests, I will put in that time.
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138863#comment-13138863 ]
Hudson commented on HADOOP-7773:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #1215 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1215/])
HADOOP-7773. Add support for protocol buffer based RPC engine. Contributed by Suresh Srinivas.
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190611
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto/hadoop_rpc.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Sanjay Radia (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sanjay Radia updated HADOOP-7773:
---------------------------------
Issue Type: Sub-task (was: Improvement)
Parent: HADOOP-7775
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Todd Lipcon (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136255#comment-13136255 ]
Todd Lipcon commented on HADOOP-7773:
-------------------------------------
I think we should have at least a simple test in the Common project -- otherwise we'll only rely on cross-project test breakage when we make changes to this code. But I'm OK with the tests happening as a follow-up JIRA.
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7773:
------------------------------------
Attachment: HADOOP-7773.txt
findbugs warnings are due to generated code. New patch adds findbug filter to suppress these warnings.
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139251#comment-13139251 ]
Hudson commented on HADOOP-7773:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #847 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/847/])
HADOOP-7773. Add support for protocol buffer based RPC engine. Contributed by Suresh Srinivas.
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1190611
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/dev-support/findbugsExcludeFile.xml
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/ProtobufRpcEngine.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RpcServerException.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/protobuf/HadoopRpcProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/proto/hadoop_rpc.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/protobuf/TestRpcServiceProtos.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test.proto
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/proto/test_rpc_service.proto
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0
>
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7773:
------------------------------------
Status: Patch Available (was: Open)
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7773:
-------------------------------------------
Affects Version/s: (was: 0.23.0)
Fix Version/s: 0.23.3
I have merged this to 0.23.
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: ipc
> Affects Versions: 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.24.0, 0.23.3
>
> Attachments: HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt, HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Suresh Srinivas (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-7773:
------------------------------------
Attachment: HADOOP-7773.txt
This patch adds protobuf messages for marshaling the request, response between the RPC client and server. It also adds an RPC engine for protocol buffers.
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7773) Add support for protocol buffer
based RPC engine
Posted by "Sanjay Radia (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136373#comment-13136373 ]
Sanjay Radia commented on HADOOP-7773:
--------------------------------------
Please replace your
{code}
public Server(Object instance, Configuration conf, String bindAddress,
int port, int numHandlers, int numReaders, int queueSizePerHandler,
boolean verbose, SecretManager<? extends TokenIdentifier> secretManager)
{code}
by
{code}
public <PROTO, IMPL extends PROTO> Server(Class<PROTO> protocolClass, IMPL protocolImpl,
Configuration conf, String bindAddress, int port,
int numHandlers, int numReaders, int queueSizePerHandler,
boolean verbose, SecretManager<? extends TokenIdentifier> secretManager)
{code}
Also change your RPC.server getServer(...) accordingly.
Style suggestion.
You have 2 methods after your "static class Server"; please move them to before so that all the methods of ProtobufRpcEngine are together.
Please add tests.
+1 otherwise.
> Add support for protocol buffer based RPC engine
> ------------------------------------------------
>
> Key: HADOOP-7773
> URL: https://issues.apache.org/jira/browse/HADOOP-7773
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-7773.txt
>
>
> This jira adds support for protocol buffer RPC engine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira