You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/03/12 03:52:15 UTC

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7234: lifecycle stage refactor to ensure proper start and stop ordering of servers and announcements

clintropolis commented on a change in pull request #7234: lifecycle stage refactor to ensure proper start and stop ordering of servers and announcements
URL: https://github.com/apache/incubator-druid/pull/7234#discussion_r264512971
 
 

 ##########
 File path: extensions-contrib/materialized-view-selection/src/main/java/org/apache/druid/query/materializedview/DerivativeDataSourceManager.java
 ##########
 @@ -65,7 +65,7 @@
  * Read and store derivatives information from dataSource table frequently.
  * When optimize query, DerivativesManager offers the information about derivatives.
  */
-@ManageLifecycleLast
+@ManageLifecycleAnnouncements
 
 Review comment:
   Good question, I'll see if I can dig up why it was marked `@ManageLifecycleLast` prior to this PR...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org