You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "romseygeek (via GitHub)" <gi...@apache.org> on 2026/06/01 13:08:57 UTC

[PR] SkipBlockRangeIterator: Don't extend docIdRunEnd into sparse blocks [lucene]

romseygeek opened a new pull request, #16161:
URL: https://github.com/apache/lucene/pull/16161

   When docIdRunEnd is called when positioned in a YES block, we climb through the levels to see how far we can extend the run end, but were failing to check that the higher-level blocks contained values for all documents.
   
   This adds that check and updates BaseDocValuesSkipperTests to include ranges that exercise the bug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] SkipBlockRangeIterator: Don't extend docIdRunEnd into sparse blocks [lucene]

Posted by "iverase (via GitHub)" <gi...@apache.org>.
iverase commented on code in PR #16161:
URL: https://github.com/apache/lucene/pull/16161#discussion_r3334438074


##########
lucene/core/src/java/org/apache/lucene/search/SkipBlockRangeIterator.java:
##########
@@ -130,7 +130,9 @@ public int docIDRunEnd() throws IOException {
     int nextLevel = 1;
     while (nextLevel < skipper.numLevels()
         && skipper.minValue(nextLevel) >= minValue
-        && skipper.maxValue(nextLevel) <= maxValue) {
+        && skipper.maxValue(nextLevel) <= maxValue
+        && skipper.maxDocID(nextLevel) - skipper.minDocID(nextLevel)

Review Comment:
   👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] SkipBlockRangeIterator: Don't extend docIdRunEnd into sparse blocks [lucene]

Posted by "romseygeek (via GitHub)" <gi...@apache.org>.
romseygeek merged PR #16161:
URL: https://github.com/apache/lucene/pull/16161


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org