You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/08 16:49:50 UTC
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1448: MINIFICPP-1977 Upgrade pybind11 to support Python 3.11
lordgamez commented on code in PR #1448:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1448#discussion_r1016883886
##########
extensions/script/tests/CMakeLists.txt:
##########
@@ -49,6 +45,17 @@ FOREACH(testfile ${EXECUTESCRIPT_PYTHON_TESTS})
createTests("${testfilename}")
MATH(EXPR EXTENSIONS_TEST_COUNT "${EXTENSIONS_TEST_COUNT}+1")
add_test(NAME "${testfilename}" COMMAND "${testfilename}" WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
+
+ if(EXTENSIONS_TEST_COUNT EQUAL 1)
+ # Copy test resources
+ add_custom_command(
Review Comment:
Good point, added comment in f0fa8ce115fe1c892e25d14d87b6bbb26c586f1f
##########
extensions/script/tests/CMakeLists.txt:
##########
@@ -73,6 +80,17 @@ FOREACH(testfile ${EXECUTEPYTHONPROCESSOR_UNIT_TESTS})
createTests("${testfilename}")
add_test(NAME "${testfilename}" COMMAND "${testfilename}" WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
MATH(EXPR EXTENSIONS_TEST_COUNT "${EXTENSIONS_TEST_COUNT}+1")
+
+ if(EXTENSIONS_TEST_COUNT EQUAL 1)
Review Comment:
Updated in f0fa8ce115fe1c892e25d14d87b6bbb26c586f1f
##########
extensions/standard-processors/tests/CMakeLists.txt:
##########
@@ -48,14 +48,16 @@ FOREACH(testfile ${PROCESSOR_UNIT_TESTS})
MATH(EXPR PROCESSOR_INT_TEST_COUNT "${PROCESSOR_INT_TEST_COUNT}+1")
- # Copy test resources
- add_custom_command(
- TARGET "${testfilename}"
- POST_BUILD
- COMMAND ${CMAKE_COMMAND} -E copy_directory
- "${CMAKE_SOURCE_DIR}/extensions/standard-processors/tests/unit/resources"
- "$<TARGET_FILE_DIR:${testfilename}>/resources"
- )
+ if(PROCESSOR_INT_TEST_COUNT EQUAL 1)
Review Comment:
Updated in f0fa8ce115fe1c892e25d14d87b6bbb26c586f1f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org