You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Stephen Connolly (JIRA)" <ji...@codehaus.org> on 2010/01/12 17:54:55 UTC

[jira] Created: (MGPG-19) Site descriptor does not get signed

Site descriptor does not get signed
-----------------------------------

                 Key: MGPG-19
                 URL: http://jira.codehaus.org/browse/MGPG-19
             Project: Maven 2.x GPG Plugin
          Issue Type: Bug
    Affects Versions: 1.0-alpha-4
            Reporter: Stephen Connolly
            Priority: Blocker


When the site descriptor is an attached artifact, the GPG signature is not generated.

Steps to reproduce:

svn co https://svn.apache.org/repos/asf/maven/surefire/tags/surefire-2.5@898285 surefire-2.5
cd surefire-2.5
mvn site:attach-descriptor gpg:sign -Papache-release -N
ls target/*.asc

if there is a surefire-2.5-site.xml.asc then this bug is fixed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MGPG-19) Site descriptor does not get signed

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MGPG-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=220597#action_220597 ] 

Dennis Lundberg commented on MGPG-19:
-------------------------------------

I've applied a fix to version 2.1.1-SNAPSHOT of the Site Plugin. The IT for the attach-descriptor mojo was expanded and passes. Stephen's Surefire example also works for me with that version. However since this is a change in the Site Plugin's behavior we need as many testers as possible. Report your findings either in this issue or better in MSITE-478.

> Site descriptor does not get signed
> -----------------------------------
>
>                 Key: MGPG-19
>                 URL: http://jira.codehaus.org/browse/MGPG-19
>             Project: Maven 2.x GPG Plugin
>          Issue Type: Bug
>    Affects Versions: 1.0-alpha-4
>            Reporter: Stephen Connolly
>            Priority: Blocker
>
> When the site descriptor is an attached artifact, the GPG signature is not generated.
> Steps to reproduce:
> svn co https://svn.apache.org/repos/asf/maven/surefire/tags/surefire-2.5@898285 surefire-2.5
> cd surefire-2.5
> mvn site:attach-descriptor gpg:sign -Papache-release -N
> ls target/*.asc
> if there is a surefire-2.5-site.xml.asc then this bug is fixed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MGPG-19) Site descriptor does not get signed

Posted by "Michael Heuer (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MGPG-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=215032#action_215032 ] 

Michael Heuer commented on MGPG-19:
-----------------------------------

Is there a workaround for this problem?  This is preventing me from being able to stage in Nexus, see

https://issues.sonatype.org/browse/OSSRH-321

> Site descriptor does not get signed
> -----------------------------------
>
>                 Key: MGPG-19
>                 URL: http://jira.codehaus.org/browse/MGPG-19
>             Project: Maven 2.x GPG Plugin
>          Issue Type: Bug
>    Affects Versions: 1.0-alpha-4
>            Reporter: Stephen Connolly
>            Priority: Blocker
>
> When the site descriptor is an attached artifact, the GPG signature is not generated.
> Steps to reproduce:
> svn co https://svn.apache.org/repos/asf/maven/surefire/tags/surefire-2.5@898285 surefire-2.5
> cd surefire-2.5
> mvn site:attach-descriptor gpg:sign -Papache-release -N
> ls target/*.asc
> if there is a surefire-2.5-site.xml.asc then this bug is fixed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MGPG-19) Site descriptor does not get signed

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MGPG-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=206712#action_206712 ] 

Dennis Lundberg commented on MGPG-19:
-------------------------------------

I had a look at how the Site Plugin attaches the descriptor. It is attached as metadata to the artifact - not as an attached artifact. ArtifactMetadata has no accessors to any File object, but ProjectArtifactMetadata has a private variable that holds a File. That private variable is used to copy the file to the local repository during install, but again it is private.

Without a file we can't sign it AFAICT. If we install the site descriptor into the local repository *before* we try to sign it, we should be able to access it from the local repo. But I'm not sure how well that works with the life cycle. I think it's a chicken-and-egg problem.

> Site descriptor does not get signed
> -----------------------------------
>
>                 Key: MGPG-19
>                 URL: http://jira.codehaus.org/browse/MGPG-19
>             Project: Maven 2.x GPG Plugin
>          Issue Type: Bug
>    Affects Versions: 1.0-alpha-4
>            Reporter: Stephen Connolly
>            Priority: Blocker
>
> When the site descriptor is an attached artifact, the GPG signature is not generated.
> Steps to reproduce:
> svn co https://svn.apache.org/repos/asf/maven/surefire/tags/surefire-2.5@898285 surefire-2.5
> cd surefire-2.5
> mvn site:attach-descriptor gpg:sign -Papache-release -N
> ls target/*.asc
> if there is a surefire-2.5-site.xml.asc then this bug is fixed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MGPG-19) Site descriptor does not get signed

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MGPG-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann closed MGPG-19.
---------------------------------

    Resolution: Won't Fix
      Assignee: Benjamin Bentmann

Out of scope for the GPG Plugin itself, added a FAQ mentioning the requirement to update the Site Plugin instead.

> Site descriptor does not get signed
> -----------------------------------
>
>                 Key: MGPG-19
>                 URL: http://jira.codehaus.org/browse/MGPG-19
>             Project: Maven 2.x GPG Plugin
>          Issue Type: Bug
>    Affects Versions: 1.0-alpha-4
>            Reporter: Stephen Connolly
>            Assignee: Benjamin Bentmann
>            Priority: Blocker
>
> When the site descriptor is an attached artifact, the GPG signature is not generated.
> Steps to reproduce:
> svn co https://svn.apache.org/repos/asf/maven/surefire/tags/surefire-2.5@898285 surefire-2.5
> cd surefire-2.5
> mvn site:attach-descriptor gpg:sign -Papache-release -N
> ls target/*.asc
> if there is a surefire-2.5-site.xml.asc then this bug is fixed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MGPG-19) Site descriptor does not get signed

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MGPG-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=206718#action_206718 ] 

Brett Porter commented on MGPG-19:
----------------------------------

it should be getting into the local repository first, as that's how the deploy mechanism works. However, that'd be a one off solution - sounds like a Maven issue that the metadata can't be enumerated. Perhaps it is better to change the site plugin to attach it as an artifact instead (it probably should be anyway?)

> Site descriptor does not get signed
> -----------------------------------
>
>                 Key: MGPG-19
>                 URL: http://jira.codehaus.org/browse/MGPG-19
>             Project: Maven 2.x GPG Plugin
>          Issue Type: Bug
>    Affects Versions: 1.0-alpha-4
>            Reporter: Stephen Connolly
>            Priority: Blocker
>
> When the site descriptor is an attached artifact, the GPG signature is not generated.
> Steps to reproduce:
> svn co https://svn.apache.org/repos/asf/maven/surefire/tags/surefire-2.5@898285 surefire-2.5
> cd surefire-2.5
> mvn site:attach-descriptor gpg:sign -Papache-release -N
> ls target/*.asc
> if there is a surefire-2.5-site.xml.asc then this bug is fixed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MGPG-19) Site descriptor does not get signed

Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MGPG-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=215033#action_215033 ] 

Benjamin Bentmann commented on MGPG-19:
---------------------------------------

bq. Is there a workaround for this problem? 
You can still manually sign and deploy the file.

> Site descriptor does not get signed
> -----------------------------------
>
>                 Key: MGPG-19
>                 URL: http://jira.codehaus.org/browse/MGPG-19
>             Project: Maven 2.x GPG Plugin
>          Issue Type: Bug
>    Affects Versions: 1.0-alpha-4
>            Reporter: Stephen Connolly
>            Priority: Blocker
>
> When the site descriptor is an attached artifact, the GPG signature is not generated.
> Steps to reproduce:
> svn co https://svn.apache.org/repos/asf/maven/surefire/tags/surefire-2.5@898285 surefire-2.5
> cd surefire-2.5
> mvn site:attach-descriptor gpg:sign -Papache-release -N
> ls target/*.asc
> if there is a surefire-2.5-site.xml.asc then this bug is fixed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira