You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/06/09 05:31:03 UTC

[GitHub] [airflow] potiuk commented on issue #5335: [AIRFLOW-4588] Add GoogleApiClientHook

potiuk commented on issue #5335: [AIRFLOW-4588] Add GoogleApiClientHook
URL: https://github.com/apache/airflow/pull/5335#issuecomment-500186292
 
 
   @feluelle  - do you want to follow up on that ? My only concern with that one is that it introduces a new base GCP hook where we already have one.  
   
   Maybe you could simply start with rewriting your [code](https://gist.github.com/feluelle/ff7d14617c983a3230d91b180d206ca2#file-google_api_integration_in_airflow-py-L51) to use the GCP API base hook (including the credentials retrieval that is already there) and then you could move some of the methods to the base hook (like the pagination). 
   
   Then you could also contribute the whole Google API to S3 operator. It seems useful to have such generic solution.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services