svn commit: r486435 - /incubator/mod_ftp/trunk/modules/ftp/mod_ftp.c

[wr...@apache.org]

Author: wrowe
Date: Tue Dec 12 16:30:46 2006
New Revision: 486435

URL: http://svn.apache.org/viewvc?view=rev&rev=486435
Log:
Begin commenting all -Wall emits

Modified:
    incubator/mod_ftp/trunk/modules/ftp/mod_ftp.c

Modified: incubator/mod_ftp/trunk/modules/ftp/mod_ftp.c
URL: http://svn.apache.org/viewvc/incubator/mod_ftp/trunk/modules/ftp/mod_ftp.c?view=diff&rev=486435&r1=486434&r2=486435
==============================================================================
--- incubator/mod_ftp/trunk/modules/ftp/mod_ftp.c (original)
+++ incubator/mod_ftp/trunk/modules/ftp/mod_ftp.c Tue Dec 12 16:30:46 2006
@@ -249,12 +249,16 @@
 
 static void *merge_ftp_dir_config(apr_pool_t *p, void *basev, void *addv)
 {
+    /* XXX: base is unused, this is always symptomatic of bad config
+            design.  Needs review.
+     */
     ftp_dir_config *base = (ftp_dir_config *)basev;
     ftp_dir_config *add  = (ftp_dir_config *)addv;
     ftp_dir_config *conf  = apr_palloc(p, sizeof(*conf));
 
     /* We default to the add config, so any directive not
      * handled here won't be inherited through directories.
+     * XXX: which happens to be stupid (unexpected) behavior.
      */
     memcpy (conf, add, sizeof(*conf));