[jira] [Commented] (HIVE-18330) Fix TestMsgBusConnection - doesn't test tests the original intention

["Zoltan Haindrich (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-18330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16301468#comment-16301468 ] 

Zoltan Haindrich commented on HIVE-18330:
-----------------------------------------

I'm not sure which would be the preffered way to fix this:

   # make the current behavior sacred: if the AMQ service is offline; no metastore operations can be done => adjust test 
   # tolerate that the AMQ is offline in {{NotificationListener}} => adjust it to not throw NPE
   # are there any known users of this feature? It would be great to know that they prefer the current logic or not...

[~thejas], [~ashutoshc]:  I'm not sure which option is the preffered; I will go with the 2. for now ; because all exceptions were just logged everywhere...so I guess the original intention was to keep working in case AMQ is down.

> Fix TestMsgBusConnection - doesn't test tests the original intention
> --------------------------------------------------------------------
>
>                 Key: HIVE-18330
>                 URL: https://issues.apache.org/jira/browse/HIVE-18330
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>         Attachments: HIVE-18330.01.patch
>
>
> If the msgbus usage is configured; and the ActiveMQ broker is down; the notificationlistener throws NPEs.
> this test should have never been passed...there is a point where it drops a database; and that command returns with an error - there are other things which are intresting....like create database on an existing db is sucess somewhere  - so it get posted to the msgbus.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)