You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by jd...@apache.org on 2009/08/07 22:11:30 UTC
svn commit: r802166 -
/maven/resources/trunk/apache-source-release-assembly-descriptor/src/main/resources/assemblies/source-release.xml
Author: jdcasey
Date: Fri Aug 7 20:11:30 2009
New Revision: 802166
URL: http://svn.apache.org/viewvc?rev=802166&view=rev
Log:
Consolidate the various excludes for files used by major IDEs, the release plugin, and other files that are generally excluded by SVN.
Modified:
maven/resources/trunk/apache-source-release-assembly-descriptor/src/main/resources/assemblies/source-release.xml
Modified: maven/resources/trunk/apache-source-release-assembly-descriptor/src/main/resources/assemblies/source-release.xml
URL: http://svn.apache.org/viewvc/maven/resources/trunk/apache-source-release-assembly-descriptor/src/main/resources/assemblies/source-release.xml?rev=802166&r1=802165&r2=802166&view=diff
==============================================================================
--- maven/resources/trunk/apache-source-release-assembly-descriptor/src/main/resources/assemblies/source-release.xml (original)
+++ maven/resources/trunk/apache-source-release-assembly-descriptor/src/main/resources/assemblies/source-release.xml Fri Aug 7 20:11:30 2009
@@ -24,17 +24,53 @@
<format>zip</format>
</formats>
<fileSets>
+ <!-- main project directory structure -->
<fileSet>
<directory>.</directory>
<outputDirectory>/</outputDirectory>
<useDefaultExcludes>true</useDefaultExcludes>
<excludes>
- <exclude>%regex[(?!.*src/).*target.*]</exclude>
+ <!-- build output -->
+ <exclude>%regex[(?!.*src/).*${project.build.directory}.*]</exclude>
+
+ <!-- NOTE: Most of the following excludes should not be required
+ if the standard release process is followed. This is because the
+ release plugin checks out project sources into a location like
+ target/checkout, then runs the build from there. The result is
+ a source-release archive that comes from a pretty clean directory
+ structure.
+
+ HOWEVER, if the release plugin is configured to run extra goals
+ or generate a project website, it's definitely possible that some
+ of these files will be present. So, it's safer to exclude them.
+ -->
+
+ <!-- IDEs -->
<exclude>**/.settings/**</exclude>
<exclude>**/.project</exclude>
<exclude>**/.classpath</exclude>
+ <exclude>**/.externalToolBuilders/**</exclude>
+ <exclude>**/maven-eclipse.xml</exclude>
+ <exclude>**/.deployables/**</exclude>
+ <exclude>**/.wtpmodules/**</exclude>
+ <exclude>**/*.iws</exclude>
+ <exclude>**/*.ipr</exclude>
+ <exclude>**/*.iml</exclude>
+ <!-- misc -->
<exclude>**/cobertura.ser</exclude>
+ <exclude>**/*.bak</exclude>
+ <exclude>**/*.diff</exclude>
+ <exclude>**/*.patch</exclude>
+ <exclude>**/*.log</exclude>
+ <!-- release-plugin temp files -->
+ <exclude>**/pom.xml.releaseBackup</exclude>
+ <exclude>**/release.properties</exclude>
</excludes>
</fileSet>
+ <!-- license, readme, etc. calculated at build time -->
+ <fileSet>
+ <directory>${project.build.directory}/maven-shared-archive-resources/META-INF</directory>
+ <outputDirectory>/</outputDirectory>
+ </fileSet>
</fileSets>
</assembly>
Re: svn commit: r802166 - /maven/resources/trunk/apache-source-release-assembly-descriptor/src/main/resources/assemblies/source-release.xml
Posted by Brian Fox <br...@infinity.nu>.
The cobertura one yes because it would be produced potentially by the
tests. The others probably have less harm.
On Mon, Aug 10, 2009 at 4:41 PM, Brett Porter<br...@apache.org> wrote:
>
> On 07/08/2009, at 4:11 PM, jdcasey@apache.org wrote:
>
>> + <!-- misc -->
>> <exclude>**/cobertura.ser</exclude>
>> + <exclude>**/*.bak</exclude>
>> + <exclude>**/*.diff</exclude>
>> + <exclude>**/*.patch</exclude>
>> + <exclude>**/*.log</exclude>
>
> I feel like these could start knocking out legitimate files.
>
> Are they really necessary since it is usually built from a clean checkout?
>
> - Brett
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Source-release excludes patterns [was: Re: svn commit: r802166]
Posted by John Casey <jd...@commonjava.org>.
This is something I wanted to bring up on the dev list, actually. I
simply went through all of the source-release assembly descriptors used
to release various plugins, and compiled all of the exclusion patterns.
I'm not sure it's a good idea to leave these or any of them out, but I
can definitely see that at least in the case of the cobertura.ser file,
it is probably not the intention of the user to leave it in.
As for the rest, I'm fine with dropping them; I wanted to get the
opinion of others...
Brett Porter wrote:
>
> On 07/08/2009, at 4:11 PM, jdcasey@apache.org wrote:
>
>> + <!-- misc -->
>> <exclude>**/cobertura.ser</exclude>
>> + <exclude>**/*.bak</exclude>
>> + <exclude>**/*.diff</exclude>
>> + <exclude>**/*.patch</exclude>
>> + <exclude>**/*.log</exclude>
>
> I feel like these could start knocking out legitimate files.
>
> Are they really necessary since it is usually built from a clean checkout?
>
> - Brett
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r802166 - /maven/resources/trunk/apache-source-release-assembly-descriptor/src/main/resources/assemblies/source-release.xml
Posted by Brett Porter <br...@apache.org>.
On 07/08/2009, at 4:11 PM, jdcasey@apache.org wrote:
> + <!-- misc -->
> <exclude>**/cobertura.ser</exclude>
> + <exclude>**/*.bak</exclude>
> + <exclude>**/*.diff</exclude>
> + <exclude>**/*.patch</exclude>
> + <exclude>**/*.log</exclude>
I feel like these could start knocking out legitimate files.
Are they really necessary since it is usually built from a clean
checkout?
- Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org