You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "EMsnap (via GitHub)" <gi...@apache.org> on 2023/09/21 01:35:06 UTC

[GitHub] [inlong] EMsnap commented on a diff in pull request #8954: [INLONG-8953][Sort] Fix Iceberg source defaults the StartSnapshot to the latest

EMsnap commented on code in PR #8954:
URL: https://github.com/apache/inlong/pull/8954#discussion_r1332343561


##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/extract/IcebergExtractNode.java:
##########
@@ -110,7 +110,10 @@ public Map<String, String> tableOptions() {
         options.put(IcebergConstant.TABLE_KEY, tableName);
         options.put(IcebergConstant.CATALOG_TYPE_KEY, catalogType.name());
         options.put(IcebergConstant.CATALOG_NAME_KEY, catalogName);
+        // support streaming only
         options.put(IcebergConstant.STREAMING, "true");
+        options.put(IcebergConstant.STARTING_STRATEGY_KEY,

Review Comment:
   Guess we need this parameter to be configurable, use FROM_LATEST by default and stili we support changing it 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org