You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@quickstep.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/02/01 20:16:00 UTC

[jira] [Commented] (QUICKSTEP-113) glog upgrade

    [ https://issues.apache.org/jira/browse/QUICKSTEP-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349192#comment-16349192 ] 

ASF GitHub Bot commented on QUICKSTEP-113:
------------------------------------------

Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/327
  
    Hi @hbdeshmukh,
    
    This PR that uses `glog 0.3.5` has a side effect that does not catch before: [it requires `cmake` version `3.0`](https://github.com/google/glog/blob/v0.3.5/CMakeLists.txt#L1), but the default `cmake` version in `Ubuntu 14.04 LTS` is `2.8.12.2`.


> glog upgrade
> ------------
>
>                 Key: QUICKSTEP-113
>                 URL: https://issues.apache.org/jira/browse/QUICKSTEP-113
>             Project: Apache Quickstep
>          Issue Type: Improvement
>            Reporter: Harshad Deshmukh
>            Assignee: Harshad Deshmukh
>            Priority: Major
>
> Right now glog is manually copied in the third_party/src directory. The current version of glog is old and needs an upgrade. It will be better if the glog is also downloaded and patched just like some other third party libraries. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)