You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "assignUser (via GitHub)" <gi...@apache.org> on 2024/07/21 18:52:50 UTC
[PR] MINOR: [R] Fix non pkg-config link order [arrow]
assignUser opened a new pull request, #43353:
URL: https://github.com/apache/arrow/pull/43353
### Rationale for this change
@kou [discovered](https://github.com/apache/arrow/issues/43337#issuecomment-2241297521) that our link order is wrong when not using pkg-config.
### What changes are included in this PR?
Update the link order.
### Are these changes tested?
CI
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2891045268
@assignUser Do you know if this is still an issue any more or did it get resolved in another PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-4508177602
Thank you for your contribution. Unfortunately, this pull request has been marked as stale because it has had no activity in the past 365 days. Please remove the stale label or comment below, or this PR will be closed in 14 days. Feel free to re-open this if it has been closed in error. If you do not have repository permissions to reopen the PR, please tag a maintainer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2244218232
@kou actually the wrong order doesn't produce a linking error https://github.com/ursacomputing/crossbow/actions/runs/10052475149/job/27783717569#step:9:1882
but it did help uncover the issue with pkg-config, so imo this was still worth it :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2246459316
Revision: 9de5f131b6a46e310dfafd27ae2975fd251fe582
Submitted crossbow builds: [ursacomputing/crossbow @ actions-5a8f2099cf](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5a8f2099cf)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/10067703432/job/27831706530)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/10067703232/job/27831692754)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/10067703279/job/27831693266)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/27831693792)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/27831694527)|
|test-r-rstudio-r-base-4.1-opensuse155|[](https://github.com/ursacomputing/crossbow/runs/27831694172)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2244134889
@github-actions crossbow submit test-r-install-local
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2246457165
@github-actions crossbow submit r-binary-packages test-r-install-local* test-r-rhub-debian-gcc-* test-r-rstudio-r-base-4.1-opensuse155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2244200992
Revision: c2d2470c914b78a67d1363118f72d828e92fd7d2
Submitted crossbow builds: [ursacomputing/crossbow @ actions-5b39cc7bdb](https://github.com/ursacomputing/crossbow/branches/all?query=actions-5b39cc7bdb)
|Task|Status|
|----|------|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/10052422948/job/27783572390)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2244096832
:warning: GitHub issue #43379 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2244221048
Revision: 3e048f941c984651e93902d1a808d499b6d71dc3
Submitted crossbow builds: [ursacomputing/crossbow @ actions-0d8378dffa](https://github.com/ursacomputing/crossbow/branches/all?query=actions-0d8378dffa)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/10052620890/job/27784112406)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/10052620935/job/27784103531)|
|test-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/10052620952/job/27784103526)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/27784104709)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/10052620961/job/27784103544)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/10052620809/job/27784103187)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/10052620820/job/27784103382)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/10052621065/job/27784103937)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/10052620971/job/27784103651)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/10052621015/job/27784103871)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/10052620787/job/27784103287)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/10052621102/job/27784104409)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/10052620788/job/27784103176)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/10052621014/job/27784103769)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/27784104810)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/10052620985/job/27784103654)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/27784104652)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/27784104708)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/27784104433)|
|test-r-rhub-ubuntu-release-latest|[](https://github.com/ursacomputing/crossbow/runs/27784105116)|
|test-r-rocker-r-ver-latest|[](https://github.com/ursacomputing/crossbow/runs/27784104896)|
|test-r-rstudio-r-base-4.1-opensuse155|[](https://github.com/ursacomputing/crossbow/runs/27784104702)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/27784104726)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/10052621040/job/27784103804)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/10052621055/job/27784104181)|
|test-ubuntu-r-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/10052620847/job/27784103388)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2244239256
> @kou actually the wrong order doesn't produce a linking error https://github.com/ursacomputing/crossbow/actions/runs/10052475149/job/27783717569#step:9:1882
Hmm. It seems that the R package doesn't use dataset API that depends on Acero.
> but it did help uncover the issue with pkg-config, so imo this was still worth it :D
I think so too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2244136800
Revision: c1141facb5eefe465674f8bb0e13d14031ca9314
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1dab16c0b5](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1dab16c0b5)
|Task|Status|
|----|------|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/10051713679/job/27781758137)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Fix non pkg-config link order [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2244086015
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2246653657
@kou I found another issue, with some of our dependencies if both .a and .so are on the system and pkg-config is found it will use the shared version regardless of `ARROW_DEPENDENCY_USE_SHARED=OFF` e.g. here lz4 https://github.com/ursacomputing/crossbow/actions/runs/10067703232/job/27831692754#step:9:352
This is the lz4 pc file and it looks like it's not made to be linked statically (if cmake even pass `--static`) if both libs are installed:
```
prefix=/usr
libdir=/usr/lib
includedir=/usr/include
Name: lz4
Description: extremely fast lossless compression algorithm library
URL: http://www.lz4.org/
Version: 1.9.2
Libs: -L/usr/lib -llz4
Cflags: -I/usr/include
```
`ARROW_DEPENDENCY_USE_SHARED=OFF` is def. the right setting for the libarrow R build and this actually shows an issue. This happens now because the R package is not using pc as intended but libarrow still is. And in the non-pc code path we only add `-llibarrow_bundled_dependencies.a` and not `-llz4` or any other deps.
I am not to familiar with the cmake pc module, is there away to enforce use of static libs? Or do we have to check that manually somehow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2244218720
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2244148547
As expected a link error has surfaced now that pkg-config is NOT being used: https://github.com/ursacomputing/crossbow/actions/runs/10051713679/job/27781757982#step:9:1886
https://github.com/ursacomputing/crossbow/actions/runs/10051713679/job/27781757982#step:9:36
I will add the fix back in and run the job again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2244207319
Revision: 93cfadcaf0a6c1c4a0b6226db05a33a56a5f62bc
Submitted crossbow builds: [ursacomputing/crossbow @ actions-6e0305fa14](https://github.com/ursacomputing/crossbow/branches/all?query=actions-6e0305fa14)
|Task|Status|
|----|------|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/10052475149/job/27783717757)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2247267862
Ah, we can't enforce using `liblz4.a` even if we use `pkg-config --static`...
We may need to use CMake package instead of `.pc` for static linking like Meson does.
Or we embed `/absolute/path/to/liblz4.a` into our `arrow.pc`. (It's done when `liblz4.pc` can't be found but we can enforce it by adding a new CMake option to our build system.)
I'll explain it later...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2402338481
This is marked as 18.0.0 it is a blocker? @assignUser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2249753553
For example:
```diff
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 5b89a831ff..aad408f04c 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -259,7 +259,7 @@ macro(resolve_dependency DEPENDENCY_NAME)
IS_RUNTIME_DEPENDENCY
REQUIRED_VERSION
USE_CONFIG)
- set(multi_value_args COMPONENTS PC_PACKAGE_NAMES)
+ set(multi_value_args COMPONENTS PC_PACKAGE_NAMES SYSTEM_CMAKE_TARGET_CANDIDATES)
cmake_parse_arguments(ARG
"${options}"
"${one_value_args}"
@@ -339,25 +339,41 @@ macro(resolve_dependency DEPENDENCY_NAME)
string(TOUPPER ${ARG_ARROW_PC_PACKAGE_NAME_SNAKE}
ARG_ARROW_PC_PACKAGE_NAME_UPPER_SNAKE)
if(ARROW_BUILD_STATIC)
- find_package(PkgConfig QUIET)
- foreach(ARG_PC_PACKAGE_NAME ${ARG_PC_PACKAGE_NAMES})
- pkg_check_modules(${ARG_PC_PACKAGE_NAME}_PC
- ${ARG_PC_PACKAGE_NAME}
- NO_CMAKE_PATH
- NO_CMAKE_ENVIRONMENT_PATH
- QUIET)
- set(RESOLVE_DEPENDENCY_PC_PACKAGE
- "pkg-config package for ${ARG_PC_PACKAGE_NAME} ")
- string(APPEND RESOLVE_DEPENDENCY_PC_PACKAGE
- "that is used by ${ARG_ARROW_PC_PACKAGE_NAME} for static link")
- if(${${ARG_PC_PACKAGE_NAME}_PC_FOUND})
- message(STATUS "Using ${RESOLVE_DEPENDENCY_PC_PACKAGE}")
- string(APPEND ${ARG_ARROW_PC_PACKAGE_NAME_UPPER_SNAKE}_PC_REQUIRES_PRIVATE
- " ${ARG_PC_PACKAGE_NAME}")
- else()
- message(STATUS "${RESOLVE_DEPENDENCY_PC_PACKAGE} isn't found")
+ set(TRY_PC TRUE)
+ foreach(ARG_SYSTEM_CMAKE_TARGET_CANDIDATE ${ARG_SYSTEM_CMAKE_TARGET_CANDIDATES})
+ if(NOT TARGET ${ARG_SYSTEM_CMAKE_TARGET_CANDIDATE})
+ continue()
endif()
+ get_target_property(TARGET_TYPE ${ARG_SYSTEM_CMAKE_TARGET_CANDIDATE} TYPE)
+ if(TARGET_TYPE STREQUAL "INTERFACE_LIBRARY")
+ continue()
+ endif()
+ string(APPEND ARROW_PC_LIBS_PRIVATE
+ " $<TARGET_FILE:${ARG_SYSTEM_CMAKE_TARGET_CANDIDATE}>")
+ set(TRY_PC FALSE)
+ braek()
endforeach()
+ if(TRY_PC)
+ find_package(PkgConfig QUIET)
+ foreach(ARG_PC_PACKAGE_NAME ${ARG_PC_PACKAGE_NAMES})
+ pkg_check_modules(${ARG_PC_PACKAGE_NAME}_PC
+ ${ARG_PC_PACKAGE_NAME}
+ NO_CMAKE_PATH
+ NO_CMAKE_ENVIRONMENT_PATH
+ QUIET)
+ set(RESOLVE_DEPENDENCY_PC_PACKAGE
+ "pkg-config package for ${ARG_PC_PACKAGE_NAME} ")
+ string(APPEND RESOLVE_DEPENDENCY_PC_PACKAGE
+ "that is used by ${ARG_ARROW_PC_PACKAGE_NAME} for static link")
+ if(${${ARG_PC_PACKAGE_NAME}_PC_FOUND})
+ message(STATUS "Using ${RESOLVE_DEPENDENCY_PC_PACKAGE}")
+ string(APPEND ${ARG_ARROW_PC_PACKAGE_NAME_UPPER_SNAKE}_PC_REQUIRES_PRIVATE
+ " ${ARG_PC_PACKAGE_NAME}")
+ else()
+ message(STATUS "${RESOLVE_DEPENDENCY_PC_PACKAGE} isn't found")
+ endif()
+ endforeach()
+ endif()
endif()
endif()
endmacro()
@@ -1409,15 +1425,10 @@ if(ARROW_WITH_SNAPPY)
HAVE_ALT
TRUE
PC_PACKAGE_NAMES
- snappy)
- if(${Snappy_SOURCE} STREQUAL "SYSTEM"
- AND NOT snappy_PC_FOUND
- AND ARROW_BUILD_STATIC)
- get_target_property(SNAPPY_TYPE ${Snappy_TARGET} TYPE)
- if(NOT SNAPPY_TYPE STREQUAL "INTERFACE_LIBRARY")
- string(APPEND ARROW_PC_LIBS_PRIVATE " $<TARGET_FILE:${Snappy_TARGET}>")
- endif()
- endif()
+ snappy
+ SYSTEM_CMAKE_TARGET_CANDIDATES
+ Snappy::snappy-static
+ Snappy::Snappy)
endif()
# ----------------------------------------------------------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2244205298
@github-actions crossbow submit test-r-install-local
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2244150662
Revision: b703c466fac7b83e1b5fd9a6d087c1dd33383265
Submitted crossbow builds: [ursacomputing/crossbow @ actions-d5c717a429](https://github.com/ursacomputing/crossbow/branches/all?query=actions-d5c717a429)
|Task|Status|
|----|------|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/10051869716/job/27782162163)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [R] Fix non pkg-config link order [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #43353:
URL: https://github.com/apache/arrow/pull/43353#issuecomment-2244087836
Revision: 0ac29943cf2d9b160cb4298860309fd0e70099f8
Submitted crossbow builds: [ursacomputing/crossbow @ actions-cfe8269cbf](https://github.com/ursacomputing/crossbow/branches/all?query=actions-cfe8269cbf)
|Task|Status|
|----|------|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/10051159922/job/27780293857)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-43379: [R][CI] Fix non pkg-config link order [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #43353: GH-43379: [R][CI] Fix non pkg-config link order
URL: https://github.com/apache/arrow/pull/43353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org