You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "agubichev (via GitHub)" <gi...@apache.org> on 2023/09/22 18:57:05 UTC
[GitHub] [spark] agubichev opened a new pull request, #43061: tests for correlated exists/IN with ORDER BY/LIMIT
agubichev opened a new pull request, #43061:
URL: https://github.com/apache/spark/pull/43061
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jchen5 commented on pull request #43061: [SQL] Throw an error for correlated exists/IN subqueries with LIMIT clauses
Posted by "jchen5 (via GitHub)" <gi...@apache.org>.
jchen5 commented on PR #43061:
URL: https://github.com/apache/spark/pull/43061#issuecomment-1733933103
And can we make sure we have test coverage for all those cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] agubichev commented on pull request #43061: [SQL] Throw an error for correlated exists/IN subqueries with LIMIT clauses
Posted by "agubichev (via GitHub)" <gi...@apache.org>.
agubichev commented on PR #43061:
URL: https://github.com/apache/spark/pull/43061#issuecomment-1741326651
> Hmm, it's true they will be handled but might still be good to have this check in case a user disables the flag DECORRELATE_EXISTS_AND_IN_SUBQUERIES to force the old codepath. So that we throw an exception (as we did before) instead of giving wrong results.
I'll just add it there directly!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] agubichev commented on pull request #43061: [SQL] Throw an error for correlated exists/IN subqueries with LIMIT clauses
Posted by "agubichev (via GitHub)" <gi...@apache.org>.
agubichev commented on PR #43061:
URL: https://github.com/apache/spark/pull/43061#issuecomment-1741273838
Closing this as all the cases are being handled by https://github.com/apache/spark/pull/43111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] allisonwang-db commented on a diff in pull request #43061: [SQL] Throw an error for correlated exists/IN subqueries with LIMIT clauses
Posted by "allisonwang-db (via GitHub)" <gi...@apache.org>.
allisonwang-db commented on code in PR #43061:
URL: https://github.com/apache/spark/pull/43061#discussion_r1340320124
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala:
##########
@@ -283,6 +284,14 @@ object PullupCorrelatedPredicates extends Rule[LogicalPlan] with PredicateHelper
} else {
a
}
+ case l @ Limit(_, _) if predicateMap.nonEmpty =>
Review Comment:
Can we add this check in `CheckAnalysis`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jchen5 commented on pull request #43061: [SQL] Throw an error for correlated exists/IN subqueries with LIMIT clauses
Posted by "jchen5 (via GitHub)" <gi...@apache.org>.
jchen5 commented on PR #43061:
URL: https://github.com/apache/spark/pull/43061#issuecomment-1741327334
Great, sounds good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jchen5 commented on a diff in pull request #43061: [SQL] Throw an error for correlated exists/IN subqueries with LIMIT clauses
Posted by "jchen5 (via GitHub)" <gi...@apache.org>.
jchen5 commented on code in PR #43061:
URL: https://github.com/apache/spark/pull/43061#discussion_r1340540794
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala:
##########
@@ -283,6 +284,14 @@ object PullupCorrelatedPredicates extends Rule[LogicalPlan] with PredicateHelper
} else {
a
}
+ case l @ Limit(_, _) if predicateMap.nonEmpty =>
Review Comment:
IIRC in CheckAnalysis we don't easily know whether it's inside IN/EXISTS (unsupported) or scalar/lateral (supported).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] agubichev closed pull request #43061: [SQL] Throw an error for correlated exists/IN subqueries with LIMIT clauses
Posted by "agubichev (via GitHub)" <gi...@apache.org>.
agubichev closed pull request #43061: [SQL] Throw an error for correlated exists/IN subqueries with LIMIT clauses
URL: https://github.com/apache/spark/pull/43061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] agubichev commented on pull request #43061: [SQL] Throw an error for correlated exists/IN subqueries with LIMIT clauses
Posted by "agubichev (via GitHub)" <gi...@apache.org>.
agubichev commented on PR #43061:
URL: https://github.com/apache/spark/pull/43061#issuecomment-1734022175
> * Uncorrelated IN/EXISTS subqueries with LIMIT
Yes, these are all covered by tests. The first class of queries are (correlated scalar/lateral with limit) are tested in https://github.com/apache/spark/pull/42705.
The second class of queries (correlated exists/in with limit) are tested in this PR.
The third class of queries (uncorrelated exists/in with limit) are tested at HEAD, the tests in this PR are largely based on those tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jchen5 commented on pull request #43061: [SQL] Throw an error for correlated exists/IN subqueries with LIMIT clauses
Posted by "jchen5 (via GitHub)" <gi...@apache.org>.
jchen5 commented on PR #43061:
URL: https://github.com/apache/spark/pull/43061#issuecomment-1733888223
Note that after these two PRs, the state is as follows:
- Newly enabled: Correlated scalar/lateral subqueries with LIMIT, which required new logic in DecorrelateInnerQuery
- Newly enabled: Uncorrelated IN/EXISTS subqueries with LIMIT, which did not require any new logic other than allowing them through CheckAnalysis.
- Still disabled: Correlated IN/EXISTS subqueries with LIMIT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jchen5 commented on pull request #43061: [SQL] Throw an error for correlated exists/IN subqueries with LIMIT clauses
Posted by "jchen5 (via GitHub)" <gi...@apache.org>.
jchen5 commented on PR #43061:
URL: https://github.com/apache/spark/pull/43061#issuecomment-1741319794
Hmm, it's true they will be handled but might still be good to have this check in case a user disables the flag for new support?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #43061: [SQL] Throw an error for correlated exists/IN subqueries with LIMIT clauses
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #43061:
URL: https://github.com/apache/spark/pull/43061#issuecomment-1736947981
Can we create a JIRA ticket for it and make all tests pass? Then it's ready to go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org