You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/02 11:20:21 UTC

[GitHub] [airflow] eladkal commented on issue #10426: Multiple prefixes in GoogleCloudStorageListOperator and GoogleCloudStorageDeleteOperator

eladkal commented on issue #10426:
URL: https://github.com/apache/airflow/issues/10426#issuecomment-830793326


   > What I'm planning to do is to modify the `GCSHook.list()` method to accept `prefixes` instead of `prefix`. I need to know how we can do that with backward compatibility? Some old code will assume this hook is accepting one prefix and we need to raise a deprecation warning. Or maybe it is only used internally and I need to refactor the operators who use it?
   
   `prefix` is a parameter of `list_blobs` https://googleapis.dev/python/storage/latest/client.html
   even if you modify the parameter on the hook at the end you will still be able to utalize only single prefix each time.
   You can modify prefix to accept `Optional[str,List[str]]` that way the modification is also backward compatible. This has some similarities to approach suggested on https://github.com/apache/airflow/issues/15001


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org