You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by rajivpjs <gi...@git.apache.org> on 2016/07/20 20:07:39 UTC
[GitHub] maven pull request #89: [MNG-5995] Removed maven-compat as it not required a...
GitHub user rajivpjs opened a pull request:
https://github.com/apache/maven/pull/89
[MNG-5995] Removed maven-compat as it not required anymore for maven \u2026
Please review and let me know of any changes.
Thanks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rajivpjs/maven MNG-5995
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven/pull/89.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #89
----
commit 998ed3160d00d6c6d1a1a8bf16db55f6dcf36f4c
Author: Rajiv Jain <ra...@gmail.com>
Date: 2016-07-20T20:05:55Z
[MNG-5995] Removed maven-compat as it not required anymore for maven 3.0 versions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven issue #89: [MNG-5995] Removed maven-compat as it not required anymore ...
Posted by rajivpjs <gi...@git.apache.org>.
Github user rajivpjs commented on the issue:
https://github.com/apache/maven/pull/89
That's right. It worked.
To build the project I ran mvn -Drat.skip=true clean package and mvn -Drat.skip=true validate. -Drat.skip=true was required so that I avoid the RATException. Have I missed anything?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven pull request #89: [MNG-5995] Removed maven-compat as it not required a...
Posted by rajivpjs <gi...@git.apache.org>.
Github user rajivpjs closed the pull request at:
https://github.com/apache/maven/pull/89
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven issue #89: [MNG-5995] Removed maven-compat as it not required anymore ...
Posted by khmarbaise <gi...@git.apache.org>.
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/89
I meant that you should try to compile an example project with the created Maven Core version? I don't meant you should build Maven core itself...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven issue #89: [MNG-5995] Removed maven-compat as it not required anymore ...
Posted by rajivpjs <gi...@git.apache.org>.
Github user rajivpjs commented on the issue:
https://github.com/apache/maven/pull/89
You are right. I tried `/Users/rajivpjs/Desktop/Apache/Maven/rajivpjs/maven/mavenfixtarget/bin/mvn -f /path/to/pom.xml clean package -V`
It shows version 3.3.9.
Maybe you are right, this issue might be hard for me to fix right now. So, I will close this pull request soon. By the way if you don't mind me asking did you guess me having 3.3.9 or you saw it in some output in my logs? I can't see where you find out that information. Having look at the output I have posted, I don't see anything with 3.3.9.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven issue #89: [MNG-5995] Removed maven-compat as it not required anymore ...
Posted by rajivpjs <gi...@git.apache.org>.
Github user rajivpjs commented on the issue:
https://github.com/apache/maven/pull/89
Hi Karl
With my recent change, I compiled with an example project and I didn't have any issues. This is what I did as per the Jira task description:
`mvn -DdistributionTargetFolder=/Users/rajivpjs/Desktop/Apache/Maven/rajivpjs/maven/mavenfixtarget clean package`
From the mavenfixtarget directory I ran:
`mvn -f /path/to/pom.xml clean package`
This gave me a BUILD SUCCESS.
I then removed the from the /lib/maven-compat-3.4.0-SNAPSHOT.jar and then ran:
`mvn -f /patj/to/pom.xml validate`
The output was BUILD SUCCESS.
Have I missed anything?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven issue #89: [MNG-5995] Removed maven-compat as it not required anymore ...
Posted by rfscholte <gi...@git.apache.org>.
Github user rfscholte commented on the issue:
https://github.com/apache/maven/pull/89
Looks to me you're still testing with the installed version of Maven( e.g. 3.3.9), not your own fresh build. Instead try `/Users/rajivpjs/Desktop/Apache/Maven/rajivpjs/maven/mavenfixtarget/bin/mvn clean package -V` (the -V must confirm you're testing the right version).
I should warn you that this issue is very hard to fix without in dept knowledge of Maven. There are probably other issues which are easier to fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven issue #89: [MNG-5995] Removed maven-compat as it not required anymore ...
Posted by rajivpjs <gi...@git.apache.org>.
Github user rajivpjs commented on the issue:
https://github.com/apache/maven/pull/89
I realised that on Friday evening, after reading again. That's why I sent an e-mail to the mailing list to work out how to build with maven. I will check whether my changes work, by using your command that you sent. I will update you and make relevant changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven issue #89: [MNG-5995] Removed maven-compat as it not required anymore ...
Posted by khmarbaise <gi...@git.apache.org>.
Github user khmarbaise commented on the issue:
https://github.com/apache/maven/pull/89
Ok If you remove them and compiled Maven you tried to build a simple project with that compiled Maven version?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [GitHub] maven issue #89: [MNG-5995] Removed maven-compat as it not required anymore ...
Posted by Rajiv Jain <ra...@gmail.com>.
Great guess!!!
I will close this pull request soon.
Sent from my iPhone
> On 27 Jul 2016, at 21:46, rfscholte <gi...@git.apache.org> wrote:
>
> Github user rfscholte commented on the issue:
>
> https://github.com/apache/maven/pull/89
>
> Based on the recent messages on the mailing thread I assumed you are an active Maven user who wants to use the most recent version of Maven. My guess was right :)
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven issue #89: [MNG-5995] Removed maven-compat as it not required anymore ...
Posted by rfscholte <gi...@git.apache.org>.
Github user rfscholte commented on the issue:
https://github.com/apache/maven/pull/89
Based on the recent messages on the mailing thread I assumed you are an active Maven user who wants to use the most recent version of Maven. My guess was right :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org