You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/19 01:33:31 UTC

[GitHub] [apisix-dashboard] tokers commented on a change in pull request #1477: feat: support etcd prefix as apisix does

tokers commented on a change in pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#discussion_r578863638



##########
File path: api/internal/conf/conf.go
##########
@@ -225,10 +226,16 @@ func initEtcdConfig(conf Etcd) {
 		endpoints = conf.Endpoints
 	}
 
+	var prefix = "/apisix"

Review comment:
       Use short assignment is better:
   
   ```
   prefix := "/apisix"
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org