[GitHub] xtinec commented on a change in pull request #6745: Omnibar

[GitBox <gi...@apache.org>]

xtinec commented on a change in pull request #6745: Omnibar
URL: https://github.com/apache/incubator-superset/pull/6745#discussion_r252022596
 
 

 ##########
 File path: superset/assets/src/dashboard/components/Dashboard.jsx
 ##########
 @@ -232,7 +271,14 @@ class Dashboard extends React.PureComponent {
   }
 
   render() {
-    return <DashboardBuilder />;
+    return (
+      <div>
+        <Modal show={this.state.showOmni} ref={this.exampleRef}>
 
 Review comment:
   It is a trick to get ride of holder `div`s. 🙂 
   See https://reactjs.org/docs/fragments.html

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org