You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/06/19 11:19:49 UTC
[GitHub] DaanHoogland commented on a change in pull request #2714: send
unsupported answer only when applicable
DaanHoogland commented on a change in pull request #2714: send unsupported answer only when applicable
URL: https://github.com/apache/cloudstack/pull/2714#discussion_r196384288
##########
File path: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -1432,13 +1434,21 @@ public boolean stop() {
return true;
}
+ /**
+ * This finds a command wrapper to handle the command and executes it.
+ * If no wrapper is found an {@see UnsupportedAnswer} is sent back.
+ * Any other exceptions are to be caught and wrapped in an generic {@see Answer}, marked as failed.
+ *
+ * @param cmd the instance of a {@see Command} to execute.
+ * @return the for the {@see Command} appropriate {@see Answer} or {@see UnsupportedAnswer}
+ */
@Override
public Answer executeRequest(final Command cmd) {
Review comment:
that would require throwing everything else. I will add a subset to catch the most obvious cases
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services