You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/19 12:02:57 UTC
[GitHub] [airflow] potiuk opened a new pull request #9404: Final readmes for backports 2020.6.23.rc1
potiuk opened a new pull request #9404:
URL: https://github.com/apache/airflow/pull/9404
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #9404: Final readmes for backports 2020.6.23.rc1
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #9404:
URL: https://github.com/apache/airflow/pull/9404#discussion_r442809498
##########
File path: airflow/providers/google/README.md
##########
@@ -566,6 +567,8 @@ in [Naming conventions for provider packages](https://github.com/apache/airflow/
| Commit | Committed | Subject |
|:-----------------------------------------------------------------------------------------------|:------------|:-------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| [c7e5bce57](https://github.com/apache/airflow/commit/c7e5bce57fe7f51cefce4f8a41ce408ac5675d13) | 2020-06-19 | Prepare backport release candidate for 2020.6.23rc1 (#9370) |
Review comment:
It's not there. This is general setup change so it will not appear here. It's automatically derived from any change in provider's package itself..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #9404: Final readmes for backports 2020.6.23.rc1
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #9404:
URL: https://github.com/apache/airflow/pull/9404#issuecomment-646619041
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9404: Final readmes for backports 2020.6.23.rc1
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9404:
URL: https://github.com/apache/airflow/pull/9404#discussion_r442807536
##########
File path: airflow/providers/google/README.md
##########
@@ -566,6 +567,8 @@ in [Naming conventions for provider packages](https://github.com/apache/airflow/
| Commit | Committed | Subject |
|:-----------------------------------------------------------------------------------------------|:------------|:-------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| [c7e5bce57](https://github.com/apache/airflow/commit/c7e5bce57fe7f51cefce4f8a41ce408ac5675d13) | 2020-06-19 | Prepare backport release candidate for 2020.6.23rc1 (#9370) |
Review comment:
Can you add this hotfix?
https://github.com/apache/airflow/pull/9390
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9404: Final readmes for backports 2020.6.23.rc1
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9404:
URL: https://github.com/apache/airflow/pull/9404#discussion_r442807536
##########
File path: airflow/providers/google/README.md
##########
@@ -566,6 +567,8 @@ in [Naming conventions for provider packages](https://github.com/apache/airflow/
| Commit | Committed | Subject |
|:-----------------------------------------------------------------------------------------------|:------------|:-------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| [c7e5bce57](https://github.com/apache/airflow/commit/c7e5bce57fe7f51cefce4f8a41ce408ac5675d13) | 2020-06-19 | Prepare backport release candidate for 2020.6.23rc1 (#9370) |
Review comment:
Can you add this fix?
https://github.com/apache/airflow/pull/9390
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #9404: Final readmes for backports 2020.6.23.rc1
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #9404:
URL: https://github.com/apache/airflow/pull/9404#issuecomment-646599251
Once we merge this one - I release backports :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #9404: Final readmes for backports 2020.6.23.rc1
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #9404:
URL: https://github.com/apache/airflow/pull/9404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #9404: Final readmes for backports 2020.6.23.rc1
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #9404:
URL: https://github.com/apache/airflow/pull/9404#discussion_r442810898
##########
File path: airflow/providers/google/README.md
##########
@@ -566,6 +567,8 @@ in [Naming conventions for provider packages](https://github.com/apache/airflow/
| Commit | Committed | Subject |
|:-----------------------------------------------------------------------------------------------|:------------|:-------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| [c7e5bce57](https://github.com/apache/airflow/commit/c7e5bce57fe7f51cefce4f8a41ce408ac5675d13) | 2020-06-19 | Prepare backport release candidate for 2020.6.23rc1 (#9370) |
Review comment:
Apache-beam is excluded as prerequisite from providers-google (on your request) so providers-google have no dependency at all for apache-beam (it can be installed separately). The change only affected [apache-beam] extra.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #9404: Final readmes for backports 2020.6.23.rc1
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #9404:
URL: https://github.com/apache/airflow/pull/9404#discussion_r442809498
##########
File path: airflow/providers/google/README.md
##########
@@ -566,6 +567,8 @@ in [Naming conventions for provider packages](https://github.com/apache/airflow/
| Commit | Committed | Subject |
|:-----------------------------------------------------------------------------------------------|:------------|:-------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| [c7e5bce57](https://github.com/apache/airflow/commit/c7e5bce57fe7f51cefce4f8a41ce408ac5675d13) | 2020-06-19 | Prepare backport release candidate for 2020.6.23rc1 (#9370) |
Review comment:
It's not there. This is general setup change so it will not appear here. It's automatically derived from any change in provider's file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #9404: Final readmes for backports 2020.6.23.rc1
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #9404:
URL: https://github.com/apache/airflow/pull/9404#discussion_r442810863
##########
File path: airflow/providers/google/README.md
##########
@@ -566,6 +567,8 @@ in [Naming conventions for provider packages](https://github.com/apache/airflow/
| Commit | Committed | Subject |
|:-----------------------------------------------------------------------------------------------|:------------|:-------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| [c7e5bce57](https://github.com/apache/airflow/commit/c7e5bce57fe7f51cefce4f8a41ce408ac5675d13) | 2020-06-19 | Prepare backport release candidate for 2020.6.23rc1 (#9370) |
Review comment:
I was mainly worried about the table with dependencies, but now I see that Apache Beam is not included there, so LGTM
https://github.com/apache/airflow/blob/9ce36ae5db03782795d0b0990b09b26b29ad6f0a/airflow/providers/google/README.md#pip-requirements
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org