You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "liurenjie1024 (via GitHub)" <gi...@apache.org> on 2023/08/04 07:28:39 UTC

[GitHub] [iceberg-rust] liurenjie1024 commented on pull request #20: feat: Implement Iceberg values

liurenjie1024 commented on PR #20:
URL: https://github.com/apache/iceberg-rust/pull/20#issuecomment-1665138501

   I would suggest two changes to this pr:
   1. Create a `PrimitiveValue` type so that we can be type safe when ser/de from bytes.
   2. Remove the ser/de implementation for composite types, I think we would need to have data types when implementing them, and we can do it later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org