You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/08/04 20:12:15 UTC
[PR] [SPARK-58529][PYTHON][4.0] Relax RESULT_ROWS_MISMATCH assertion for cross-version old-client compatibility [spark]
Yicong-Huang opened a new pull request, #57772:
URL: https://github.com/apache/spark/pull/57772
### What changes were proposed in this pull request?
This backports the test-side change of SPARK-58529 to `branch-4.0`. It relaxes the `test_vectorized_udf_invalid_length` assertion in `test_pandas_udf_scalar.py` from the pandas-specific substring `"Result vector from pandas_udf was not the required length"` to the shared `"The number of output rows.*must match the number of input rows"` template text.
No production code changes -- `branch-4.0` continues to raise the message with its trailing `Result vector from pandas_udf ...` clause.
### Why are the changes needed?
The `pyspark-connect-old-client` job on `master` clones `branch-4.0`'s tests and runs them against a `master` server. After SPARK-58529 removed the pandas-specific tail from the `RESULT_ROWS_MISMATCH` message on `master`, `branch-4.0`'s assertion on that removed substring fails against the new server. The relaxed regex matches both the old (`branch-4.0` server) and new (`master` server) messages, so `branch-4.0`'s own CI and the cross-version old-client job both pass.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
The relaxed regex was verified to match both the old message (with the pandas tail) and the new message (without it). Existing `test_vectorized_udf_invalid_length` continues to run.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58529][PYTHON][4.0] Relax RESULT_ROWS_MISMATCH assertion for cross-version old-client compatibility [spark]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang closed pull request #57772: [SPARK-58529][PYTHON][4.0] Relax RESULT_ROWS_MISMATCH assertion for cross-version old-client compatibility
URL: https://github.com/apache/spark/pull/57772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58529][PYTHON][4.0] Relax RESULT_ROWS_MISMATCH assertion for cross-version old-client compatibility [spark]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang commented on PR #57772:
URL: https://github.com/apache/spark/pull/57772#issuecomment-5186037713
**Merge Summary:**
- merged into branch-4.0 https://github.com/apache/spark/commit/c1caba3d8b83ce2a50c59cf332842cad1bebb3ee
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org