You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/28 20:27:04 UTC
[jira] [Commented] (NIFI-3760) When a Processor calls
ProcessSession.get(FlowFileFilter), it does not properly round-robin
between incoming connections
[ https://issues.apache.org/jira/browse/NIFI-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989421#comment-15989421 ]
ASF GitHub Bot commented on NIFI-3760:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1717
NIFI-3760: Fixed issue that caused session to continually poll from t…
…he same connection when using ProcessSession.get(FlowFileFilter, Set)
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-3760
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1717.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1717
----
commit dd5f3ade58cb4ecc7039c1a2d3a5612ef52b7466
Author: Mark Payne <ma...@hotmail.com>
Date: 2017-04-28T20:15:44Z
NIFI-3760: Fixed issue that caused session to continually poll from the same connection when using ProcessSession.get(FlowFileFilter, Set)
----
> When a Processor calls ProcessSession.get(FlowFileFilter), it does not properly round-robin between incoming connections
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-3760
> URL: https://issues.apache.org/jira/browse/NIFI-3760
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Mark Payne
>
> If ProcessSession.get() or ProcessSession.get(int) is called, it uses the ProcessContext's getNextIncomingConnectionIndex() method to determine which connection to use. However, the ProcessSession.get(FlowFileFilter) method iterates over all connections and doesn't necessarily start at the 'next' connection. So if we have a lot of data in one connection, that connection will starve out the others.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)