You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/09/07 05:34:44 UTC

[GitHub] [druid] FrankChen021 commented on a diff in pull request #13034: prometheus-emitter supports sending metrics to pushgateway regularly …

FrankChen021 commented on code in PR #13034:
URL: https://github.com/apache/druid/pull/13034#discussion_r964398539


##########
extensions-contrib/prometheus-emitter/src/main/java/org/apache/druid/emitter/prometheus/PrometheusEmitterConfig.java:
##########
@@ -53,6 +53,10 @@
   @Nullable
   private final String pushGatewayAddress;
 
+  @JsonProperty
+  @Nullable
+  private final Integer pushRateSec;

Review Comment:
   Better to name it as `flushPeriod` since it's the same property name in other emitter extensions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org