You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2019/12/24 00:49:35 UTC

[GitHub] [incubator-tvm] tqchen opened a new issue #4579: [RFC] Deprecate Extension VTable in Favor of Unified Object System

tqchen opened a new issue #4579: [RFC] Deprecate Extension VTable in Favor of Unified Object System
URL: https://github.com/apache/incubator-tvm/issues/4579
 
 
   Before the unified object protocol, we support passing additional extension objects around by declaring a type as an extension type. 
   
   The old extension mechanism requires the types to register their constructor and deleter to a VTable in order to pass a container around. It does not enjoy the benefit of the self-contained deletion property of the new Object system.
   
   This RFC propose to deprecate the extension VTable in favor of support all container variation passing via the object protocol to simplify the PackedFunc calling convention.
   
   Note that the register_extension funtion in the python side continues to work when the passed argument does not require explicit container copy/deletion, which covers the current usecases of the extension mechanism. 
   
   The proposed change is implemented in https://github.com/apache/incubator-tvm/pull/4578. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen closed issue #4579: [RFC] Deprecate Extension VTable in Favor of Unified Object System

Posted by GitBox <gi...@apache.org>.

tqchen closed issue #4579: [RFC] Deprecate Extension VTable in Favor of Unified Object System
URL: https://github.com/apache/incubator-tvm/issues/4579
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] junrushao1994 commented on issue #4579: [RFC] Deprecate Extension VTable in Favor of Unified Object System

Posted by GitBox <gi...@apache.org>.

junrushao1994 commented on issue #4579: [RFC] Deprecate Extension VTable in Favor of Unified Object System
URL: https://github.com/apache/incubator-tvm/issues/4579#issuecomment-568641741
 
 
   The implication here is that we won't support nnvm objects any more, right? If so, I think it's fine

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen edited a comment on issue #4579: [RFC] Deprecate Extension VTable in Favor of Unified Object System

Posted by GitBox <gi...@apache.org>.

tqchen edited a comment on issue #4579: [RFC] Deprecate Extension VTable in Favor of Unified Object System
URL: https://github.com/apache/incubator-tvm/issues/4579#issuecomment-568654027
 
 
   No, as nnvm compiler has already been deprecated, we won't support nnvm compiler objects. New projects can move the code to the object system to enable support(via wrapping data structure in the object)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] tqchen commented on issue #4579: [RFC] Deprecate Extension VTable in Favor of Unified Object System

Posted by GitBox <gi...@apache.org>.

tqchen commented on issue #4579: [RFC] Deprecate Extension VTable in Favor of Unified Object System
URL: https://github.com/apache/incubator-tvm/issues/4579#issuecomment-568654027
 
 
   No, as nnvm compiler has already been deprecated, we won't support nnvm compiler objects

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services