You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/07/22 13:03:21 UTC
Review Request 12808: Fix for CLOUDSTACK-2536: updating parameters
(cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are
redundant(cluster level)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12808/
-----------------------------------------------------------
Review request for cloudstack, Koushik Das and Nitin Mehta.
Bugs: CLOUDSTACK-2536
Repository: cloudstack-git
Description
-------
CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level)
There are two APIs updateCluster and UpdateConfiguration where we can update these parameters. Ideally this should get updated using updateConfiguration API, so removing from updateCluster API
Diffs
-----
api/src/com/cloud/resource/ResourceService.java 25298cc
api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 92178c9
server/src/com/cloud/resource/ResourceManagerImpl.java d7652f4
server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134
Diff: https://reviews.apache.org/r/12808/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 12808: Fix for CLOUDSTACK-2536: updating parameters
(cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are
redundant(cluster level)
Posted by "Jenkins Cloudstack.org" <hu...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12808/#review23627
-----------------------------------------------------------
Review 12808 PASSED the build test
The url of build cloudstack-master-with-patch #10 is : http://jenkins.cloudstack.org/job/cloudstack-master-with-patch/10/
- Jenkins Cloudstack.org
On July 22, 2013, 11:03 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12808/
> -----------------------------------------------------------
>
> (Updated July 22, 2013, 11:03 a.m.)
>
>
> Review request for cloudstack, Koushik Das and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-2536
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level)
> There are two APIs updateCluster and UpdateConfiguration where we can update these parameters. Ideally this should get updated using updateConfiguration API, so removing from updateCluster API
>
>
> Diffs
> -----
>
> api/src/com/cloud/resource/ResourceService.java 25298cc
> api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 92178c9
> server/src/com/cloud/resource/ResourceManagerImpl.java d7652f4
> server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134
>
> Diff: https://reviews.apache.org/r/12808/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12808: Fix for CLOUDSTACK-2536: updating parameters
(cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are
redundant(cluster level)
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12808/#review23891
-----------------------------------------------------------
Commit 7ee655f5cd51bab1a5d654ce02a8ebb09d47f9a3 in branch refs/heads/4.2 from Edison Su
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7ee655f ]
CLOUDSTACK-2536: fix the regression introduced by 4c81ea69c4e8326cc81a0e2607f6a6d99645ce5f
- ASF Subversion and Git Services
On July 25, 2013, 7:19 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12808/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 7:19 a.m.)
>
>
> Review request for cloudstack, Koushik Das and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-1528 and CLOUDSTACK-2536
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level)
> There are two APIs updateCluster and UpdateConfiguration where we can update these parameters. Ideally this should get updated using updateConfiguration API, so removing from updateCluster API
>
>
> Diffs
> -----
>
> api/src/com/cloud/resource/ResourceService.java 25298cc
> api/src/org/apache/cloudstack/api/ApiConstants.java 0550a39
> api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c6ca9bc6
> api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 9bc8efd
> server/src/com/cloud/resource/ResourceManagerImpl.java 342b9fd
> server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134
>
> Diff: https://reviews.apache.org/r/12808/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12808: Fix for CLOUDSTACK-2536: updating parameters
(cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are
redundant(cluster level)
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12808/#review23824
-----------------------------------------------------------
Commit 4c81ea69c4e8326cc81a0e2607f6a6d99645ce5f in branch refs/heads/4.2 from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4c81ea6 ]
Fix for CLOUDSTACK-2536
Removing memoryovercommitratio and cpuovercommitratio parameters from addCluster and updateCluster APIs,
since these can be configurable using updateConfiguration API at cluster level.
By default while creating cluster these values are taken from global configuration parameters.
Conflicts:
server/src/com/cloud/resource/ResourceManagerImpl.java
- ASF Subversion and Git Services
On July 25, 2013, 7:19 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12808/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 7:19 a.m.)
>
>
> Review request for cloudstack, Koushik Das and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-1528 and CLOUDSTACK-2536
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level)
> There are two APIs updateCluster and UpdateConfiguration where we can update these parameters. Ideally this should get updated using updateConfiguration API, so removing from updateCluster API
>
>
> Diffs
> -----
>
> api/src/com/cloud/resource/ResourceService.java 25298cc
> api/src/org/apache/cloudstack/api/ApiConstants.java 0550a39
> api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c6ca9bc6
> api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 9bc8efd
> server/src/com/cloud/resource/ResourceManagerImpl.java 342b9fd
> server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134
>
> Diff: https://reviews.apache.org/r/12808/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12808: Fix for CLOUDSTACK-2536: updating parameters
(cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are
redundant(cluster level)
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12808/#review23837
-----------------------------------------------------------
Commit 0010faee4bac8ebb32ceb95ca6ff6b02b4013cba in branch refs/heads/ldapplugin from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0010fae ]
Fix for CLOUDSTACK-2536
Removing memoryovercommitratio and cpuovercommitratio parameters from addCluster and updateCluster APIs,
since these can be configurable using updateConfiguration API at cluster level.
By default while creating cluster these values are taken from global configuration parameters.
- ASF Subversion and Git Services
On July 25, 2013, 7:19 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12808/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 7:19 a.m.)
>
>
> Review request for cloudstack, Koushik Das and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-1528 and CLOUDSTACK-2536
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level)
> There are two APIs updateCluster and UpdateConfiguration where we can update these parameters. Ideally this should get updated using updateConfiguration API, so removing from updateCluster API
>
>
> Diffs
> -----
>
> api/src/com/cloud/resource/ResourceService.java 25298cc
> api/src/org/apache/cloudstack/api/ApiConstants.java 0550a39
> api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c6ca9bc6
> api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 9bc8efd
> server/src/com/cloud/resource/ResourceManagerImpl.java 342b9fd
> server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134
>
> Diff: https://reviews.apache.org/r/12808/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12808: Fix for CLOUDSTACK-2536: updating parameters
(cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are
redundant(cluster level)
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12808/#review23822
-----------------------------------------------------------
Commit 0010faee4bac8ebb32ceb95ca6ff6b02b4013cba in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0010fae ]
Fix for CLOUDSTACK-2536
Removing memoryovercommitratio and cpuovercommitratio parameters from addCluster and updateCluster APIs,
since these can be configurable using updateConfiguration API at cluster level.
By default while creating cluster these values are taken from global configuration parameters.
- ASF Subversion and Git Services
On July 25, 2013, 7:19 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12808/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 7:19 a.m.)
>
>
> Review request for cloudstack, Koushik Das and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-1528 and CLOUDSTACK-2536
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level)
> There are two APIs updateCluster and UpdateConfiguration where we can update these parameters. Ideally this should get updated using updateConfiguration API, so removing from updateCluster API
>
>
> Diffs
> -----
>
> api/src/com/cloud/resource/ResourceService.java 25298cc
> api/src/org/apache/cloudstack/api/ApiConstants.java 0550a39
> api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c6ca9bc6
> api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 9bc8efd
> server/src/com/cloud/resource/ResourceManagerImpl.java 342b9fd
> server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134
>
> Diff: https://reviews.apache.org/r/12808/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12808: Fix for CLOUDSTACK-2536: updating parameters
(cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are
redundant(cluster level)
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12808/#review23878
-----------------------------------------------------------
Commit a39de009da8df5080c2273d77f92a9ae75bff8d6 in branch refs/heads/master from Edison Su
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a39de00 ]
CLOUDSTACK-2536: fix the regression introduced by 4c81ea69c4e8326cc81a0e2607f6a6d99645ce5f
- ASF Subversion and Git Services
On July 25, 2013, 7:19 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12808/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 7:19 a.m.)
>
>
> Review request for cloudstack, Koushik Das and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-1528 and CLOUDSTACK-2536
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level)
> There are two APIs updateCluster and UpdateConfiguration where we can update these parameters. Ideally this should get updated using updateConfiguration API, so removing from updateCluster API
>
>
> Diffs
> -----
>
> api/src/com/cloud/resource/ResourceService.java 25298cc
> api/src/org/apache/cloudstack/api/ApiConstants.java 0550a39
> api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c6ca9bc6
> api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 9bc8efd
> server/src/com/cloud/resource/ResourceManagerImpl.java 342b9fd
> server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134
>
> Diff: https://reviews.apache.org/r/12808/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12808: Fix for CLOUDSTACK-2536: updating parameters
(cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are
redundant(cluster level)
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12808/#review23876
-----------------------------------------------------------
Commit 784bef766c5ece7165cd37dcc2994111846ef586 in branch refs/heads/4.2 from Edison Su
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=784bef7 ]
CLOUDSTACK-2536: fix the regression introduced by 4c81ea69c4e8326cc81a0e2607f6a6d99645ce5f
- ASF Subversion and Git Services
On July 25, 2013, 7:19 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12808/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 7:19 a.m.)
>
>
> Review request for cloudstack, Koushik Das and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-1528 and CLOUDSTACK-2536
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level)
> There are two APIs updateCluster and UpdateConfiguration where we can update these parameters. Ideally this should get updated using updateConfiguration API, so removing from updateCluster API
>
>
> Diffs
> -----
>
> api/src/com/cloud/resource/ResourceService.java 25298cc
> api/src/org/apache/cloudstack/api/ApiConstants.java 0550a39
> api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c6ca9bc6
> api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 9bc8efd
> server/src/com/cloud/resource/ResourceManagerImpl.java 342b9fd
> server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134
>
> Diff: https://reviews.apache.org/r/12808/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12808: Fix for CLOUDSTACK-2536: updating parameters
(cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are
redundant(cluster level)
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12808/#review23892
-----------------------------------------------------------
Commit 5e427bd2f676846c22bc503147cdee13ccb1dcf2 in branch refs/heads/master from Edison Su
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5e427bd ]
CLOUDSTACK-2536: fix the regression introduced by 4c81ea69c4e8326cc81a0e2607f6a6d99645ce5f
- ASF Subversion and Git Services
On July 25, 2013, 7:19 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12808/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 7:19 a.m.)
>
>
> Review request for cloudstack, Koushik Das and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-1528 and CLOUDSTACK-2536
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level)
> There are two APIs updateCluster and UpdateConfiguration where we can update these parameters. Ideally this should get updated using updateConfiguration API, so removing from updateCluster API
>
>
> Diffs
> -----
>
> api/src/com/cloud/resource/ResourceService.java 25298cc
> api/src/org/apache/cloudstack/api/ApiConstants.java 0550a39
> api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c6ca9bc6
> api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 9bc8efd
> server/src/com/cloud/resource/ResourceManagerImpl.java 342b9fd
> server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134
>
> Diff: https://reviews.apache.org/r/12808/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12808: Fix for CLOUDSTACK-2536: updating parameters
(cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are
redundant(cluster level)
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12808/#review23823
-----------------------------------------------------------
Ship it!
Ship It!
- Koushik Das
On July 25, 2013, 7:19 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12808/
> -----------------------------------------------------------
>
> (Updated July 25, 2013, 7:19 a.m.)
>
>
> Review request for cloudstack, Koushik Das and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-1528 and CLOUDSTACK-2536
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level)
> There are two APIs updateCluster and UpdateConfiguration where we can update these parameters. Ideally this should get updated using updateConfiguration API, so removing from updateCluster API
>
>
> Diffs
> -----
>
> api/src/com/cloud/resource/ResourceService.java 25298cc
> api/src/org/apache/cloudstack/api/ApiConstants.java 0550a39
> api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c6ca9bc6
> api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 9bc8efd
> server/src/com/cloud/resource/ResourceManagerImpl.java 342b9fd
> server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134
>
> Diff: https://reviews.apache.org/r/12808/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12808: Fix for CLOUDSTACK-2536: updating parameters
(cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are
redundant(cluster level)
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12808/
-----------------------------------------------------------
(Updated July 25, 2013, 7:19 a.m.)
Review request for cloudstack, Koushik Das and Nitin Mehta.
Bugs: CLOUDSTACK-1528 and CLOUDSTACK-2536
Repository: cloudstack-git
Description
-------
CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level)
There are two APIs updateCluster and UpdateConfiguration where we can update these parameters. Ideally this should get updated using updateConfiguration API, so removing from updateCluster API
Diffs (updated)
-----
api/src/com/cloud/resource/ResourceService.java 25298cc
api/src/org/apache/cloudstack/api/ApiConstants.java 0550a39
api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c6ca9bc6
api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 9bc8efd
server/src/com/cloud/resource/ResourceManagerImpl.java 342b9fd
server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134
Diff: https://reviews.apache.org/r/12808/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 12808: Fix for CLOUDSTACK-2536: updating parameters
(cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are
redundant(cluster level)
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12808/#review23821
-----------------------------------------------------------
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
<https://reviews.apache.org/r/12808/#comment47664>
Provide the exact parameter name instead of the set of value.
server/src/com/cloud/configuration/ConfigurationManagerImpl.java
<https://reviews.apache.org/r/12808/#comment47665>
Use a variable to store the message and use it.
- Koushik Das
On July 23, 2013, 11:41 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12808/
> -----------------------------------------------------------
>
> (Updated July 23, 2013, 11:41 a.m.)
>
>
> Review request for cloudstack, Koushik Das and Nitin Mehta.
>
>
> Bugs: CLOUDSTACK-1528 and CLOUDSTACK-2536
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level)
> There are two APIs updateCluster and UpdateConfiguration where we can update these parameters. Ideally this should get updated using updateConfiguration API, so removing from updateCluster API
>
>
> Diffs
> -----
>
> api/src/com/cloud/resource/ResourceService.java 25298cc
> api/src/org/apache/cloudstack/api/ApiConstants.java 0550a39
> api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c6ca9bc6
> api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 92178c9
> server/src/com/cloud/resource/ResourceManagerImpl.java d7652f4
> server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134
>
> Diff: https://reviews.apache.org/r/12808/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12808: Fix for CLOUDSTACK-2536: updating parameters
(cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are
redundant(cluster level)
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12808/
-----------------------------------------------------------
(Updated July 23, 2013, 11:41 a.m.)
Review request for cloudstack, Koushik Das and Nitin Mehta.
Changes
-------
Removing parameters from both AddCluster and UpdateCluster APIs.
While creating new cluster by default (cpu/memory).overprosioning.factor values are taken from global configuration parameters
Bugs: CLOUDSTACK-1528 and CLOUDSTACK-2536
Repository: cloudstack-git
Description
-------
CLOUDSTACK-2536: updating parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level)
There are two APIs updateCluster and UpdateConfiguration where we can update these parameters. Ideally this should get updated using updateConfiguration API, so removing from updateCluster API
Diffs (updated)
-----
api/src/com/cloud/resource/ResourceService.java 25298cc
api/src/org/apache/cloudstack/api/ApiConstants.java 0550a39
api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c6ca9bc6
api/src/org/apache/cloudstack/api/command/admin/cluster/UpdateClusterCmd.java a14f905
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 92178c9
server/src/com/cloud/resource/ResourceManagerImpl.java d7652f4
server/test/com/cloud/resource/MockResourceManagerImpl.java 2c66134
Diff: https://reviews.apache.org/r/12808/diff/
Testing
-------
Thanks,
Harikrishna Patnala