You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/10/02 16:25:07 UTC
[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11564
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests
......................................................................
IMPALA-7648 part 1: add expected out-of-memory tests
This adds test coverage for some cases where queries are currently
expected to fail with out-of-memory.
Testing:
* ran exhaustive tests
* looped modified tests locally overnight
Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
---
A testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test
M testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test
M tests/query_test/test_mem_usage_scaling.py
3 files changed, 104 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/11564/1
--
To view, visit http://gerrit.cloudera.org:8080/11564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
Gerrit-Change-Number: 11564
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 )
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
Gerrit-Change-Number: 11564
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Oct 2018 21:53:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 )
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/921/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
Gerrit-Change-Number: 11564
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Oct 2018 23:17:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 )
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
Gerrit-Change-Number: 11564
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Oct 2018 21:34:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 )
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test
File testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test:
http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test@29
PS2, Line 29: order by l1. l_orderkey desc
I need to add some more columns to the order by, it's not deterministic currently.
--
To view, visit http://gerrit.cloudera.org:8080/11564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
Gerrit-Change-Number: 11564
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Oct 2018 20:37:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11564
to look at the new patch set (#3).
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests
......................................................................
IMPALA-7648 part 1: add expected out-of-memory tests
This adds test coverage for some cases where queries are currently
expected to fail with out-of-memory:
* memory limit exceeded in exchange node
* aggregation with large var-len intermediate values
* top N with large limit
* hash join with many duplicates on right side
* analytic with a large window that needs to be buffered in-memory
Note that it's not always totally deterministic where the query hits
'memory limit exceeded' so we don't include the node ID or name in the
expected error message.
Testing:
* ran exhaustive tests
* looped modified tests locally overnight
Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
---
A testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test
M testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test
M tests/query_test/test_mem_usage_scaling.py
3 files changed, 104 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/11564/3
--
To view, visit http://gerrit.cloudera.org:8080/11564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
Gerrit-Change-Number: 11564
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 )
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11564/1/tests/query_test/test_mem_usage_scaling.py
File tests/query_test/test_mem_usage_scaling.py:
http://gerrit.cloudera.org:8080/#/c/11564/1/tests/query_test/test_mem_usage_scaling.py@369
PS1, Line 369: @SkipIfNotHdfsMinicluster.tuned_for_minicluster
> flake8: E302 expected 2 blank lines, found 1
Done
--
To view, visit http://gerrit.cloudera.org:8080/11564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
Gerrit-Change-Number: 11564
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Oct 2018 16:47:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 )
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/899/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
Gerrit-Change-Number: 11564
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Oct 2018 16:59:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 )
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests
......................................................................
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/11564/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11564/2//COMMIT_MSG@10
PS2, Line 10: expected to fail with out-of-memory:
> maybe briefly list which cases/nodes from the JIRA this commit covers.
Done
http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test
File testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test:
http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test@17
PS2, Line 17: Memory limit exceeded
> can add a more descriptive error string:
Unfortunately I don't think there's a way to write a totally deterministic test - there's a chance we'd hit memory limit exceeded from a different operator like the scan.
http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test@29
PS2, Line 29: order by l1.l_orderkey desc, l1.l_partkey, l1.l_suppkey, l1.l_linenumber
> I need to add some more columns to the order by, it's not deterministic cur
Done
http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test
File testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test:
http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test@77
PS2, Line 77: Memory limit exceeded
> you can add a more descriptive error like in the hash join one below.
Same concern as before - it's unlikely to be totally deterministic. The aggregation is the big memory consumer but it could still hit the memory limit somewhere else.
--
To view, visit http://gerrit.cloudera.org:8080/11564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
Gerrit-Change-Number: 11564
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Oct 2018 01:27:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 )
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/900/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
Gerrit-Change-Number: 11564
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Oct 2018 17:27:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 )
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests
......................................................................
Patch Set 3:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/914/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/11564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
Gerrit-Change-Number: 11564
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Oct 2018 11:26:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11564 )
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests
......................................................................
IMPALA-7648 part 1: add expected out-of-memory tests
This adds test coverage for some cases where queries are currently
expected to fail with out-of-memory:
* memory limit exceeded in exchange node
* aggregation with large var-len intermediate values
* top N with large limit
* hash join with many duplicates on right side
* analytic with a large window that needs to be buffered in-memory
Note that it's not always totally deterministic where the query hits
'memory limit exceeded' so we don't include the node ID or name in the
expected error message.
Testing:
* ran exhaustive tests
* looped modified tests locally overnight
Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
Reviewed-on: http://gerrit.cloudera.org:8080/11564
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
A testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test
M testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test
M tests/query_test/test_mem_usage_scaling.py
3 files changed, 104 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
Gerrit-Change-Number: 11564
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11564
to look at the new patch set (#2).
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests
......................................................................
IMPALA-7648 part 1: add expected out-of-memory tests
This adds test coverage for some cases where queries are currently
expected to fail with out-of-memory.
Testing:
* ran exhaustive tests
* looped modified tests locally overnight
Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
---
A testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test
M testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test
M tests/query_test/test_mem_usage_scaling.py
3 files changed, 106 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/64/11564/2
--
To view, visit http://gerrit.cloudera.org:8080/11564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
Gerrit-Change-Number: 11564
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 )
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11564/1/tests/query_test/test_mem_usage_scaling.py
File tests/query_test/test_mem_usage_scaling.py:
http://gerrit.cloudera.org:8080/#/c/11564/1/tests/query_test/test_mem_usage_scaling.py@369
PS1, Line 369: @SkipIfNotHdfsMinicluster.tuned_for_minicluster
flake8: E302 expected 2 blank lines, found 1
--
To view, visit http://gerrit.cloudera.org:8080/11564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
Gerrit-Change-Number: 11564
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Oct 2018 16:25:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 )
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3270/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
Gerrit-Change-Number: 11564
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Oct 2018 21:54:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 )
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests
......................................................................
Patch Set 2: Code-Review+1
(4 comments)
http://gerrit.cloudera.org:8080/#/c/11564/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/11564/2//COMMIT_MSG@10
PS2, Line 10: expected to fail with out-of-memory.
maybe briefly list which cases/nodes from the JIRA this commit covers.
http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test
File testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test:
http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/exchange-mem-scaling.test@17
PS2, Line 17: Memory limit exceeded
can add a more descriptive error string:
"EXCHANGE_NODE (id=4) could not allocate 8.00 KB without exceeding limit."
http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test
File testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test:
http://gerrit.cloudera.org:8080/#/c/11564/2/testdata/workloads/functional-query/queries/QueryTest/spilling-no-debug-action.test@77
PS2, Line 77: Memory limit exceeded
you can add a more descriptive error like in the hash join one below.
"Memory limit exceeded: Cannot perform aggregation at aggregator with id 1."
http://gerrit.cloudera.org:8080/#/c/11564/2/tests/query_test/test_mem_usage_scaling.py
File tests/query_test/test_mem_usage_scaling.py:
http://gerrit.cloudera.org:8080/#/c/11564/2/tests/query_test/test_mem_usage_scaling.py@385
PS2, Line 385: """Test that HDFS scans can stay within a low memory limit. Before IMPALA-7096 they
: were not aware of non-reserved memory consumption and could start up too many scanner
: threads."""
nit: copy-paste error
--
To view, visit http://gerrit.cloudera.org:8080/11564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
Gerrit-Change-Number: 11564
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Oct 2018 00:22:38 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7648 part 1: add expected out-of-memory tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11564 )
Change subject: IMPALA-7648 part 1: add expected out-of-memory tests
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11564
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icd1a7eb97837b742a967c260cafb5a7f4f45412e
Gerrit-Change-Number: 11564
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 05 Oct 2018 01:36:16 +0000
Gerrit-HasComments: No