You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "danny0405 (via GitHub)" <gi...@apache.org> on 2026/03/19 09:05:05 UTC
[PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
danny0405 opened a new pull request, #18350:
URL: https://github.com/apache/hudi/pull/18350
…ime management to Transactionmanager
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the changes
(or) link to an issue by including `Closes #<issue-number>` for context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in behavior.
Followed by a detailed log of all the changes. Highlight if any code was copied. -->
### Impact
<!-- Describe any public API or user-facing feature change or any performance impact. -->
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain the risk.
If medium or high, explain what verification was done to mitigate the risks. -->
### Documentation Update
<!-- Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website. Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website) to make changes to the website. -->
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Enough context is provided in the sections above
- [ ] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089749364
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `74.30939%` with `93 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 51.32%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 42.85% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [27 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 51.32% -17.10%
+ Complexity 27408 20852 -6556
=============================================
Files 2423 2422 -1
Lines 132458 132408 -50
Branches 15972 15966 -6
=============================================
- Hits 90623 67956 -22667
- Misses 34784 58424 +23640
+ Partials 7051 6028 -1023
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.53% <10.54%> (-26.78%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.98% <60.73%> (-6.84%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <45.09%> (-12.20%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.92%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `81.90% <100.00%> (-13.60%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `65.97% <100.00%> (-12.70%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `74.17% <100.00%> (-5.64%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.00% <100.00%> (-14.29%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `45.45% <ø> (-30.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `85.57% <100.00%> (-3.79%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `67.13% <100.00%> (-18.79%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [882 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089789437
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `79.83425%` with `73 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.84%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [22 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 14 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-scala-tests|10|6|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 55.84% -12.58%
+ Complexity 27408 22650 -4758
=============================================
Files 2423 2422 -1
Lines 132458 132408 -50
Branches 15972 15966 -6
=============================================
- Hits 90623 73942 -16681
- Misses 34784 52036 +17252
+ Partials 7051 6430 -621
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.53% <10.54%> (-26.78%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.98% <60.73%> (-6.84%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.61% <70.24%> (-0.40%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.92%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `83.80% <100.00%> (-11.69%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `71.61% <100.00%> (-7.06%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `74.17% <100.00%> (-5.64%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.59% <100.00%> (-13.70%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `59.09% <ø> (-16.59%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `86.24% <100.00%> (-3.12%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `69.93% <100.00%> (-15.99%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [715 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094620360
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `81.81818%` with `68 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.43%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [20 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (1ad2a5d). Click for more details.
>
> <details><summary>HEAD has 15 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (1ad2a5d) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 61.43% -6.99%
+ Complexity 27408 24618 -2790
============================================
Files 2423 2422 -1
Lines 132458 132434 -24
Branches 15972 15971 -1
============================================
- Hits 90623 81362 -9261
- Misses 34784 44226 +9442
+ Partials 7051 6846 -205
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <56.68%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <61.24%> (-16.14%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.81% <44.67%> (-12.20%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.65% <52.52%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `94.28% <100.00%> (-1.21%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.68% <100.00%> (-5.00%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `62.44% <100.00%> (-17.38%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.44% <100.00%> (-5.92%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [493 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090668767
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.44379%` with `83 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.21%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 80.85% | [4 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [19 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (998e5a5). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (998e5a5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|utilities|1|0|
>|spark-java-tests|15|1|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 48.21% -20.21%
+ Complexity 27408 16241 -11167
=============================================
Files 2423 1987 -436
Lines 132458 109960 -22498
Branches 15972 13863 -2109
=============================================
- Hits 90623 53014 -37609
- Misses 34784 51406 +16622
+ Partials 7051 5540 -1511
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.87% <61.24%> (-14.94%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <44.67%> (-12.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `92.38% <100.00%> (-3.12%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `28.63% <100.00%> (-51.18%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `56.36% <ø> (-19.32%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `61.90% <100.00%> (-10.89%)` | :arrow_down: |
| ... and [62 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1452 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094607072
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.44379%` with `83 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.16%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 80.85% | [4 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [20 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (1ad2a5d). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (1ad2a5d) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|utilities|1|0|
>|spark-java-tests|15|3|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 48.16% -20.25%
+ Complexity 27408 16189 -11219
=============================================
Files 2423 1987 -436
Lines 132458 109974 -22484
Branches 15972 13867 -2105
=============================================
- Hits 90623 52973 -37650
- Misses 34784 51533 +16749
+ Partials 7051 5468 -1583
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.12% <61.24%> (-15.70%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.08% <44.67%> (-11.92%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `92.38% <100.00%> (-3.12%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `28.63% <100.00%> (-51.18%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `56.36% <ø> (-19.32%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `61.90% <100.00%> (-10.89%)` | :arrow_down: |
| ... and [62 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1451 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089006192
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `77.38420%` with `83 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 52.13%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [24 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 14 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-scala-tests|10|7|
>|utilities|1|0|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 52.13% -16.29%
+ Complexity 27408 21397 -6011
=============================================
Files 2423 2422 -1
Lines 132458 132414 -44
Branches 15972 15966 -6
=============================================
- Hits 90623 69028 -21595
- Misses 34784 57252 +22468
+ Partials 7051 6134 -917
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <61.63%> (-16.14%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <71.29%> (-0.32%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.74% <100.00%> (-5.94%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `59.62% <100.00%> (-20.19%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <100.00%> (ø)` | |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [849 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4204655732
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7c0b4ccbb31148a172c028203680982b9511b9e6 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049216178
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/ZeroToOneUpgradeHandler.java:
##########
@@ -64,6 +66,7 @@ public UpgradeDowngrade.TableConfigChangeSet upgrade(
// for every pending commit, delete old markers and re-create markers in new format
recreateMarkers(commit, table, context, config.getMarkersDeleteParallelism());
}
+ table.getTxnManager().ifPresent(obj -> ((TransactionManager) obj).close());
Review Comment:
can not do that since there is compile errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "vinothchandar (via GitHub)" <gi...@apache.org>.
vinothchandar commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3041295438
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
+ return HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L);
+ }
+
+ /**
+ * Generates an instant time and executes an action that requires that instant time within a lock.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(Option.empty(), Option.empty(), instantTimeConsumingAction);
Review Comment:
please write unit tests for this. This is the core new API used by 13+ callers. `TestTransactionManager` has no tests for it.
Suggest adding at minimum:
1. Lock acquired and released around the action
2. Instant time generated when `providedInstantTime` is empty vs used when present
3. Lock released when the action throws an exception
4. Nested/reentrant `executeStateChangeWithInstant` calls
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
Review Comment:
this should be a boolean? `boolean allowRetrancy` ? Idk wht nested transaction means in this context. lets name this in standard terms?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
+ return HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L);
+ }
+
+ /**
+ * Generates an instant time and executes an action that requires that instant time within a lock.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(Option.empty(), Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(providedInstantTime, Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param lastCompletedActionInstant optional input representing the last completed instant, used for logging purposes.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Option<HoodieInstant> lastCompletedActionInstant, Function<String, T> instantTimeConsumingAction) {
+ if (isLockRequired()) {
+ acquireLock();
+ }
+ String requestedInstant = providedInstantTime.orElseGet(() -> HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L));
+ try {
+ if (lastCompletedActionInstant.isEmpty()) {
+ LOG.info("State change starting for {}", changeActionInstant);
+ } else {
+ LOG.info("State change starting for {} with latest completed action instant {}", changeActionInstant, lastCompletedActionInstant.get());
+ }
+ return instantTimeConsumingAction.apply(requestedInstant);
+ } finally {
+ if (isLockRequired()) {
+ releaseLock();
+ LOG.info("State change ended for {}", requestedInstant);
+ }
+ }
+ }
+
+ public void beginStateChange() {
+ beginStateChange(Option.empty(), Option.empty());
}
public void beginStateChange(Option<HoodieInstant> changeActionInstant,
Option<HoodieInstant> lastCompletedActionInstant) {
if (isLockRequired) {
LOG.info("State change starting for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
- lockManager.lock();
+ acquireLock();
reset(this.changeActionInstant, changeActionInstant, lastCompletedActionInstant);
LOG.info("State change started for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
}
}
+ public void endStateChange() {
+ endStateChange(Option.empty());
+ }
+
public void endStateChange(Option<HoodieInstant> changeActionInstant) {
if (isLockRequired) {
LOG.info("State change ending for action instant {}", changeActionInstant);
if (reset(changeActionInstant, Option.empty(), Option.empty())) {
- lockManager.unlock();
+ releaseLock();
LOG.info("State change ended for action instant {}", changeActionInstant);
}
}
}
+ /**
+ * Caution: the {@code hasLock} flag can not be used to skip the `#lock` eagerly if the thread switches,
+ * the corner case below can cause deadlock:
+ *
+ * <pre>
+ * threadA => acquireLock(), {@code hasLock} setup as true and got the lock acquired;
+ * threadB => acquireLock(), check the {@code hasLock} as true, returns early;
+ * threadB => releaseLock(), set up the {@code hasLock} as false;
+ * threadA => releaseLock(), detect the {@code hasLock} as false and returns early.
+ *
+ * The lock held by threadA will never be released.
+ * </pre>
+ */
+ private void acquireLock() {
+ if (lockHolderId > 0 && isLockHeldByCurrentThread()) {
+ LOG.info("{}: Lock already acquired, skipping lock acquisition.", this);
+ permits++;
+ return;
+ }
+ lockManager.lock();
+ permits++;
+ this.lockHolderId = Thread.currentThread().getId();
Review Comment:
do we know the ids won't be reused?
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/FlinkTables.java:
##########
@@ -78,6 +82,11 @@ public static HoodieFlinkTable<?> createTable(
*/
public static HoodieFlinkTable<?> createTable(Configuration conf) {
HoodieWriteConfig writeConfig = FlinkWriteClients.getHoodieClientConfig(conf, true, false);
- return createTableInternal(writeConfig, HoodieFlinkEngineContext.DEFAULT);
+ return createTableInternal(writeConfig, HoodieFlinkEngineContext.DEFAULT, Option.empty());
+ }
+
+ public static HoodieFlinkTable<?> createTable(Configuration conf, TransactionManager txnManager) {
+ HoodieWriteConfig writeConfig = FlinkWriteClients.getHoodieClientConfig(conf, true, false);
Review Comment:
💬 **SUGGESTION: Naming inconsistency across engines**
Spark has `HoodieSparkTable.createForReads()` for the read-only path, while Flink/Java keep `create()` passing `Option.empty()`. Consider aligning so the intent is clear from the method name.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##########
@@ -104,7 +104,7 @@ public TimelineArchiverV1(HoodieWriteConfig config, HoodieTable<T, I, K, O> tabl
this.table = table;
this.metaClient = table.getMetaClient();
this.archiveFilePath = ArchivedTimelineV1.getArchiveLogPath(metaClient.getArchivePath());
- this.txnManager = new TransactionManager(config, table.getMetaClient().getStorage());
+ this.txnManager = table.getTxnManager().get();
Review Comment:
do we expect this to be absent? My assumption is - this should always be set?
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/FlinkTables.java:
##########
@@ -53,7 +56,8 @@ public static HoodieFlinkTable<?> createTable(Configuration conf, RuntimeContext
HadoopFSUtils.getStorageConf(getHadoopConf(conf)),
new FlinkTaskContextSupplier(runtimeContext));
HoodieWriteConfig writeConfig = FlinkWriteClients.getHoodieClientConfig(conf, true);
Review Comment:
💬 **SUGGESTION: Track FIXME as follow-up**
`FIXME-vc: we need a txn manager here. for flink clustering/compaction.` — Currently safe because callers that need a `TransactionManager` get it from the `writeClient`, not the table. But any future code calling `table.getTxnManager().get()` on a table created through this path will crash. Worth tracking.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
+ return HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L);
+ }
+
+ /**
+ * Generates an instant time and executes an action that requires that instant time within a lock.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(Option.empty(), Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(providedInstantTime, Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param lastCompletedActionInstant optional input representing the last completed instant, used for logging purposes.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Option<HoodieInstant> lastCompletedActionInstant, Function<String, T> instantTimeConsumingAction) {
+ if (isLockRequired()) {
+ acquireLock();
+ }
+ String requestedInstant = providedInstantTime.orElseGet(() -> HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L));
+ try {
+ if (lastCompletedActionInstant.isEmpty()) {
+ LOG.info("State change starting for {}", changeActionInstant);
+ } else {
+ LOG.info("State change starting for {} with latest completed action instant {}", changeActionInstant, lastCompletedActionInstant.get());
+ }
+ return instantTimeConsumingAction.apply(requestedInstant);
+ } finally {
+ if (isLockRequired()) {
+ releaseLock();
+ LOG.info("State change ended for {}", requestedInstant);
+ }
+ }
+ }
+
+ public void beginStateChange() {
+ beginStateChange(Option.empty(), Option.empty());
}
public void beginStateChange(Option<HoodieInstant> changeActionInstant,
Option<HoodieInstant> lastCompletedActionInstant) {
if (isLockRequired) {
LOG.info("State change starting for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
- lockManager.lock();
+ acquireLock();
reset(this.changeActionInstant, changeActionInstant, lastCompletedActionInstant);
LOG.info("State change started for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
}
}
+ public void endStateChange() {
+ endStateChange(Option.empty());
+ }
+
public void endStateChange(Option<HoodieInstant> changeActionInstant) {
if (isLockRequired) {
LOG.info("State change ending for action instant {}", changeActionInstant);
if (reset(changeActionInstant, Option.empty(), Option.empty())) {
- lockManager.unlock();
+ releaseLock();
LOG.info("State change ended for action instant {}", changeActionInstant);
}
}
}
+ /**
+ * Caution: the {@code hasLock} flag can not be used to skip the `#lock` eagerly if the thread switches,
+ * the corner case below can cause deadlock:
+ *
+ * <pre>
+ * threadA => acquireLock(), {@code hasLock} setup as true and got the lock acquired;
+ * threadB => acquireLock(), check the {@code hasLock} as true, returns early;
+ * threadB => releaseLock(), set up the {@code hasLock} as false;
+ * threadA => releaseLock(), detect the {@code hasLock} as false and returns early.
+ *
+ * The lock held by threadA will never be released.
+ * </pre>
+ */
+ private void acquireLock() {
+ if (lockHolderId > 0 && isLockHeldByCurrentThread()) {
+ LOG.info("{}: Lock already acquired, skipping lock acquisition.", this);
+ permits++;
+ return;
+ }
+ lockManager.lock();
+ permits++;
+ this.lockHolderId = Thread.currentThread().getId();
+ LOG.info("{}: Lock acquired for action instant {}", this, changeActionInstant);
Review Comment:
@yihua these seem very raw AI generated? lets please contextualize these for the PR itself.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
Review Comment:
pull -1 into constant
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ActiveTimelineV1.java:
##########
@@ -374,7 +364,8 @@ public HoodieInstant transitionLogCompactionRequestedToInflight(HoodieInstant re
}
Review Comment:
💬 **SUGGESTION: Remove FIXME comment before merge**
`// FIXME-vc: check all these API changes..` — should be resolved or removed before merging.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -62,7 +63,7 @@ public class CleanActionExecutor<T, I, K, O> extends BaseActionExecutor<T, I, K,
Review Comment:
⚠️ **IMPORTANT: Unchecked `.get()` on `Option<TransactionManager>`**
`table.getTxnManager().get()` will throw `NoSuchElementException` if a table was created via the read path (`Option.empty()` for txnManager). Same pattern in `RunIndexActionExecutor`, `BaseRollbackActionExecutor`, `BaseRestoreActionExecutor`, `CopyOnWriteRestoreActionExecutor`, `MergeOnReadRestoreActionExecutor`, and `CompactionUtil.rollbackEarliestCompaction`.
The old code was self-contained (`new TransactionManager(config, table.getStorage())`) and always safe.
This pattern is diff places. Consider a `getOrThrow()` with a clear error message, or validation at table creation time. We need to ensure consistent behavior -- either we need assume it ll be set at table creation time and throw error there or any get() needs to explicitly throw using `getOrThrow()` instead of an opaque error
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/DirectMarkerTransactionManager.java:
##########
@@ -42,7 +42,7 @@ public class DirectMarkerTransactionManager extends TransactionManager {
private final String filePath;
public DirectMarkerTransactionManager(HoodieWriteConfig config, HoodieStorage storage, String partitionPath, String fileId) {
- super(new LockManager(config, storage, createUpdatedLockProps(config, partitionPath, fileId)), config.isLockRequired());
Review Comment:
lock is always required now, right? its either in-process or external distributed lock
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##########
@@ -104,7 +104,7 @@ public TimelineArchiverV1(HoodieWriteConfig config, HoodieTable<T, I, K, O> tabl
this.table = table;
this.metaClient = table.getMetaClient();
this.archiveFilePath = ArchivedTimelineV1.getArchiveLogPath(metaClient.getArchivePath());
- this.txnManager = new TransactionManager(config, table.getMetaClient().getStorage());
+ this.txnManager = table.getTxnManager().get();
Review Comment:
if so, those are bugs, and should fail and not be masked? @danny0405 please comment
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
+ return HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L);
+ }
+
+ /**
+ * Generates an instant time and executes an action that requires that instant time within a lock.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(Option.empty(), Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(providedInstantTime, Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param lastCompletedActionInstant optional input representing the last completed instant, used for logging purposes.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Option<HoodieInstant> lastCompletedActionInstant, Function<String, T> instantTimeConsumingAction) {
+ if (isLockRequired()) {
+ acquireLock();
+ }
+ String requestedInstant = providedInstantTime.orElseGet(() -> HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L));
+ try {
+ if (lastCompletedActionInstant.isEmpty()) {
+ LOG.info("State change starting for {}", changeActionInstant);
+ } else {
+ LOG.info("State change starting for {} with latest completed action instant {}", changeActionInstant, lastCompletedActionInstant.get());
+ }
+ return instantTimeConsumingAction.apply(requestedInstant);
+ } finally {
+ if (isLockRequired()) {
+ releaseLock();
+ LOG.info("State change ended for {}", requestedInstant);
+ }
+ }
+ }
+
+ public void beginStateChange() {
+ beginStateChange(Option.empty(), Option.empty());
}
public void beginStateChange(Option<HoodieInstant> changeActionInstant,
Option<HoodieInstant> lastCompletedActionInstant) {
if (isLockRequired) {
LOG.info("State change starting for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
- lockManager.lock();
+ acquireLock();
reset(this.changeActionInstant, changeActionInstant, lastCompletedActionInstant);
LOG.info("State change started for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
}
}
+ public void endStateChange() {
+ endStateChange(Option.empty());
+ }
+
public void endStateChange(Option<HoodieInstant> changeActionInstant) {
if (isLockRequired) {
LOG.info("State change ending for action instant {}", changeActionInstant);
if (reset(changeActionInstant, Option.empty(), Option.empty())) {
- lockManager.unlock();
+ releaseLock();
LOG.info("State change ended for action instant {}", changeActionInstant);
}
}
}
+ /**
+ * Caution: the {@code hasLock} flag can not be used to skip the `#lock` eagerly if the thread switches,
+ * the corner case below can cause deadlock:
+ *
+ * <pre>
+ * threadA => acquireLock(), {@code hasLock} setup as true and got the lock acquired;
+ * threadB => acquireLock(), check the {@code hasLock} as true, returns early;
+ * threadB => releaseLock(), set up the {@code hasLock} as false;
+ * threadA => releaseLock(), detect the {@code hasLock} as false and returns early.
+ *
+ * The lock held by threadA will never be released.
+ * </pre>
+ */
+ private void acquireLock() {
+ if (lockHolderId > 0 && isLockHeldByCurrentThread()) {
+ LOG.info("{}: Lock already acquired, skipping lock acquisition.", this);
+ permits++;
+ return;
+ }
+ lockManager.lock();
+ permits++;
Review Comment:
What makes the `permits++` immune to races? - `beginStateChange()` is not synchronized
are you trying to hand implement sth like a semaphore? This reentrancy part is where I got blocked last time as well. You are attaching a lock
Can we think through this from both angles..
1) There could be table services running in same jvm
2) there could be writers in another jvm or process.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/FourToFiveUpgradeHandler.java:
##########
@@ -65,6 +66,7 @@ public UpgradeDowngrade.TableConfigChangeSet upgrade(HoodieWriteConfig config,
throw new HoodieException(String.format("Old deprecated \"%s\" partition found in hudi table. This needs a migration step before we can upgrade ",
DEPRECATED_DEFAULT_PARTITION_PATH));
}
+ table.getTxnManager().ifPresent(obj -> ((TransactionManager) obj).close());
Review Comment:
Close the txnManager in a finally block?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
+ return HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L);
+ }
+
+ /**
+ * Generates an instant time and executes an action that requires that instant time within a lock.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(Option.empty(), Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(providedInstantTime, Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param lastCompletedActionInstant optional input representing the last completed instant, used for logging purposes.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Option<HoodieInstant> lastCompletedActionInstant, Function<String, T> instantTimeConsumingAction) {
+ if (isLockRequired()) {
+ acquireLock();
+ }
+ String requestedInstant = providedInstantTime.orElseGet(() -> HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L));
Review Comment:
🚨 **BLOCKING: Lock leak if instant time generation throws**
What happens If `acquireLock()` succeeds at L112 but the `orElseGet` at L114 throws (e.g., `SkewAdjustingTimeGenerator.generateTime()` wraps an `InterruptedException` as `HoodieException` during `Thread.sleep`), the lock is never released?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
+ return HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L);
+ }
+
+ /**
+ * Generates an instant time and executes an action that requires that instant time within a lock.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(Option.empty(), Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(providedInstantTime, Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param lastCompletedActionInstant optional input representing the last completed instant, used for logging purposes.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Option<HoodieInstant> lastCompletedActionInstant, Function<String, T> instantTimeConsumingAction) {
+ if (isLockRequired()) {
+ acquireLock();
+ }
+ String requestedInstant = providedInstantTime.orElseGet(() -> HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L));
+ try {
+ if (lastCompletedActionInstant.isEmpty()) {
+ LOG.info("State change starting for {}", changeActionInstant);
+ } else {
+ LOG.info("State change starting for {} with latest completed action instant {}", changeActionInstant, lastCompletedActionInstant.get());
+ }
+ return instantTimeConsumingAction.apply(requestedInstant);
+ } finally {
+ if (isLockRequired()) {
+ releaseLock();
+ LOG.info("State change ended for {}", requestedInstant);
+ }
+ }
+ }
+
+ public void beginStateChange() {
+ beginStateChange(Option.empty(), Option.empty());
}
public void beginStateChange(Option<HoodieInstant> changeActionInstant,
Option<HoodieInstant> lastCompletedActionInstant) {
if (isLockRequired) {
LOG.info("State change starting for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
- lockManager.lock();
+ acquireLock();
reset(this.changeActionInstant, changeActionInstant, lastCompletedActionInstant);
LOG.info("State change started for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
}
}
+ public void endStateChange() {
+ endStateChange(Option.empty());
+ }
+
public void endStateChange(Option<HoodieInstant> changeActionInstant) {
if (isLockRequired) {
LOG.info("State change ending for action instant {}", changeActionInstant);
if (reset(changeActionInstant, Option.empty(), Option.empty())) {
- lockManager.unlock();
+ releaseLock();
LOG.info("State change ended for action instant {}", changeActionInstant);
}
}
}
+ /**
+ * Caution: the {@code hasLock} flag can not be used to skip the `#lock` eagerly if the thread switches,
+ * the corner case below can cause deadlock:
+ *
+ * <pre>
+ * threadA => acquireLock(), {@code hasLock} setup as true and got the lock acquired;
+ * threadB => acquireLock(), check the {@code hasLock} as true, returns early;
+ * threadB => releaseLock(), set up the {@code hasLock} as false;
+ * threadA => releaseLock(), detect the {@code hasLock} as false and returns early.
+ *
+ * The lock held by threadA will never be released.
+ * </pre>
+ */
+ private void acquireLock() {
+ if (lockHolderId > 0 && isLockHeldByCurrentThread()) {
+ LOG.info("{}: Lock already acquired, skipping lock acquisition.", this);
+ permits++;
+ return;
+ }
+ lockManager.lock();
+ permits++;
+ this.lockHolderId = Thread.currentThread().getId();
+ LOG.info("{}: Lock acquired for action instant {}", this, changeActionInstant);
+ }
+
+ /**
+ * Caution: the `hasLock` flag can not be used to skip the `#unlock` eagerly if the thread switches.
+ * see the corner case of {@link #acquireLock()}.
+ */
+ private void releaseLock() {
+ if (isLockHeldByCurrentThread()) {
+ --permits;
+ if (permits == 0) {
+ lockManager.unlock();
+ this.lockHolderId = -1;
+ LOG.info("{}: Lock released for action instant {}", this, changeActionInstant);
+ }
Review Comment:
+1
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
Review Comment:
🚨 **BLOCKING: Is this check right?
`lockHolderId < 0` checks whether *any* thread holds the lock, not whether the *calling* thread holds it. If thread A holds the lock (`lockHolderId = A's id > 0`) and thread B calls `generateInstantTime()`, the check `lockHolderId < 0` is false, so B is allowed to generate an instant time despite not holding the lock.
**Suggestion:**
```java
if (isLockRequired() && !isLockHeldByCurrentThread()) {
throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
}
```
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackActionExecutor.java:
##########
@@ -266,7 +266,7 @@ protected List<HoodieRollbackStat> executeRollback(HoodieInstant instantToRollba
}
protected void finishRollback(HoodieInstant inflightInstant, HoodieRollbackMetadata rollbackMetadata) throws HoodieIOException {
- boolean enableLocking = (!skipLocking && !skipTimelinePublish);
+ boolean enableLocking = (!skipLocking || !skipTimelinePublish);
Review Comment:
⚠️ **IMPORTANT: What's the behavior change due to this? **
Changed from `(!skipLocking && !skipTimelinePublish)` to `(!skipLocking || !skipTimelinePublish)`. This means locking now happens when *either* flag is false, not only when *both* are false. This is likely a correctness fix (needed because `generateInstantTime()` at L290 requires the lock)
Please clarify how its still safe
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/FlinkTables.java:
##########
@@ -53,7 +56,8 @@ public static HoodieFlinkTable<?> createTable(Configuration conf, RuntimeContext
HadoopFSUtils.getStorageConf(getHadoopConf(conf)),
new FlinkTaskContextSupplier(runtimeContext));
HoodieWriteConfig writeConfig = FlinkWriteClients.getHoodieClientConfig(conf, true);
Review Comment:
Coment on this?
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ActiveTimelineV1.java:
##########
@@ -374,7 +364,8 @@ public HoodieInstant transitionLogCompactionRequestedToInflight(HoodieInstant re
}
Review Comment:
anything I marked `FIXME-vc` were my notes to myself to resolve before landing
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -226,11 +227,11 @@ private HoodieCleanMetadata runClean(HoodieTable<T, I, K, O> table, HoodieInstan
);
this.txnManager.beginStateChange(Option.of(inflightInstant), Option.empty());
writeTableMetadata(metadata, inflightInstant.requestedTime());
- table.getActiveTimeline().transitionCleanInflightToComplete(
- false,
- inflightInstant,
- Option.of(metadata),
- completedInstant -> table.getMetaClient().getTableFormat().clean(metadata, completedInstant, table.getContext(), table.getMetaClient(), table.getViewManager()));
+ TableFormatCompletionAction formatCompletionAction = completedInstant -> table.getMetaClient().getTableFormat()
+ .clean(metadata, completedInstant, table.getContext(), table.getMetaClient(), table.getViewManager());
+ HoodieInstant completedInstant = table.getActiveTimeline().transitionCleanInflightToComplete(inflightInstant, Option.of(metadata), txnManager.generateInstantTime());
+ // FIXME-vc: this is an one off..
+ formatCompletionAction.execute(completedInstant);
log.info("Marked clean started on {} as complete", inflightInstant.requestedTime());
Review Comment:
lets think through this more? and find a better solution. This was supposed to be fixed in the same PR, once I got tests to pass mostly
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1747,22 +1745,25 @@ public void update(HoodieRestoreMetadata restoreMetadata, String instantTime) {
// We cannot create a deltaCommit at instantTime now because a future (rollback) block has already been written to the logFiles.
// We need to choose a timestamp which would be a validInstantTime for MDT. This is either a commit timestamp completed on the dataset
// or a new timestamp which we use for MDT clean, compaction etc.
- String syncCommitTime = createRestoreInstantTime();
- processAndCommit(syncCommitTime, () -> {
- // For Files partition.
- Map<String, HoodieData<HoodieRecord>> partitionRecords = new HashMap<>();
- partitionRecords.putAll(HoodieTableMetadataUtil.convertMissingPartitionRecords(engineContext,
- partitionsToDelete, partitionFilesToAdd, partitionFilesToDelete, syncCommitTime));
- // For ColumnStats partition if enabled.
- if (dataMetaClient.getTableConfig().getMetadataPartitions().contains(COLUMN_STATS.getPartitionPath())) {
- partitionRecords.putAll(convertToColumnStatsRecord(
- partitionFilesToAdd, partitionFilesToDelete, engineContext, dataMetaClient,
- dataWriteConfig.getMetadataConfig(), Option.of(dataWriteConfig.getRecordMerger().getRecordType()),
- dataWriteConfig.getMetadataConfig().getColumnStatsIndexParallelism()));
- }
- return partitionRecords;
+ writeClient.getTransactionManager().executeStateChangeWithInstant(metadataTableCommit -> {
+ String syncCommitTime = createRestoreTimestamp(metadataTableCommit);
+ processAndCommit(syncCommitTime, () -> {
+ // For Files partition.
+ Map<String, HoodieData<HoodieRecord>> partitionRecords = new HashMap<>();
+ partitionRecords.putAll(HoodieTableMetadataUtil.convertMissingPartitionRecords(engineContext,
+ partitionsToDelete, partitionFilesToAdd, partitionFilesToDelete, syncCommitTime));
+ // For ColumnStats partition if enabled.
+ if (dataMetaClient.getTableConfig().getMetadataPartitions().contains(COLUMN_STATS.getPartitionPath())) {
+ partitionRecords.putAll(convertToColumnStatsRecord(
+ partitionFilesToAdd, partitionFilesToDelete, engineContext, dataMetaClient,
+ dataWriteConfig.getMetadataConfig(), Option.of(dataWriteConfig.getRecordMerger().getRecordType()),
+ dataWriteConfig.getMetadataConfig().getColumnStatsIndexParallelism()));
+ }
+ return partitionRecords;
+ });
+ // empty result
+ return Option.empty();
});
- closeInternal();
} catch (IOException e) {
throw new HoodieMetadataException("IOException during MDT restore sync", e);
}
Review Comment:
Does not calling `closeInternal()` not leak anything? Please clarify
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/ZeroToOneUpgradeHandler.java:
##########
@@ -64,6 +66,7 @@ public UpgradeDowngrade.TableConfigChangeSet upgrade(
// for every pending commit, delete old markers and re-create markers in new format
recreateMarkers(commit, table, context, config.getMarkersDeleteParallelism());
}
+ table.getTxnManager().ifPresent(obj -> ((TransactionManager) obj).close());
Review Comment:
💅 **NIT:** `((TransactionManager) obj).close()` — the cast is redundant since `Option<TransactionManager>` is already typed. Could be `TransactionManager::close`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3048984504
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##########
@@ -104,7 +104,7 @@ public TimelineArchiverV1(HoodieWriteConfig config, HoodieTable<T, I, K, O> tabl
this.table = table;
this.metaClient = table.getMetaClient();
this.archiveFilePath = ArchivedTimelineV1.getArchiveLogPath(metaClient.getArchivePath());
- this.txnManager = new TransactionManager(config, table.getMetaClient().getStorage());
+ this.txnManager = table.getTxnManager().get();
Review Comment:
add a validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205398879
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.95767%` with `106 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.42%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [28 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (625a6b4). Click for more details.
>
> <details><summary>HEAD has 2 uploads less than BASE</summary>
>
>| Flag | BASE (0591933) | HEAD (625a6b4) |
>|------|------|------|
>|spark-java-tests|15|13|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.77% 47.42% -21.36%
+ Complexity 28117 19797 -8320
=============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
=============================================
- Hits 92869 64023 -28846
- Misses 34801 65247 +30446
+ Partials 7363 5731 -1632
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.75% <25.39%> (-20.68%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.04% <64.61%> (-10.83%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.12% <44.73%> (-13.38%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-38.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `92.23% <100.00%> (-3.18%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.18% <100.00%> (-6.29%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `76.52% <100.00%> (-3.29%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `73.63% <ø> (-2.04%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1024 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core)!: centralize instant generation in TransactionManager [hudi]
Posted by "vinothchandar (via GitHub)" <gi...@apache.org>.
vinothchandar commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5273062627
Whats the current state here? CI is green I guess.
do we have any pending open items that are looking risky. (e.g deadlocks, reentrancy).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4204626980
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1ad2a5d9837981432070b0e91ed406e81c1e4c90 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733)
* 7c0b4ccbb31148a172c028203680982b9511b9e6 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4204993890
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
}, {
"hash" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"triggerType" : "PUSH"
}, {
"hash" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143",
"triggerID" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7c0b4ccbb31148a172c028203680982b9511b9e6 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142)
* 6edf57b229f151125b65b1a517882e48d0cdf579 UNKNOWN
* 625a6b484d8569b976f8a75cba5b36695ccab7ce Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205413354
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.95767%` with `106 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.53%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [28 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.77% 47.53% -21.25%
+ Complexity 28117 19844 -8273
=============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
=============================================
- Hits 92869 64166 -28703
- Misses 34801 65113 +30312
+ Partials 7363 5722 -1641
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.75% <25.39%> (-20.68%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.29% <64.61%> (-10.58%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.12% <44.73%> (-13.38%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-38.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `92.23% <100.00%> (-3.18%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.18% <100.00%> (-6.29%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `76.52% <100.00%> (-3.29%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `73.63% <ø> (-2.04%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1021 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205431398
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `81.74603%` with `69 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.81%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [19 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 61.81% -6.96%
+ Complexity 28117 25187 -2930
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 83456 -9413
- Misses 34801 44610 +9809
+ Partials 7363 6935 -428
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.29% <64.61%> (-10.58%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <44.73%> (-12.96%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `94.17% <100.00%> (-1.24%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.81% <100.00%> (-4.66%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `77.46% <100.00%> (-2.35%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `73.63% <ø> (-2.04%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.77% <100.00%> (-5.72%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [493 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205581475
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.62434%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.76%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 71.42% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.76% -0.01%
- Complexity 28117 28136 +19
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 92837 -32
- Misses 34801 34813 +12
+ Partials 7363 7351 -12
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.83% <77.77%> (-0.04%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.00% <100.00%> (-0.47%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (-0.09%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205513560
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.62434%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.75%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 71.42% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.75% -0.02%
- Complexity 28117 28134 +17
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 92826 -43
- Misses 34801 34824 +23
+ Partials 7363 7351 -12
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.77% <77.77%> (-0.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.00% <100.00%> (-0.47%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (-0.09%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [14 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4100840084
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1ad2a5d9837981432070b0e91ed406e81c1e4c90 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5176425710
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.62434%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 485 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 71.42% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.77% -0.01%
- Complexity 28117 28138 +21
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 92841 -28
- Misses 34801 34810 +9
+ Partials 7363 7350 -13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <77.77%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.00% <100.00%> (-0.47%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (-0.09%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core)!: centralize instant generation in TransactionManager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5266644287
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
}, {
"hash" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"triggerType" : "PUSH"
}, {
"hash" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143",
"triggerID" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"triggerType" : "PUSH"
}, {
"hash" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"triggerType" : "PUSH"
}, {
"hash" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16236",
"triggerID" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"triggerType" : "PUSH"
}, {
"hash" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16237",
"triggerID" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"triggerType" : "PUSH"
}, {
"hash" : "39e822973ae515ee45d3d98fc8368365e797b9bc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16240",
"triggerID" : "39e822973ae515ee45d3d98fc8368365e797b9bc",
"triggerType" : "PUSH"
}, {
"hash" : "9cd1a5c573011a9c55189ce8f8417963bc49c588",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9cd1a5c573011a9c55189ce8f8417963bc49c588",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6edf57b229f151125b65b1a517882e48d0cdf579 UNKNOWN
* 293fe8129a6b1e331066d7ece71c04f281e68092 UNKNOWN
* 39e822973ae515ee45d3d98fc8368365e797b9bc Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16240)
* 9cd1a5c573011a9c55189ce8f8417963bc49c588 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core)!: centralize instant generation in TransactionManager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5263204563
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
}, {
"hash" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"triggerType" : "PUSH"
}, {
"hash" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143",
"triggerID" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"triggerType" : "PUSH"
}, {
"hash" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"triggerType" : "PUSH"
}, {
"hash" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6edf57b229f151125b65b1a517882e48d0cdf579 UNKNOWN
* 625a6b484d8569b976f8a75cba5b36695ccab7ce Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143)
* 293fe8129a6b1e331066d7ece71c04f281e68092 UNKNOWN
* 8607225c07b146e2e4104a31942fc66bef2c529c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core)!: centralize instant generation in TransactionManager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5264059595
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
}, {
"hash" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"triggerType" : "PUSH"
}, {
"hash" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143",
"triggerID" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"triggerType" : "PUSH"
}, {
"hash" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"triggerType" : "PUSH"
}, {
"hash" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16236",
"triggerID" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"triggerType" : "PUSH"
}, {
"hash" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16237",
"triggerID" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6edf57b229f151125b65b1a517882e48d0cdf579 UNKNOWN
* 293fe8129a6b1e331066d7ece71c04f281e68092 UNKNOWN
* f83553e65e47942f66b56ff5bae5131407fd8e26 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16237)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090163269
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `79.83425%` with `73 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 56.25%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [22 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 5 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-java-tests|15|10|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 56.25% -12.17%
+ Complexity 27408 22797 -4611
=============================================
Files 2423 2422 -1
Lines 132458 132408 -50
Branches 15972 15966 -6
=============================================
- Hits 90623 74483 -16140
- Misses 34784 51535 +16751
+ Partials 7051 6390 -661
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.53% <10.54%> (-26.78%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.09% <72.69%> (-5.72%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <70.24%> (-0.26%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.92%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `83.80% <100.00%> (-11.69%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `74.24% <100.00%> (-4.43%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `74.17% <100.00%> (-5.64%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.59% <100.00%> (-13.70%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `86.24% <100.00%> (-3.12%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `69.93% <100.00%> (-15.99%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [679 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094657916
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.77005%` with `42 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.39%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 97.87% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 68.39% -0.02%
- Complexity 27408 27418 +10
============================================
Files 2423 2422 -1
Lines 132458 132434 -24
Branches 15972 15971 -1
============================================
- Hits 90623 90583 -40
- Misses 34784 34804 +20
+ Partials 7051 7047 -4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <56.68%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.68% <77.51%> (-0.13%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <70.41%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.65% <52.52%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.19% <100.00%> (-0.49%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (+0.04%)` | :arrow_up: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [14 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089550327
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.35359%` with `158 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 32.81%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieSparkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieSparkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllU3BhcmtUYWJsZS5qYXZh) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 57.69% | [10 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 66.66% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 70.58% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [43 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|utilities|1|0|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 32.81% -35.61%
+ Complexity 27408 12991 -14417
=============================================
Files 2423 2359 -64
Lines 132458 125202 -7256
Branches 15972 14353 -1619
=============================================
- Hits 90623 41080 -49543
- Misses 34784 80655 +45871
+ Partials 7051 3467 -3584
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `76.19% <100.00%> (-19.31%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `56.80% <100.00%> (-23.01%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `73.21% <100.00%> (-16.08%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `44.94% <ø> (-16.86%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `18.18% <ø> (-57.50%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `65.73% <100.00%> (-20.19%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `79.31% <100.00%> (-10.35%)` | :arrow_down: |
| [...tion/restore/CopyOnWriteRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FCopyOnWriteRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0NvcHlPbldyaXRlUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `76.92% <100.00%> (-8.80%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1445 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4088755284
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 93972a520d44e929fd3b2fe2c7a4bb5af902b92e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4461954698
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.62434%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 119 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 71.42% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.77% -0.01%
- Complexity 28117 28138 +21
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 92841 -28
- Misses 34801 34810 +9
+ Partials 7363 7350 -13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <77.77%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.00% <100.00%> (-0.47%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (-0.09%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4088946254
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.11989%` with `117 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.92%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 70.83% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [31 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|utilities|1|0|
>|spark-java-tests|15|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 45.92% -22.50%
+ Complexity 27408 18272 -9136
=============================================
Files 2423 2376 -47
Lines 132458 127556 -4902
Branches 15972 14933 -1039
=============================================
- Hits 90623 58576 -32047
- Misses 34784 63709 +28925
+ Partials 7051 5271 -1780
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.29% <44.41%> (-11.72%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `59.15% <100.00%> (-20.66%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `42.72% <ø> (-32.95%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `86.20% <100.00%> (-3.45%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1090 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089495056
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.69811%` with `75 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.07%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 57.69% | [10 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 62.50% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 70.58% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 85.71% | [3 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [18 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|utilities|1|0|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 45.07% -23.35%
+ Complexity 27408 8407 -19001
=============================================
Files 2423 1187 -1236
Lines 132458 60968 -71490
Branches 15972 6517 -9455
=============================================
- Hits 90623 27482 -63141
+ Misses 34784 30500 -4284
+ Partials 7051 2986 -4065
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `76.19% <100.00%> (-19.31%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `19.71% <100.00%> (-60.10%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `73.21% <100.00%> (-16.08%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `44.94% <ø> (-16.86%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `0.00% <ø> (-75.68%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `65.73% <100.00%> (-20.19%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `79.31% <100.00%> (-10.35%)` | :arrow_down: |
| [...tion/restore/CopyOnWriteRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FCopyOnWriteRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0NvcHlPbldyaXRlUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `76.92% <100.00%> (-8.80%)` | :arrow_down: |
| [...tion/restore/MergeOnReadRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FMergeOnReadRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL01lcmdlT25SZWFkUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.10%)` | :arrow_down: |
| ... and [43 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1986 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090638664
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.30178%` with `97 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.94%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 80.85% | [4 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 66.66% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [22 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (998e5a5). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (998e5a5) |
>|------|------|------|
>|spark-scala-tests|10|2|
>|utilities|1|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 46.94% -21.47%
+ Complexity 27408 14796 -12612
=============================================
Files 2423 1924 -499
Lines 132458 102768 -29690
Branches 15972 12332 -3640
=============================================
- Hits 90623 48249 -42374
- Misses 34784 49640 +14856
+ Partials 7051 4879 -2172
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.58% <44.67%> (-11.43%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `88.57% <100.00%> (-6.93%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `28.16% <100.00%> (-51.65%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `27.27% <ø> (-48.41%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `86.20% <100.00%> (-3.45%)` | :arrow_down: |
| ... and [62 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1539 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090686945
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `81.81818%` with `68 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.16%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [19 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (998e5a5). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (998e5a5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 61.16% -7.26%
+ Complexity 27408 24520 -2888
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 80992 -9631
- Misses 34784 44579 +9795
+ Partials 7051 6849 -202
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.11% <61.24%> (-15.71%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <44.67%> (-12.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.52%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `94.28% <100.00%> (-1.21%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.36% <100.00%> (-6.31%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `62.44% <100.00%> (-17.38%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.22% <100.00%> (-6.14%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [509 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090830204
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.03743%` with `41 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.09%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 97.87% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 68.09% -0.33%
+ Complexity 27408 27310 -98
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 90172 -451
- Misses 34784 35209 +425
+ Partials 7051 7039 -12
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.68% <77.81%> (-0.14%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <70.71%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.52%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `76.87% <100.00%> (-1.80%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.26% <100.00%> (-0.10%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [48 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090885780
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.03743%` with `41 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.10%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 97.87% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 68.10% -0.31%
+ Complexity 27408 27318 -90
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 90190 -433
- Misses 34784 35187 +403
+ Partials 7051 7043 -8
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.75% <77.81%> (-0.07%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <70.71%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.52%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `76.87% <100.00%> (-1.80%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.26% <100.00%> (-0.10%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [46 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090727376
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.43316%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.71%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [15 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 65.71% -2.71%
+ Complexity 27408 26309 -1099
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 87016 -3607
- Misses 34784 38153 +3369
- Partials 7051 7251 +200
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <61.24%> (-16.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.68% <70.71%> (-0.32%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.52%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `74.24% <100.00%> (-4.43%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `62.44% <100.00%> (-17.38%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `84.56% <100.00%> (-4.80%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [352 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094650225
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.43316%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.53%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [15 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 67.53% -0.88%
+ Complexity 27408 27074 -334
============================================
Files 2423 2422 -1
Lines 132458 132434 -24
Branches 15972 15971 -1
============================================
- Hits 90623 89443 -1180
- Misses 34784 35889 +1105
- Partials 7051 7102 +51
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <56.68%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <73.37%> (-3.75%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <70.41%> (-0.09%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.65% <52.52%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `77.44% <100.00%> (-1.24%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `75.11% <100.00%> (-4.70%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.74% <100.00%> (-1.61%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [132 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090805491
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.70053%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.29%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 67.29% -1.13%
+ Complexity 27408 26997 -411
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 89106 -1517
- Misses 34784 36220 +1436
- Partials 7051 7094 +43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.13% <73.66%> (-3.69%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <70.71%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.52%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `76.12% <100.00%> (-2.55%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `75.11% <100.00%> (-4.70%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.58% <100.00%> (-1.78%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [151 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094615724
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `81.81818%` with `68 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.28%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [20 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (1ad2a5d). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (1ad2a5d) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 61.28% -7.14%
+ Complexity 27408 24519 -2889
============================================
Files 2423 2422 -1
Lines 132458 132434 -24
Branches 15972 15971 -1
============================================
- Hits 90623 81156 -9467
- Misses 34784 44490 +9706
+ Partials 7051 6788 -263
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <56.68%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <61.24%> (-16.14%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.08% <44.67%> (-11.92%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.65% <52.52%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `94.28% <100.00%> (-1.21%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.68% <100.00%> (-5.00%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `62.44% <100.00%> (-17.38%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.44% <100.00%> (-5.92%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [495 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094633969
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.16578%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 66.01%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [16 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 66.01% -2.41%
+ Complexity 27408 26418 -990
============================================
Files 2423 2422 -1
Lines 132458 132434 -24
Branches 15972 15971 -1
============================================
- Hits 90623 87420 -3203
- Misses 34784 37757 +2973
- Partials 7051 7257 +206
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <56.68%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <61.24%> (-16.14%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.79% <70.41%> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.65% <52.52%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `75.56% <100.00%> (-3.12%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `62.44% <100.00%> (-17.38%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `84.76% <100.00%> (-4.59%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [326 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4204763380
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
}, {
"hash" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7c0b4ccbb31148a172c028203680982b9511b9e6 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142)
* 6edf57b229f151125b65b1a517882e48d0cdf579 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049223440
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
Review Comment:
a boolean is not enough, we need to remember the reentrant times. I'm doing similiar stuff like Semaphore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core)!: centralize instant generation in TransactionManager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5265365697
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
}, {
"hash" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"triggerType" : "PUSH"
}, {
"hash" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143",
"triggerID" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"triggerType" : "PUSH"
}, {
"hash" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"triggerType" : "PUSH"
}, {
"hash" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16236",
"triggerID" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"triggerType" : "PUSH"
}, {
"hash" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16237",
"triggerID" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"triggerType" : "PUSH"
}, {
"hash" : "39e822973ae515ee45d3d98fc8368365e797b9bc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16240",
"triggerID" : "39e822973ae515ee45d3d98fc8368365e797b9bc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6edf57b229f151125b65b1a517882e48d0cdf579 UNKNOWN
* 293fe8129a6b1e331066d7ece71c04f281e68092 UNKNOWN
* 39e822973ae515ee45d3d98fc8368365e797b9bc Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16240)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4088952451
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.11989%` with `117 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.03%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 70.83% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [31 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|utilities|1|0|
>|spark-java-tests|15|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 45.03% -23.39%
+ Complexity 27408 18623 -8785
=============================================
Files 2423 2422 -1
Lines 132458 132414 -44
Branches 15972 15966 -6
=============================================
- Hits 90623 59634 -30989
- Misses 34784 67220 +32436
+ Partials 7051 5560 -1491
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <44.41%> (-12.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `59.15% <100.00%> (-20.66%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `42.72% <ø> (-32.95%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `86.20% <100.00%> (-3.45%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1064 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4088972364
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.66213%` with `104 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.07%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [28 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|utilities|1|0|
>|spark-java-tests|15|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 47.07% -21.35%
+ Complexity 27408 19398 -8010
=============================================
Files 2423 2422 -1
Lines 132458 132414 -44
Branches 15972 15966 -6
=============================================
- Hits 90623 62334 -28289
- Misses 34784 64395 +29611
+ Partials 7051 5685 -1366
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <61.63%> (-16.14%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <44.41%> (-12.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `70.67% <100.00%> (-8.00%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `59.62% <100.00%> (-20.19%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1018 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4088976798
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.66213%` with `104 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.07%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [28 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 17 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|utilities|1|0|
>|spark-java-tests|15|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 47.07% -21.35%
+ Complexity 27408 19398 -8010
=============================================
Files 2423 2422 -1
Lines 132458 132414 -44
Branches 15972 15966 -6
=============================================
- Hits 90623 62334 -28289
- Misses 34784 64395 +29611
+ Partials 7051 5685 -1366
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <61.63%> (-16.14%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <44.41%> (-12.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `70.67% <100.00%> (-8.00%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `59.62% <100.00%> (-20.19%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1018 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089029622
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `80.65395%` with `71 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.03%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [20 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 8 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|utilities|1|0|
>|spark-java-tests|15|8|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 54.03% -14.38%
+ Complexity 27408 22233 -5175
=============================================
Files 2423 2422 -1
Lines 132458 132414 -44
Branches 15972 15966 -6
=============================================
- Hits 90623 71555 -19068
- Misses 34784 54906 +20122
+ Partials 7051 5953 -1098
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <74.92%> (-3.77%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.82% <71.29%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `75.18% <100.00%> (-3.49%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `74.17% <100.00%> (-5.64%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `86.24% <100.00%> (-3.12%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [672 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089045913
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `82.01635%` with `66 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.88%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [19 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 4 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-java-tests|15|11|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 54.88% -13.54%
+ Complexity 27408 22577 -4831
=============================================
Files 2423 2422 -1
Lines 132458 132414 -44
Branches 15972 15966 -6
=============================================
- Hits 90623 72676 -17947
- Misses 34784 53852 +19068
+ Partials 7051 5886 -1165
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <79.15%> (-0.22%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.82% <71.29%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-38.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `75.93% <100.00%> (-2.74%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `78.87% <100.00%> (-0.94%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.91% <100.00%> (-1.44%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [576 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089701772
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `73.75691%` with `95 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 49.81%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 65.38% | [8 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 42.85% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [27 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 20 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 49.81% -18.61%
+ Complexity 27408 20111 -7297
=============================================
Files 2423 2422 -1
Lines 132458 132408 -50
Branches 15972 15966 -6
=============================================
- Hits 90623 65955 -24668
- Misses 34784 60418 +25634
+ Partials 7051 6035 -1016
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.94% <60.73%> (-4.87%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <45.09%> (-12.20%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.92%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `81.90% <100.00%> (-13.60%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `65.97% <100.00%> (-12.70%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `74.17% <100.00%> (-5.64%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.00% <100.00%> (-14.29%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `45.45% <ø> (-30.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `85.57% <100.00%> (-3.79%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `67.13% <100.00%> (-18.79%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [964 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090243820
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `79.83425%` with `73 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 56.25%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [22 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 5 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-java-tests|15|10|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 56.25% -12.17%
+ Complexity 27408 22797 -4611
=============================================
Files 2423 2422 -1
Lines 132458 132408 -50
Branches 15972 15966 -6
=============================================
- Hits 90623 74483 -16140
- Misses 34784 51535 +16751
+ Partials 7051 6390 -661
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.53% <10.54%> (-26.78%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.09% <72.69%> (-5.72%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <70.24%> (-0.26%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.92%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `83.80% <100.00%> (-11.69%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `74.24% <100.00%> (-4.43%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `74.17% <100.00%> (-5.64%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.59% <100.00%> (-13.70%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `86.24% <100.00%> (-3.12%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `69.93% <100.00%> (-15.99%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [679 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090760968
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.70053%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.23%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 67.23% -1.19%
+ Complexity 27408 26972 -436
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 89033 -1590
- Misses 34784 36293 +1509
- Partials 7051 7094 +43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.04% <73.66%> (-3.78%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <70.71%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.52%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `76.12% <100.00%> (-2.55%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `75.11% <100.00%> (-4.70%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.58% <100.00%> (-1.78%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [163 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090905602
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.03743%` with `41 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.12%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 97.87% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 68.12% -0.29%
+ Complexity 27408 27325 -83
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 90213 -410
- Misses 34784 35160 +376
+ Partials 7051 7047 -4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.79% <77.81%> (-0.02%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <70.71%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.52%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `76.87% <100.00%> (-1.80%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.26% <100.00%> (-0.10%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [46 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049199728
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/versioning/v1/ActiveTimelineV1.java:
##########
@@ -374,7 +364,8 @@ public HoodieInstant transitionLogCompactionRequestedToInflight(HoodieInstant re
}
Review Comment:
not sure about the context we want to move, so keep it and hand it over to @vinothchandar .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5247434574
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.62434%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 506 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 71.42% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.77% -0.01%
- Complexity 28117 28138 +21
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 92841 -28
- Misses 34801 34810 +9
+ Partials 7363 7350 -13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <77.77%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.00% <100.00%> (-0.47%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (-0.09%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core)!: centralize instant generation in TransactionManager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5264913179
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
}, {
"hash" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"triggerType" : "PUSH"
}, {
"hash" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143",
"triggerID" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"triggerType" : "PUSH"
}, {
"hash" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"triggerType" : "PUSH"
}, {
"hash" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16236",
"triggerID" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"triggerType" : "PUSH"
}, {
"hash" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16237",
"triggerID" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"triggerType" : "PUSH"
}, {
"hash" : "39e822973ae515ee45d3d98fc8368365e797b9bc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "39e822973ae515ee45d3d98fc8368365e797b9bc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6edf57b229f151125b65b1a517882e48d0cdf579 UNKNOWN
* 293fe8129a6b1e331066d7ece71c04f281e68092 UNKNOWN
* f83553e65e47942f66b56ff5bae5131407fd8e26 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16237)
* 39e822973ae515ee45d3d98fc8368365e797b9bc UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core)!: centralize instant generation in TransactionManager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3766272833
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
+ return HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L);
+ }
+
+ /**
+ * Generates an instant time and executes an action that requires that instant time within a lock.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(Option.empty(), Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(providedInstantTime, Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param lastCompletedActionInstant optional input representing the last completed instant, used for logging purposes.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Option<HoodieInstant> lastCompletedActionInstant, Function<String, T> instantTimeConsumingAction) {
+ if (isLockRequired()) {
+ acquireLock();
+ }
+ String requestedInstant = providedInstantTime.orElseGet(() -> HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L));
+ try {
+ if (lastCompletedActionInstant.isEmpty()) {
+ LOG.info("State change starting for {}", changeActionInstant);
+ } else {
+ LOG.info("State change starting for {} with latest completed action instant {}", changeActionInstant, lastCompletedActionInstant.get());
+ }
+ return instantTimeConsumingAction.apply(requestedInstant);
+ } finally {
+ if (isLockRequired()) {
+ releaseLock();
+ LOG.info("State change ended for {}", requestedInstant);
+ }
+ }
+ }
+
+ public void beginStateChange() {
+ beginStateChange(Option.empty(), Option.empty());
}
public void beginStateChange(Option<HoodieInstant> changeActionInstant,
Option<HoodieInstant> lastCompletedActionInstant) {
if (isLockRequired) {
LOG.info("State change starting for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
- lockManager.lock();
+ acquireLock();
reset(this.changeActionInstant, changeActionInstant, lastCompletedActionInstant);
LOG.info("State change started for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
}
}
+ public void endStateChange() {
+ endStateChange(Option.empty());
+ }
+
public void endStateChange(Option<HoodieInstant> changeActionInstant) {
if (isLockRequired) {
LOG.info("State change ending for action instant {}", changeActionInstant);
if (reset(changeActionInstant, Option.empty(), Option.empty())) {
- lockManager.unlock();
+ releaseLock();
LOG.info("State change ended for action instant {}", changeActionInstant);
}
}
}
+ /**
+ * Caution: the {@code hasLock} flag can not be used to skip the `#lock` eagerly if the thread switches,
+ * the corner case below can cause deadlock:
+ *
+ * <pre>
+ * threadA => acquireLock(), {@code hasLock} setup as true and got the lock acquired;
+ * threadB => acquireLock(), check the {@code hasLock} as true, returns early;
+ * threadB => releaseLock(), set up the {@code hasLock} as false;
+ * threadA => releaseLock(), detect the {@code hasLock} as false and returns early.
+ *
+ * The lock held by threadA will never be released.
+ * </pre>
+ */
+ private void acquireLock() {
+ if (lockHolderId > 0 && isLockHeldByCurrentThread()) {
+ LOG.info("{}: Lock already acquired, skipping lock acquisition.", this);
+ permits++;
+ return;
+ }
+ lockManager.lock();
+ permits++;
Review Comment:
have remove the reentrancy since it is hard to keep robust for correctness:
Short answer: I would make `TransactionManager` non-reentrant. `lockHolderId + permits` implements reentrant mutex mechanics, but it does not provide coherent nested-transaction semantics.
The current implementation has a concrete lock leak:
1. `begin(A)` → `permits = 1`, owner instant A
2. `begin(B)` → `permits = 2`, owner instant overwritten with B
3. `end(A)` → `reset()` rejects A, so no permit is released
4. `end(B)` → releases one permit, leaving `permits = 1`
The existing [reentrancy test](/Users/chenyuzhao/workspace/hudi-dev/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/transaction/TestTransactionManager.java:103) uses exactly this sequence but only checks that calls do not throw. It never verifies that the lock was released.
Other concerns:
- Nested `begin(B)` overwrites A’s transaction metadata; ending B does not restore A.
- Clearing `lockHolderId` before calling the underlying `unlock()` leaves local state incorrect if the provider fails to unlock.
- `Thread.getId()` may eventually be reused; storing the owning `Thread` would be safer.
- `TransactionManager` is serializable, but `lockHolderId` and `permits` are not transient, while `timeGenerator` is transient. Deserialization can therefore produce meaningless ownership state and a null generator.
- `permits <= 0` hides under-release; it should enforce exact invariants.
I found one real nested use in [BaseHoodieTableServiceClient.java](/Users/chenyuzhao/workspace/hudi-dev/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:1344): an outer transaction calls `executeStateChangeWithInstant()` merely to generate an instant. That can use `txnManager.generateInstantTime()` directly, so it does not justify general reentrancy.
My recommendation:
- Make `beginStateChange`/`executeStateChangeWithInstant` fail fast when the same thread already owns a transaction.
- Refactor helpers called inside transactions to reuse the existing transaction explicitly.
- Prefer the scoped callback API over manual `begin`/`end`.
- Treat `begin(A) → begin(B)` as a programming error, especially when A and B differ.
If true nested transactions are required, a counter is insufficient. You would need a stack of transaction frames, strict LIFO completion, restoration of outer metadata, and an actual locally synchronized ownership mechanism around the distributed lock. That is considerably more complexity than the apparent use cases warrant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5207576702
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.62434%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 499 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 71.42% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.77% -0.01%
- Complexity 28117 28138 +21
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 92841 -28
- Misses 34801 34810 +9
+ Partials 7363 7350 -13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <77.77%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.00% <100.00%> (-0.47%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (-0.09%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4204641458
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1ad2a5d9837981432070b0e91ed406e81c1e4c90 Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733)
* 7c0b4ccbb31148a172c028203680982b9511b9e6 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205155669
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.63492%` with `111 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.10%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [31 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (625a6b4). Click for more details.
>
> <details><summary>HEAD has 5 uploads less than BASE</summary>
>
>| Flag | BASE (0591933) | HEAD (625a6b4) |
>|------|------|------|
>|spark-scala-tests|10|8|
>|spark-java-tests|15|12|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.77% 43.10% -25.68%
+ Complexity 28117 18092 -10025
=============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
=============================================
- Hits 92869 58187 -34682
- Misses 34801 71668 +36867
+ Partials 7363 5146 -2217
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.75% <25.39%> (-20.68%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.10% <71.03%> (-0.31%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `35.62% <63.15%> (-13.24%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-45.51%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-38.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `92.23% <100.00%> (-3.18%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `76.52% <100.00%> (-3.29%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `87.50% <100.00%> (-1.79%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `51.68% <ø> (-10.12%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `73.63% <ø> (-2.04%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1146 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4088851918
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `56.94823%` with `158 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 32.81%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieSparkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieSparkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllU3BhcmtUYWJsZS5qYXZh) | 0.00% | [14 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 57.69% | [10 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 66.66% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 70.58% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...va/org/apache/hudi/client/SparkRDDWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FSparkRDDWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L1NwYXJrUkREV3JpdGVDbGllbnQuamF2YQ==) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [43 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|utilities|1|0|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 32.81% -35.60%
+ Complexity 27408 12996 -14412
=============================================
Files 2423 2359 -64
Lines 132458 125208 -7250
Branches 15972 14353 -1619
=============================================
- Hits 90623 41089 -49534
- Misses 34784 80651 +45867
+ Partials 7051 3468 -3583
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `56.80% <100.00%> (-23.01%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `73.21% <100.00%> (-16.08%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `44.94% <ø> (-16.86%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `18.18% <ø> (-57.50%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `65.73% <100.00%> (-20.19%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `79.31% <100.00%> (-10.35%)` | :arrow_down: |
| [...tion/restore/CopyOnWriteRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FCopyOnWriteRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0NvcHlPbldyaXRlUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `76.92% <100.00%> (-8.80%)` | :arrow_down: |
| [...tion/restore/MergeOnReadRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FMergeOnReadRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL01lcmdlT25SZWFkUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.10%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1447 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4088961900
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.66213%` with `104 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.01%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [28 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|utilities|1|0|
>|spark-java-tests|15|2|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 47.01% -21.41%
+ Complexity 27408 19373 -8035
=============================================
Files 2423 2422 -1
Lines 132458 132414 -44
Branches 15972 15966 -6
=============================================
- Hits 90623 62255 -28368
- Misses 34784 64465 +29681
+ Partials 7051 5694 -1357
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.50% <61.63%> (-15.31%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <44.41%> (-12.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `70.67% <100.00%> (-8.00%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `59.62% <100.00%> (-20.19%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1019 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089629147
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `63.81215%` with `131 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 41.54%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 61.53% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 70.83% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 70.58% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [38 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|utilities|1|0|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 41.54% -26.88%
+ Complexity 27408 16605 -10803
=============================================
Files 2423 2405 -18
Lines 132458 130074 -2384
Branches 15972 15468 -504
=============================================
- Hits 90623 54036 -36587
- Misses 34784 70646 +35862
+ Partials 7051 5392 -1659
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.08% <45.09%> (-11.93%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `78.09% <100.00%> (-17.41%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `56.80% <100.00%> (-23.01%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.00% <100.00%> (-14.29%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `42.72% <ø> (-32.95%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `65.73% <100.00%> (-20.19%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `79.31% <100.00%> (-10.35%)` | :arrow_down: |
| [...tion/restore/CopyOnWriteRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FCopyOnWriteRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0NvcHlPbldyaXRlUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `76.92% <100.00%> (-8.80%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1257 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089650114
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `63.81215%` with `131 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 41.16%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 61.53% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 70.83% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 70.58% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [38 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|utilities|1|0|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 41.16% -27.26%
+ Complexity 27408 16766 -10642
=============================================
Files 2423 2422 -1
Lines 132458 132408 -50
Branches 15972 15966 -6
=============================================
- Hits 90623 54503 -36120
- Misses 34784 72372 +37588
+ Partials 7051 5533 -1518
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <45.09%> (-12.20%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `78.09% <100.00%> (-17.41%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `56.80% <100.00%> (-23.01%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.00% <100.00%> (-14.29%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `42.72% <ø> (-32.95%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `65.73% <100.00%> (-20.19%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `79.31% <100.00%> (-10.35%)` | :arrow_down: |
| [...tion/restore/CopyOnWriteRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FCopyOnWriteRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0NvcHlPbldyaXRlUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `76.92% <100.00%> (-8.80%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1246 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089741851
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `74.30939%` with `93 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 51.32%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 42.85% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [27 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 51.32% -17.10%
+ Complexity 27408 20851 -6557
=============================================
Files 2423 2422 -1
Lines 132458 132408 -50
Branches 15972 15966 -6
=============================================
- Hits 90623 67954 -22669
- Misses 34784 58425 +23641
+ Partials 7051 6029 -1022
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.53% <10.54%> (-26.78%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.97% <60.73%> (-6.84%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <45.09%> (-12.20%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.92%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `81.90% <100.00%> (-13.60%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `65.97% <100.00%> (-12.70%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `74.17% <100.00%> (-5.64%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.00% <100.00%> (-14.29%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `45.45% <ø> (-30.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `85.57% <100.00%> (-3.79%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `67.13% <100.00%> (-18.79%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [884 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090640381
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.30178%` with `97 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.94%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 80.85% | [4 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 66.66% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [22 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (998e5a5). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (998e5a5) |
>|------|------|------|
>|spark-scala-tests|10|2|
>|utilities|1|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 46.94% -21.47%
+ Complexity 27408 14796 -12612
=============================================
Files 2423 1924 -499
Lines 132458 102768 -29690
Branches 15972 12332 -3640
=============================================
- Hits 90623 48249 -42374
- Misses 34784 49640 +14856
+ Partials 7051 4879 -2172
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.58% <44.67%> (-11.43%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `88.57% <100.00%> (-6.93%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `28.16% <100.00%> (-51.65%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `27.27% <ø> (-48.41%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `86.20% <100.00%> (-3.45%)` | :arrow_down: |
| ... and [62 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1539 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090624815
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `77.17042%` with `71 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.91%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 80.85% | [4 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 66.66% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (998e5a5). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (998e5a5) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|utilities|1|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 53.91% -14.50%
+ Complexity 27408 12095 -15313
=============================================
Files 2423 1416 -1007
Lines 132458 69678 -62780
Branches 15972 7768 -8204
=============================================
- Hits 90623 37570 -53053
+ Misses 34784 28758 -6026
+ Partials 7051 3350 -3701
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `87.61% <100.00%> (-7.88%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `28.16% <100.00%> (-51.65%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `51.68% <ø> (-10.12%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `0.00% <ø> (-75.68%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `86.20% <100.00%> (-3.45%)` | :arrow_down: |
| ... and [52 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1739 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090782069
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.70053%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.25%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 67.25% -1.16%
+ Complexity 27408 26980 -428
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 89061 -1562
- Misses 34784 36266 +1482
- Partials 7051 7093 +42
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <73.66%> (-3.75%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <70.71%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.52%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `76.12% <100.00%> (-2.55%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `75.11% <100.00%> (-4.70%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.58% <100.00%> (-1.78%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [158 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094616477
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `81.81818%` with `68 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.28%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [20 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (1ad2a5d). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (1ad2a5d) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 61.28% -7.14%
+ Complexity 27408 24519 -2889
============================================
Files 2423 2422 -1
Lines 132458 132434 -24
Branches 15972 15971 -1
============================================
- Hits 90623 81156 -9467
- Misses 34784 44490 +9706
+ Partials 7051 6788 -263
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <56.68%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <61.24%> (-16.14%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.08% <44.67%> (-11.92%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.65% <52.52%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `94.28% <100.00%> (-1.21%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.68% <100.00%> (-5.00%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `62.44% <100.00%> (-17.38%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.44% <100.00%> (-5.92%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [495 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094649498
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.43316%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.51%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [15 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 67.51% -0.91%
+ Complexity 27408 27067 -341
============================================
Files 2423 2422 -1
Lines 132458 132434 -24
Branches 15972 15971 -1
============================================
- Hits 90623 89414 -1209
- Misses 34784 35917 +1133
- Partials 7051 7103 +52
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <56.68%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.03% <73.37%> (-3.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.91% <70.41%> (-0.09%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.65% <52.52%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `77.44% <100.00%> (-1.24%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `75.11% <100.00%> (-4.70%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.74% <100.00%> (-1.61%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [139 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094631195
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.16578%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.95%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [16 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 65.95% -2.46%
+ Complexity 27408 26399 -1009
============================================
Files 2423 2422 -1
Lines 132458 132434 -24
Branches 15972 15971 -1
============================================
- Hits 90623 87353 -3270
- Misses 34784 37829 +3045
- Partials 7051 7252 +201
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <56.68%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <61.24%> (-16.14%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <70.41%> (-0.32%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.65% <52.52%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `75.56% <100.00%> (-3.12%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `62.44% <100.00%> (-17.38%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `84.76% <100.00%> (-4.59%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [335 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094661070
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.77005%` with `42 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.39%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 97.87% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 68.39% -0.02%
- Complexity 27408 27418 +10
============================================
Files 2423 2422 -1
Lines 132458 132434 -24
Branches 15972 15971 -1
============================================
- Hits 90623 90583 -40
- Misses 34784 34804 +20
+ Partials 7051 7047 -4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <56.68%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.72% <77.51%> (-0.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <70.41%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.65% <52.52%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.19% <100.00%> (-0.49%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (+0.04%)` | :arrow_up: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [14 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049211910
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/FlinkTables.java:
##########
@@ -78,6 +82,11 @@ public static HoodieFlinkTable<?> createTable(
*/
public static HoodieFlinkTable<?> createTable(Configuration conf) {
HoodieWriteConfig writeConfig = FlinkWriteClients.getHoodieClientConfig(conf, true, false);
- return createTableInternal(writeConfig, HoodieFlinkEngineContext.DEFAULT);
+ return createTableInternal(writeConfig, HoodieFlinkEngineContext.DEFAULT, Option.empty());
+ }
+
+ public static HoodieFlinkTable<?> createTable(Configuration conf, TransactionManager txnManager) {
+ HoodieWriteConfig writeConfig = FlinkWriteClients.getHoodieClientConfig(conf, true, false);
Review Comment:
not a blocker as the caller has explicit validation of the txn manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205163909
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.63492%` with `111 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.10%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [31 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (625a6b4). Click for more details.
>
> <details><summary>HEAD has 3 uploads less than BASE</summary>
>
>| Flag | BASE (0591933) | HEAD (625a6b4) |
>|------|------|------|
>|spark-java-tests|15|12|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.77% 43.10% -25.68%
+ Complexity 28117 18092 -10025
=============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
=============================================
- Hits 92869 58187 -34682
- Misses 34801 71668 +36867
+ Partials 7363 5146 -2217
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.75% <25.39%> (-20.68%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.10% <71.03%> (-0.31%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `35.62% <63.15%> (-13.24%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-45.51%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-38.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `92.23% <100.00%> (-3.18%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `76.52% <100.00%> (-3.29%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `87.50% <100.00%> (-1.79%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `51.68% <ø> (-10.12%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `73.63% <ø> (-2.04%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1146 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205474927
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.03704%` with `49 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 66.38%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [15 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 66.38% -2.40%
+ Complexity 28117 27089 -1028
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 89618 -3251
- Misses 34801 37951 +3150
- Partials 7363 7432 +69
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.29% <64.61%> (-10.58%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.11% <70.46%> (-0.40%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `75.63% <100.00%> (-2.84%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `77.46% <100.00%> (-2.35%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `73.63% <ø> (-2.04%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `85.09% <100.00%> (-4.40%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [320 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core)!: centralize instant generation in TransactionManager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5300494900
> Based on your last comment @danny0405 - are we abandoning this approach then? its unclear if you feel confident with the PR to be safe for production. or you feel there are caveats
I feel confident for the non-reentrency way instead of the other, would be conservertive for the reentrency as of now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5200579642
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.62434%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 497 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 71.42% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.77% -0.01%
- Complexity 28117 28138 +21
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 92841 -28
- Misses 34801 34810 +9
+ Partials 7363 7350 -13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <77.77%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.00% <100.00%> (-0.47%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (-0.09%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5207575459
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.62434%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 499 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 71.42% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.77% -0.01%
- Complexity 28117 28138 +21
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 92841 -28
- Misses 34801 34810 +9
+ Partials 7363 7350 -13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <77.77%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.00% <100.00%> (-0.47%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (-0.09%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090144181
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `79.83425%` with `73 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 56.25%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [22 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 6 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-java-tests|15|9|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 56.25% -12.17%
+ Complexity 27408 22796 -4612
=============================================
Files 2423 2422 -1
Lines 132458 132408 -50
Branches 15972 15966 -6
=============================================
- Hits 90623 74482 -16141
- Misses 34784 51535 +16751
+ Partials 7051 6391 -660
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.53% <10.54%> (-26.78%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.09% <72.69%> (-5.72%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <70.24%> (-0.26%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.92%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `83.80% <100.00%> (-11.69%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `74.24% <100.00%> (-4.43%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `74.17% <100.00%> (-5.64%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.59% <100.00%> (-13.70%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `86.24% <100.00%> (-3.12%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `69.93% <100.00%> (-15.99%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [679 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089022430
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `80.65395%` with `71 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.01%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [20 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 9 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|utilities|1|0|
>|spark-java-tests|15|7|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 54.01% -14.41%
+ Complexity 27408 22227 -5181
=============================================
Files 2423 2422 -1
Lines 132458 132414 -44
Branches 15972 15966 -6
=============================================
- Hits 90623 71525 -19098
- Misses 34784 54931 +20147
+ Partials 7051 5958 -1093
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <74.92%> (-3.83%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.82% <71.29%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `75.18% <100.00%> (-3.49%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `74.17% <100.00%> (-5.64%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `86.24% <100.00%> (-3.12%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [679 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090473447
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.03610%` with `83 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.15%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 72.34% | [7 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 57.69% | [10 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 62.50% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 70.58% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [18 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (998e5a5). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (998e5a5) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|utilities|1|0|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 45.15% -23.27%
+ Complexity 27408 8432 -18976
=============================================
Files 2423 1187 -1236
Lines 132458 60980 -71478
Branches 15972 6518 -9454
=============================================
- Hits 90623 27535 -63088
+ Misses 34784 30450 -4334
+ Partials 7051 2995 -4056
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `76.19% <100.00%> (-19.31%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `19.71% <100.00%> (-60.10%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `73.21% <100.00%> (-16.08%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `44.94% <ø> (-16.86%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `0.00% <ø> (-75.68%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `65.73% <100.00%> (-20.19%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `79.31% <100.00%> (-10.35%)` | :arrow_down: |
| [...tion/restore/CopyOnWriteRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FCopyOnWriteRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0NvcHlPbldyaXRlUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `76.92% <100.00%> (-8.80%)` | :arrow_down: |
| [...tion/restore/MergeOnReadRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FMergeOnReadRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL01lcmdlT25SZWFkUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.10%)` | :arrow_down: |
| ... and [43 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1984 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089099551
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `82.01635%` with `66 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.91%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [19 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 2 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-java-tests|15|13|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 54.91% -13.50%
+ Complexity 27408 22590 -4818
=============================================
Files 2423 2422 -1
Lines 132458 132414 -44
Branches 15972 15966 -6
=============================================
- Hits 90623 72718 -17905
- Misses 34784 53801 +19017
+ Partials 7051 5895 -1156
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.70% <79.15%> (-0.12%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.82% <71.29%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-38.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `75.93% <100.00%> (-2.74%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `78.87% <100.00%> (-0.94%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.91% <100.00%> (-1.44%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [570 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089093724
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `82.01635%` with `66 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.88%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [19 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 3 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-java-tests|15|12|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 54.88% -13.53%
+ Complexity 27408 22577 -4831
=============================================
Files 2423 2422 -1
Lines 132458 132414 -44
Branches 15972 15966 -6
=============================================
- Hits 90623 72679 -17944
- Misses 34784 53850 +19066
+ Partials 7051 5885 -1166
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.63% <79.15%> (-0.19%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.82% <71.29%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-38.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `75.93% <100.00%> (-2.74%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `78.87% <100.00%> (-0.94%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.91% <100.00%> (-1.44%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [573 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089831558
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `79.83425%` with `73 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.92%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [22 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 11 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-scala-tests|10|9|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 55.92% -12.49%
+ Complexity 27408 22681 -4727
=============================================
Files 2423 2422 -1
Lines 132458 132408 -50
Branches 15972 15966 -6
=============================================
- Hits 90623 74052 -16571
- Misses 34784 51943 +17159
+ Partials 7051 6413 -638
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.53% <10.54%> (-26.78%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.98% <60.73%> (-6.84%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <70.24%> (-0.26%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.92%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `83.80% <100.00%> (-11.69%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `71.61% <100.00%> (-7.06%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `74.17% <100.00%> (-5.64%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.59% <100.00%> (-13.70%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `59.09% <ø> (-16.59%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `86.24% <100.00%> (-3.12%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `69.93% <100.00%> (-15.99%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [693 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094704972
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.77005%` with `42 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.40%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 97.87% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 68.40% -0.02%
- Complexity 27408 27418 +10
============================================
Files 2423 2422 -1
Lines 132458 132434 -24
Branches 15972 15971 -1
============================================
- Hits 90623 90587 -36
- Misses 34784 34800 +16
+ Partials 7051 7047 -4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <56.68%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.79% <77.51%> (-0.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <70.41%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.65% <52.52%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.19% <100.00%> (-0.49%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (+0.04%)` | :arrow_up: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4099155031
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 93972a520d44e929fd3b2fe2c7a4bb5af902b92e Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702)
* 1ad2a5d9837981432070b0e91ed406e81c1e4c90 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090645703
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.30178%` with `97 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.35%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 80.85% | [4 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 66.66% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [22 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (998e5a5). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (998e5a5) |
>|------|------|------|
>|spark-scala-tests|10|3|
>|utilities|1|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 46.35% -22.06%
+ Complexity 27408 14957 -12451
=============================================
Files 2423 1941 -482
Lines 132458 105072 -27386
Branches 15972 12822 -3150
=============================================
- Hits 90623 48710 -41913
- Misses 34784 51341 +16557
+ Partials 7051 5021 -2030
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.29% <44.67%> (-11.72%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `88.57% <100.00%> (-6.93%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `28.16% <100.00%> (-51.65%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `27.27% <ø> (-48.41%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `86.20% <100.00%> (-3.45%)` | :arrow_down: |
| ... and [62 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1530 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090754871
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.70053%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.16%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 67.16% -1.25%
+ Complexity 27408 26950 -458
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 88944 -1679
- Misses 34784 36361 +1577
- Partials 7051 7115 +64
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.03% <73.66%> (-3.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.68% <70.71%> (-0.32%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.52%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `76.12% <100.00%> (-2.55%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `75.11% <100.00%> (-4.70%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.58% <100.00%> (-1.78%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [187 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094644914
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.43316%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.45%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [15 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 67.45% -0.97%
+ Complexity 27408 27051 -357
============================================
Files 2423 2422 -1
Lines 132458 132434 -24
Branches 15972 15971 -1
============================================
- Hits 90623 89331 -1292
- Misses 34784 35980 +1196
- Partials 7051 7123 +72
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <56.68%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.03% <73.37%> (-3.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.79% <70.41%> (-0.22%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.65% <52.52%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `77.44% <100.00%> (-1.24%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `75.11% <100.00%> (-4.70%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.74% <100.00%> (-1.61%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [161 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4149703440
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.77005%` with `42 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.40%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 23 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 97.87% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 68.40% -0.02%
- Complexity 27408 27418 +10
============================================
Files 2423 2422 -1
Lines 132458 132434 -24
Branches 15972 15971 -1
============================================
- Hits 90623 90587 -36
- Misses 34784 34800 +16
+ Partials 7051 7047 -4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <56.68%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.79% <77.51%> (-0.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <70.41%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.65% <52.52%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.19% <100.00%> (-0.49%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (+0.04%)` | :arrow_up: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049240330
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1747,22 +1745,25 @@ public void update(HoodieRestoreMetadata restoreMetadata, String instantTime) {
// We cannot create a deltaCommit at instantTime now because a future (rollback) block has already been written to the logFiles.
// We need to choose a timestamp which would be a validInstantTime for MDT. This is either a commit timestamp completed on the dataset
// or a new timestamp which we use for MDT clean, compaction etc.
- String syncCommitTime = createRestoreInstantTime();
- processAndCommit(syncCommitTime, () -> {
- // For Files partition.
- Map<String, HoodieData<HoodieRecord>> partitionRecords = new HashMap<>();
- partitionRecords.putAll(HoodieTableMetadataUtil.convertMissingPartitionRecords(engineContext,
- partitionsToDelete, partitionFilesToAdd, partitionFilesToDelete, syncCommitTime));
- // For ColumnStats partition if enabled.
- if (dataMetaClient.getTableConfig().getMetadataPartitions().contains(COLUMN_STATS.getPartitionPath())) {
- partitionRecords.putAll(convertToColumnStatsRecord(
- partitionFilesToAdd, partitionFilesToDelete, engineContext, dataMetaClient,
- dataWriteConfig.getMetadataConfig(), Option.of(dataWriteConfig.getRecordMerger().getRecordType()),
- dataWriteConfig.getMetadataConfig().getColumnStatsIndexParallelism()));
- }
- return partitionRecords;
+ writeClient.getTransactionManager().executeStateChangeWithInstant(metadataTableCommit -> {
+ String syncCommitTime = createRestoreTimestamp(metadataTableCommit);
+ processAndCommit(syncCommitTime, () -> {
+ // For Files partition.
+ Map<String, HoodieData<HoodieRecord>> partitionRecords = new HashMap<>();
+ partitionRecords.putAll(HoodieTableMetadataUtil.convertMissingPartitionRecords(engineContext,
+ partitionsToDelete, partitionFilesToAdd, partitionFilesToDelete, syncCommitTime));
+ // For ColumnStats partition if enabled.
+ if (dataMetaClient.getTableConfig().getMetadataPartitions().contains(COLUMN_STATS.getPartitionPath())) {
+ partitionRecords.putAll(convertToColumnStatsRecord(
+ partitionFilesToAdd, partitionFilesToDelete, engineContext, dataMetaClient,
+ dataWriteConfig.getMetadataConfig(), Option.of(dataWriteConfig.getRecordMerger().getRecordType()),
+ dataWriteConfig.getMetadataConfig().getColumnStatsIndexParallelism()));
+ }
+ return partitionRecords;
+ });
+ // empty result
+ return Option.empty();
});
- closeInternal();
} catch (IOException e) {
throw new HoodieMetadataException("IOException during MDT restore sync", e);
}
Review Comment:
add it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049166541
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
+ return HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L);
+ }
+
+ /**
+ * Generates an instant time and executes an action that requires that instant time within a lock.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(Option.empty(), Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(providedInstantTime, Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param lastCompletedActionInstant optional input representing the last completed instant, used for logging purposes.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Option<HoodieInstant> lastCompletedActionInstant, Function<String, T> instantTimeConsumingAction) {
+ if (isLockRequired()) {
+ acquireLock();
+ }
+ String requestedInstant = providedInstantTime.orElseGet(() -> HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L));
Review Comment:
move L114 inside the try-finally clause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049173396
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -226,11 +227,11 @@ private HoodieCleanMetadata runClean(HoodieTable<T, I, K, O> table, HoodieInstan
);
this.txnManager.beginStateChange(Option.of(inflightInstant), Option.empty());
writeTableMetadata(metadata, inflightInstant.requestedTime());
- table.getActiveTimeline().transitionCleanInflightToComplete(
- false,
- inflightInstant,
- Option.of(metadata),
- completedInstant -> table.getMetaClient().getTableFormat().clean(metadata, completedInstant, table.getContext(), table.getMetaClient(), table.getViewManager()));
+ TableFormatCompletionAction formatCompletionAction = completedInstant -> table.getMetaClient().getTableFormat()
+ .clean(metadata, completedInstant, table.getContext(), table.getMetaClient(), table.getViewManager());
+ HoodieInstant completedInstant = table.getActiveTimeline().transitionCleanInflightToComplete(inflightInstant, Option.of(metadata), txnManager.generateInstantTime());
+ // FIXME-vc: this is an one off..
+ formatCompletionAction.execute(completedInstant);
log.info("Marked clean started on {} as complete", inflightInstant.requestedTime());
Review Comment:
not sure what it means for `one off...`, the APi `transitionCleanInflightToComplete` accpects an explicit completion action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049044035
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
+ return HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L);
+ }
+
+ /**
+ * Generates an instant time and executes an action that requires that instant time within a lock.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(Option.empty(), Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(providedInstantTime, Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param lastCompletedActionInstant optional input representing the last completed instant, used for logging purposes.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Option<HoodieInstant> lastCompletedActionInstant, Function<String, T> instantTimeConsumingAction) {
+ if (isLockRequired()) {
+ acquireLock();
+ }
+ String requestedInstant = providedInstantTime.orElseGet(() -> HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L));
+ try {
+ if (lastCompletedActionInstant.isEmpty()) {
+ LOG.info("State change starting for {}", changeActionInstant);
+ } else {
+ LOG.info("State change starting for {} with latest completed action instant {}", changeActionInstant, lastCompletedActionInstant.get());
+ }
+ return instantTimeConsumingAction.apply(requestedInstant);
+ } finally {
+ if (isLockRequired()) {
+ releaseLock();
+ LOG.info("State change ended for {}", requestedInstant);
+ }
+ }
+ }
+
+ public void beginStateChange() {
+ beginStateChange(Option.empty(), Option.empty());
}
public void beginStateChange(Option<HoodieInstant> changeActionInstant,
Option<HoodieInstant> lastCompletedActionInstant) {
if (isLockRequired) {
LOG.info("State change starting for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
- lockManager.lock();
+ acquireLock();
reset(this.changeActionInstant, changeActionInstant, lastCompletedActionInstant);
LOG.info("State change started for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
}
}
+ public void endStateChange() {
+ endStateChange(Option.empty());
+ }
+
public void endStateChange(Option<HoodieInstant> changeActionInstant) {
if (isLockRequired) {
LOG.info("State change ending for action instant {}", changeActionInstant);
if (reset(changeActionInstant, Option.empty(), Option.empty())) {
- lockManager.unlock();
+ releaseLock();
LOG.info("State change ended for action instant {}", changeActionInstant);
}
}
}
+ /**
+ * Caution: the {@code hasLock} flag can not be used to skip the `#lock` eagerly if the thread switches,
+ * the corner case below can cause deadlock:
+ *
+ * <pre>
+ * threadA => acquireLock(), {@code hasLock} setup as true and got the lock acquired;
+ * threadB => acquireLock(), check the {@code hasLock} as true, returns early;
+ * threadB => releaseLock(), set up the {@code hasLock} as false;
+ * threadA => releaseLock(), detect the {@code hasLock} as false and returns early.
+ *
+ * The lock held by threadA will never be released.
+ * </pre>
+ */
+ private void acquireLock() {
+ if (lockHolderId > 0 && isLockHeldByCurrentThread()) {
+ LOG.info("{}: Lock already acquired, skipping lock acquisition.", this);
+ permits++;
+ return;
+ }
+ lockManager.lock();
+ permits++;
+ this.lockHolderId = Thread.currentThread().getId();
+ LOG.info("{}: Lock acquired for action instant {}", this, changeActionInstant);
+ }
+
+ /**
+ * Caution: the `hasLock` flag can not be used to skip the `#unlock` eagerly if the thread switches.
+ * see the corner case of {@link #acquireLock()}.
+ */
+ private void releaseLock() {
+ if (isLockHeldByCurrentThread()) {
+ --permits;
+ if (permits == 0) {
+ lockManager.unlock();
+ this.lockHolderId = -1;
+ LOG.info("{}: Lock released for action instant {}", this, changeActionInstant);
+ }
Review Comment:
> This introduces a race condition where a blocked thread can acquire the lock
A blocked thread can not acquire the lock until the current thread releases it. see `#releaseLock`, and the design requires that `#acquireLock` and `#releaseLock` must occurs in pair.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049049214
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
+ return HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L);
+ }
+
+ /**
+ * Generates an instant time and executes an action that requires that instant time within a lock.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(Option.empty(), Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(providedInstantTime, Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param lastCompletedActionInstant optional input representing the last completed instant, used for logging purposes.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Option<HoodieInstant> lastCompletedActionInstant, Function<String, T> instantTimeConsumingAction) {
+ if (isLockRequired()) {
+ acquireLock();
+ }
+ String requestedInstant = providedInstantTime.orElseGet(() -> HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L));
+ try {
+ if (lastCompletedActionInstant.isEmpty()) {
+ LOG.info("State change starting for {}", changeActionInstant);
+ } else {
+ LOG.info("State change starting for {} with latest completed action instant {}", changeActionInstant, lastCompletedActionInstant.get());
Review Comment:
makes no sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205160771
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.63492%` with `111 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 43.10%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [31 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (625a6b4). Click for more details.
>
> <details><summary>HEAD has 3 uploads less than BASE</summary>
>
>| Flag | BASE (0591933) | HEAD (625a6b4) |
>|------|------|------|
>|spark-java-tests|15|12|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.77% 43.10% -25.68%
+ Complexity 28117 18092 -10025
=============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
=============================================
- Hits 92869 58187 -34682
- Misses 34801 71668 +36867
+ Partials 7363 5146 -2217
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.75% <25.39%> (-20.68%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.10% <71.03%> (-0.31%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `35.62% <63.15%> (-13.24%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-45.51%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-38.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `92.23% <100.00%> (-3.18%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `76.52% <100.00%> (-3.29%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `87.50% <100.00%> (-1.79%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `51.68% <ø> (-10.12%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `73.63% <ø> (-2.04%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1146 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049203628
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/FlinkTables.java:
##########
@@ -53,7 +56,8 @@ public static HoodieFlinkTable<?> createTable(Configuration conf, RuntimeContext
HadoopFSUtils.getStorageConf(getHadoopConf(conf)),
new FlinkTaskContextSupplier(runtimeContext));
HoodieWriteConfig writeConfig = FlinkWriteClients.getHoodieClientConfig(conf, true);
Review Comment:
The caller always have a check for the presense of the txn manager now, should be safe to evolve, there are indeed cases that do not use the txn manager, I'm inclined we keep it as it is now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5262932915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
}, {
"hash" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"triggerType" : "PUSH"
}, {
"hash" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143",
"triggerID" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"triggerType" : "PUSH"
}, {
"hash" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6edf57b229f151125b65b1a517882e48d0cdf579 UNKNOWN
* 625a6b484d8569b976f8a75cba5b36695ccab7ce Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143)
* 293fe8129a6b1e331066d7ece71c04f281e68092 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5220073016
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.62434%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 504 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 71.42% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.77% -0.01%
- Complexity 28117 28138 +21
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 92841 -28
- Misses 34801 34810 +9
+ Partials 7363 7350 -13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <77.77%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.00% <100.00%> (-0.47%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (-0.09%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3037243002
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -62,7 +63,7 @@ public class CleanActionExecutor<T, I, K, O> extends BaseActionExecutor<T, I, K,
public CleanActionExecutor(HoodieEngineContext context, HoodieWriteConfig config, HoodieTable<T, I, K, O> table, String instantTime) {
super(context, config, table, instantTime);
- this.txnManager = new TransactionManager(config, table.getStorage());
+ this.txnManager = table.getTxnManager().get();
Review Comment:
🤖 Calling `.get()` on `table.getTxnManager()` is unsafe and will throw a `NoSuchElementException` if the table was instantiated without a `TransactionManager`. If we expect callers to always provide it, we should explicitly validate and throw a clear exception. Otherwise, we should fall back to creating one locally like the previous code.
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/transaction/TestTransactionManager.java:
##########
@@ -245,14 +231,19 @@ public void testTransactionsWithInstantTime() {
Assertions.assertFalse(transactionManager.getLastCompletedTransactionOwner().isPresent());
// 6. Transactions with no owners should also go through
- transactionManager.beginStateChange(Option.empty(), Option.empty());
+ transactionManager.beginStateChange();
Assertions.assertFalse(transactionManager.getCurrentTransactionOwner().isPresent());
Assertions.assertFalse(transactionManager.getLastCompletedTransactionOwner().isPresent());
- transactionManager.endStateChange(Option.empty());
+ transactionManager.endStateChange();
Assertions.assertFalse(transactionManager.getCurrentTransactionOwner().isPresent());
Assertions.assertFalse(transactionManager.getLastCompletedTransactionOwner().isPresent());
}
+ @Test
+ public void testGenerateInstantTimeFailsWithoutLock() {
+ assertThrows(HoodieLockException.class, () -> transactionManager.generateInstantTime());
Review Comment:
🤖 Could you also add a test case where Thread A acquires the lock and Thread B concurrently calls `generateInstantTime()`? Currently, `TransactionManager#generateInstantTime` checks `if (lockHolderId < 0)`, which means if Thread A holds the lock (`lockHolderId > 0`), Thread B will incorrectly bypass the check. The implementation should probably use `if (isLockRequired && !isLockHeldByCurrentThread())`.
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/compact/HoodieFlinkMergeOnReadTableCompactor.java:
##########
@@ -59,9 +59,8 @@ public void preCompact(
? instantGenerator.getCompactionInflightInstant(instantTime)
: instantGenerator.getLogCompactionInflightInstant(instantTime);
if (pendingCompactionTimeline.containsInstant(inflightInstant)) {
- try (TransactionManager transactionManager = new TransactionManager(table.getConfig(), table.getStorage())) {
- table.rollbackInflightCompaction(inflightInstant, transactionManager);
- }
+ TransactionManager transactionManager = (TransactionManager) table.getTxnManager().get();
Review Comment:
🤖 Could this throw a `NoSuchElementException` if the table was instantiated via `HoodieFlinkTable.create(config, context)`?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
+ return HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L);
+ }
+
+ /**
+ * Generates an instant time and executes an action that requires that instant time within a lock.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(Option.empty(), Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(providedInstantTime, Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param lastCompletedActionInstant optional input representing the last completed instant, used for logging purposes.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Option<HoodieInstant> lastCompletedActionInstant, Function<String, T> instantTimeConsumingAction) {
+ if (isLockRequired()) {
+ acquireLock();
+ }
+ String requestedInstant = providedInstantTime.orElseGet(() -> HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L));
+ try {
+ if (lastCompletedActionInstant.isEmpty()) {
+ LOG.info("State change starting for {}", changeActionInstant);
+ } else {
+ LOG.info("State change starting for {} with latest completed action instant {}", changeActionInstant, lastCompletedActionInstant.get());
+ }
+ return instantTimeConsumingAction.apply(requestedInstant);
+ } finally {
+ if (isLockRequired()) {
+ releaseLock();
+ LOG.info("State change ended for {}", requestedInstant);
+ }
+ }
+ }
+
+ public void beginStateChange() {
+ beginStateChange(Option.empty(), Option.empty());
}
public void beginStateChange(Option<HoodieInstant> changeActionInstant,
Option<HoodieInstant> lastCompletedActionInstant) {
if (isLockRequired) {
LOG.info("State change starting for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
- lockManager.lock();
+ acquireLock();
reset(this.changeActionInstant, changeActionInstant, lastCompletedActionInstant);
LOG.info("State change started for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
}
}
+ public void endStateChange() {
+ endStateChange(Option.empty());
+ }
+
public void endStateChange(Option<HoodieInstant> changeActionInstant) {
if (isLockRequired) {
LOG.info("State change ending for action instant {}", changeActionInstant);
if (reset(changeActionInstant, Option.empty(), Option.empty())) {
- lockManager.unlock();
+ releaseLock();
LOG.info("State change ended for action instant {}", changeActionInstant);
}
}
}
+ /**
+ * Caution: the {@code hasLock} flag can not be used to skip the `#lock` eagerly if the thread switches,
+ * the corner case below can cause deadlock:
+ *
+ * <pre>
+ * threadA => acquireLock(), {@code hasLock} setup as true and got the lock acquired;
+ * threadB => acquireLock(), check the {@code hasLock} as true, returns early;
+ * threadB => releaseLock(), set up the {@code hasLock} as false;
+ * threadA => releaseLock(), detect the {@code hasLock} as false and returns early.
+ *
+ * The lock held by threadA will never be released.
+ * </pre>
+ */
+ private void acquireLock() {
+ if (lockHolderId > 0 && isLockHeldByCurrentThread()) {
+ LOG.info("{}: Lock already acquired, skipping lock acquisition.", this);
+ permits++;
+ return;
+ }
+ lockManager.lock();
+ permits++;
+ this.lockHolderId = Thread.currentThread().getId();
+ LOG.info("{}: Lock acquired for action instant {}", this, changeActionInstant);
+ }
+
+ /**
+ * Caution: the `hasLock` flag can not be used to skip the `#unlock` eagerly if the thread switches.
+ * see the corner case of {@link #acquireLock()}.
+ */
+ private void releaseLock() {
+ if (isLockHeldByCurrentThread()) {
+ --permits;
+ if (permits == 0) {
+ lockManager.unlock();
+ this.lockHolderId = -1;
+ LOG.info("{}: Lock released for action instant {}", this, changeActionInstant);
+ }
Review Comment:
🤖 This introduces a race condition where a blocked thread can acquire the lock and overwrite `lockHolderId` before this thread resets it to `-1`.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java:
##########
@@ -231,10 +231,10 @@ protected void commit(HoodieWriteMetadata<O> result, List<HoodieWriteStat> write
writeTableMetadata(metadata, actionType);
// cannot serialize maps with null values
metadata.getExtraMetadata().entrySet().removeIf(entry -> entry.getValue() == null);
- activeTimeline.saveAsComplete(false,
- table.getMetaClient().createNewInstant(State.INFLIGHT, actionType, instantTime), Option.of(metadata),
+ activeTimeline.saveAsComplete(
+ table.getMetaClient().createNewInstant(State.INFLIGHT, actionType, instantTime), Option.of(metadata), txnManagerOption.get().generateInstantTime(),
Review Comment:
🤖 Unsafe unwrap. If `txnManagerOption` is empty (see previous comment in `completeCommit`), this will throw a `NoSuchElementException`.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseCommitActionExecutor.java:
##########
@@ -184,7 +184,7 @@ protected void runPrecommitValidators(HoodieWriteMetadata<O> writeMetadata) {
protected void completeCommit(HoodieWriteMetadata result) {
if (!this.txnManagerOption.isPresent()) {
- this.txnManagerOption = Option.of(new TransactionManager(config, table.getStorage()));
+ this.txnManagerOption = table.getTxnManager();
Review Comment:
🤖 If `table.getTxnManager()` is empty, this reassignment acts as a no-op and `this.txnManagerOption` will remain empty. We need to handle the absence of a transaction manager to prevent a `NoSuchElementException` down the line.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1747,22 +1745,25 @@ public void update(HoodieRestoreMetadata restoreMetadata, String instantTime) {
// We cannot create a deltaCommit at instantTime now because a future (rollback) block has already been written to the logFiles.
// We need to choose a timestamp which would be a validInstantTime for MDT. This is either a commit timestamp completed on the dataset
// or a new timestamp which we use for MDT clean, compaction etc.
- String syncCommitTime = createRestoreInstantTime();
- processAndCommit(syncCommitTime, () -> {
- // For Files partition.
- Map<String, HoodieData<HoodieRecord>> partitionRecords = new HashMap<>();
- partitionRecords.putAll(HoodieTableMetadataUtil.convertMissingPartitionRecords(engineContext,
- partitionsToDelete, partitionFilesToAdd, partitionFilesToDelete, syncCommitTime));
- // For ColumnStats partition if enabled.
- if (dataMetaClient.getTableConfig().getMetadataPartitions().contains(COLUMN_STATS.getPartitionPath())) {
- partitionRecords.putAll(convertToColumnStatsRecord(
- partitionFilesToAdd, partitionFilesToDelete, engineContext, dataMetaClient,
- dataWriteConfig.getMetadataConfig(), Option.of(dataWriteConfig.getRecordMerger().getRecordType()),
- dataWriteConfig.getMetadataConfig().getColumnStatsIndexParallelism()));
- }
- return partitionRecords;
+ writeClient.getTransactionManager().executeStateChangeWithInstant(metadataTableCommit -> {
+ String syncCommitTime = createRestoreTimestamp(metadataTableCommit);
+ processAndCommit(syncCommitTime, () -> {
+ // For Files partition.
+ Map<String, HoodieData<HoodieRecord>> partitionRecords = new HashMap<>();
+ partitionRecords.putAll(HoodieTableMetadataUtil.convertMissingPartitionRecords(engineContext,
+ partitionsToDelete, partitionFilesToAdd, partitionFilesToDelete, syncCommitTime));
+ // For ColumnStats partition if enabled.
+ if (dataMetaClient.getTableConfig().getMetadataPartitions().contains(COLUMN_STATS.getPartitionPath())) {
+ partitionRecords.putAll(convertToColumnStatsRecord(
+ partitionFilesToAdd, partitionFilesToDelete, engineContext, dataMetaClient,
+ dataWriteConfig.getMetadataConfig(), Option.of(dataWriteConfig.getRecordMerger().getRecordType()),
+ dataWriteConfig.getMetadataConfig().getColumnStatsIndexParallelism()));
+ }
+ return partitionRecords;
+ });
+ // empty result
+ return Option.empty();
Review Comment:
🤖 Removing `closeInternal()` here causes a resource leak of the metadata write client.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1044,18 +1040,17 @@ public String startDeletePartitionCommit(HoodieTableMetaClient metaClient) {
@VisibleForTesting
String startCommit(Option<String> providedInstantTime, String actionType, HoodieTableMetaClient metaClient) {
if (needsUpgrade(metaClient)) {
- // unclear what instant to use, since upgrade does have a given instant.
- executeUsingTxnManager(Option.empty(), () -> tryUpgrade(metaClient, Option.empty()));
+ txnManager.executeStateChangeWithInstant((ignored) -> {
+ // unclear what instant to use, since upgrade does have a given instant.
+ tryUpgrade(metaClient, Option.empty());
+ return null;
+ });
}
runPreWriteCleanerPolicy(metaClient);
CleanerUtils.rollbackFailedWrites(config.getFailedWritesCleanPolicy(),
HoodieTimeline.COMMIT_ACTION, () -> tableServiceClient.rollbackFailedWrites(metaClient));
- txnManager.beginStateChange(Option.empty(), lastCompletedTxnAndMetadata.map(Pair::getLeft));
- String instantTime;
- HoodieInstant instant = null;
- try {
- instantTime = providedInstantTime.orElseGet(() -> createNewInstantTime(false));
+ return txnManager.executeStateChangeWithInstant(providedInstantTime, lastCompletedTxnAndMetadata.map(Pair::getLeft), instantTime -> {
Review Comment:
🤖 We should reload the active timeline (`metaClient.reloadActiveTimeline()`) inside the lambda before checking for inflight restores. Otherwise, we might check a stale timeline state from before the lock was acquired, potentially missing a concurrent restore.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/restore/CopyOnWriteRestoreActionExecutor.java:
##########
@@ -47,17 +46,12 @@ protected HoodieRollbackMetadata rollbackInstant(HoodieInstant instantToRollback
&& !ClusteringUtils.isClusteringOrReplaceCommitAction(instantToRollback.getAction())) {
throw new HoodieRollbackException("Unsupported action in rollback instant:" + instantToRollback);
}
- String newInstantTime;
- try (TransactionManager transactionManager = new TransactionManager(config, table.getStorage())) {
+ TransactionManager transactionManager = table.getTxnManager().get();
Review Comment:
🤖 Another unsafe `.get()` unwrap here. Like the other executors, if `table.getTxnManager()` is empty, this will throw a `NoSuchElementException`.
##########
hudi-client/hudi-java-client/src/main/java/org/apache/hudi/table/action/compact/HoodieJavaMergeOnReadTableCompactor.java:
##########
@@ -49,9 +49,8 @@ public void preCompact(
}
HoodieInstant inflightInstant = table.getInstantGenerator().getCompactionInflightInstant(instantTime);
if (pendingCompactionTimeline.containsInstant(inflightInstant)) {
- try (TransactionManager transactionManager = new TransactionManager(table.getConfig(), table.getStorage())) {
- table.rollbackInflightCompaction(inflightInstant, transactionManager);
- }
+ TransactionManager transactionManager = (TransactionManager) table.getTxnManager().get();
Review Comment:
🤖 Calling `.get()` on the `Option` here will throw a raw `NoSuchElementException` if the table was created without a `TransactionManager` (e.g., via the convenience `HoodieJavaTable.create(config, context)`).
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
+ return HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L);
+ }
+
+ /**
+ * Generates an instant time and executes an action that requires that instant time within a lock.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(Option.empty(), Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(providedInstantTime, Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param lastCompletedActionInstant optional input representing the last completed instant, used for logging purposes.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Option<HoodieInstant> lastCompletedActionInstant, Function<String, T> instantTimeConsumingAction) {
+ if (isLockRequired()) {
+ acquireLock();
+ }
+ String requestedInstant = providedInstantTime.orElseGet(() -> HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L));
+ try {
+ if (lastCompletedActionInstant.isEmpty()) {
+ LOG.info("State change starting for {}", changeActionInstant);
+ } else {
+ LOG.info("State change starting for {} with latest completed action instant {}", changeActionInstant, lastCompletedActionInstant.get());
+ }
+ return instantTimeConsumingAction.apply(requestedInstant);
+ } finally {
+ if (isLockRequired()) {
+ releaseLock();
+ LOG.info("State change ended for {}", requestedInstant);
+ }
+ }
+ }
+
+ public void beginStateChange() {
+ beginStateChange(Option.empty(), Option.empty());
}
public void beginStateChange(Option<HoodieInstant> changeActionInstant,
Option<HoodieInstant> lastCompletedActionInstant) {
if (isLockRequired) {
LOG.info("State change starting for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
- lockManager.lock();
+ acquireLock();
reset(this.changeActionInstant, changeActionInstant, lastCompletedActionInstant);
LOG.info("State change started for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
}
}
+ public void endStateChange() {
+ endStateChange(Option.empty());
+ }
+
public void endStateChange(Option<HoodieInstant> changeActionInstant) {
if (isLockRequired) {
LOG.info("State change ending for action instant {}", changeActionInstant);
if (reset(changeActionInstant, Option.empty(), Option.empty())) {
- lockManager.unlock();
+ releaseLock();
LOG.info("State change ended for action instant {}", changeActionInstant);
}
}
}
+ /**
+ * Caution: the {@code hasLock} flag can not be used to skip the `#lock` eagerly if the thread switches,
+ * the corner case below can cause deadlock:
+ *
+ * <pre>
+ * threadA => acquireLock(), {@code hasLock} setup as true and got the lock acquired;
+ * threadB => acquireLock(), check the {@code hasLock} as true, returns early;
+ * threadB => releaseLock(), set up the {@code hasLock} as false;
+ * threadA => releaseLock(), detect the {@code hasLock} as false and returns early.
+ *
+ * The lock held by threadA will never be released.
+ * </pre>
+ */
+ private void acquireLock() {
+ if (lockHolderId > 0 && isLockHeldByCurrentThread()) {
+ LOG.info("{}: Lock already acquired, skipping lock acquisition.", this);
+ permits++;
+ return;
+ }
+ lockManager.lock();
+ permits++;
+ this.lockHolderId = Thread.currentThread().getId();
+ LOG.info("{}: Lock acquired for action instant {}", this, changeActionInstant);
Review Comment:
🤖 Using `permits++` here is vulnerable to memory visibility issues across threads if `lockManager` doesn't enforce JVM happen-before boundaries.
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/client/TestBaseHoodieTableServiceClient.java:
##########
@@ -282,4 +284,17 @@ protected void rollbackFailedWrites(Map<String, Option<HoodiePendingRollbackInfo
assertEquals(expectedRollbackInfo, instantsToRollback);
}
}
+
+ private TransactionManager createTransactionManager(List<String> instantTimes) {
+ try {
+ TimeGenerator timeGenerator = mock(TimeGenerator.class);
+ for (String instantTime : instantTimes) {
Review Comment:
🤖 This loop replaces previous Mockito stubbings, causing `generateTime()` to always return the parsed value of the last item in `instantTimes`.
##########
hudi-client/hudi-java-client/src/main/java/org/apache/hudi/table/upgrade/JavaUpgradeDowngradeHelper.java:
##########
@@ -45,7 +47,8 @@ public static JavaUpgradeDowngradeHelper getInstance() {
@Override
public HoodieTable getTable(HoodieWriteConfig config, HoodieEngineContext context) {
- return HoodieJavaTable.create(config, context);
+ TransactionManager txnManager = new TransactionManager(config, HoodieStorageUtils.getStorage(config.getBasePath(), context.getStorageConf()));
Review Comment:
🤖 Instantiating `TransactionManager` here without closing it creates a resource leak (e.g., Zookeeper connections, lock providers, metrics).
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
+ return HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L);
+ }
+
+ /**
+ * Generates an instant time and executes an action that requires that instant time within a lock.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(Option.empty(), Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(providedInstantTime, Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param lastCompletedActionInstant optional input representing the last completed instant, used for logging purposes.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Option<HoodieInstant> lastCompletedActionInstant, Function<String, T> instantTimeConsumingAction) {
+ if (isLockRequired()) {
+ acquireLock();
+ }
+ String requestedInstant = providedInstantTime.orElseGet(() -> HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L));
+ try {
+ if (lastCompletedActionInstant.isEmpty()) {
+ LOG.info("State change starting for {}", changeActionInstant);
+ } else {
+ LOG.info("State change starting for {} with latest completed action instant {}", changeActionInstant, lastCompletedActionInstant.get());
Review Comment:
🤖 `changeActionInstant` is never updated in this method, so this logs an empty or stale value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4149212801
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.77005%` with `42 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.40%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 23 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 97.87% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 68.40% -0.02%
- Complexity 27408 27418 +10
============================================
Files 2423 2422 -1
Lines 132458 132434 -24
Branches 15972 15971 -1
============================================
- Hits 90623 90587 -36
- Misses 34784 34800 +16
+ Partials 7051 7047 -4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <56.68%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.79% <77.51%> (-0.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <70.41%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.65% <52.52%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.19% <100.00%> (-0.49%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (+0.04%)` | :arrow_up: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049102999
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/compact/HoodieFlinkMergeOnReadTableCompactor.java:
##########
@@ -59,9 +59,8 @@ public void preCompact(
? instantGenerator.getCompactionInflightInstant(instantTime)
: instantGenerator.getLogCompactionInflightInstant(instantTime);
if (pendingCompactionTimeline.containsInstant(inflightInstant)) {
- try (TransactionManager transactionManager = new TransactionManager(table.getConfig(), table.getStorage())) {
- table.rollbackInflightCompaction(inflightInstant, transactionManager);
- }
+ TransactionManager transactionManager = (TransactionManager) table.getTxnManager().get();
Review Comment:
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205490898
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.30159%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.02%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.02% -0.76%
+ Complexity 28117 27772 -345
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 91828 -1041
- Misses 34801 35786 +985
- Partials 7363 7387 +24
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.67% <74.26%> (-3.20%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.31% <70.46%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `77.27% <100.00%> (-1.20%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `73.63% <ø> (-2.04%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `88.07% <100.00%> (-1.42%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [133 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205458040
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
}, {
"hash" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"triggerType" : "PUSH"
}, {
"hash" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143",
"triggerID" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6edf57b229f151125b65b1a517882e48d0cdf579 UNKNOWN
* 625a6b484d8569b976f8a75cba5b36695ccab7ce Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205591735
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.62434%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.76%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 71.42% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.76% -0.01%
- Complexity 28117 28137 +20
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 92839 -30
- Misses 34801 34812 +11
+ Partials 7363 7350 -13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <77.77%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.00% <100.00%> (-0.47%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (-0.09%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205386114
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.89947%` with `110 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.10%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [30 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (625a6b4). Click for more details.
>
> <details><summary>HEAD has 3 uploads less than BASE</summary>
>
>| Flag | BASE (0591933) | HEAD (625a6b4) |
>|------|------|------|
>|spark-java-tests|15|12|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.77% 46.10% -22.68%
+ Complexity 28117 19254 -8863
=============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
=============================================
- Hits 92869 62236 -30633
- Misses 34801 67261 +32460
+ Partials 7363 5504 -1859
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.75% <25.39%> (-20.68%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `35.62% <63.15%> (-13.24%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `30.87% <44.73%> (-14.63%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-38.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `92.23% <100.00%> (-3.18%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `76.52% <100.00%> (-3.29%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `73.63% <ø> (-2.04%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1065 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090657969
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.30178%` with `97 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.28%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 80.85% | [4 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 66.66% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [22 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (998e5a5). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (998e5a5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|utilities|1|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 45.28% -23.14%
+ Complexity 27408 15310 -12098
=============================================
Files 2423 1987 -436
Lines 132458 109960 -22498
Branches 15972 13863 -2109
=============================================
- Hits 90623 49793 -40830
- Misses 34784 54850 +20066
+ Partials 7051 5317 -1734
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <44.67%> (-12.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `88.57% <100.00%> (-6.93%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `28.16% <100.00%> (-51.65%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `27.27% <ø> (-48.41%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `86.20% <100.00%> (-3.45%)` | :arrow_down: |
| ... and [62 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1504 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090720712
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.43316%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 65.71%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [15 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 65.71% -2.71%
+ Complexity 27408 26309 -1099
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 87016 -3607
- Misses 34784 38153 +3369
- Partials 7051 7251 +200
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <61.24%> (-16.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.68% <70.71%> (-0.32%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.52%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `74.24% <100.00%> (-4.43%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `62.44% <100.00%> (-17.38%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `84.56% <100.00%> (-4.80%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [352 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090773733
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.70053%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.25%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 67.25% -1.17%
+ Complexity 27408 26979 -429
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 89060 -1563
- Misses 34784 36266 +1482
- Partials 7051 7094 +43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <73.66%> (-3.75%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <70.71%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.52%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `76.12% <100.00%> (-2.55%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `75.11% <100.00%> (-4.70%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.58% <100.00%> (-1.78%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [158 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090875485
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.03743%` with `41 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.09%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 97.87% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 68.09% -0.32%
+ Complexity 27408 27310 -98
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 90174 -449
- Misses 34784 35207 +423
+ Partials 7051 7039 -12
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.72% <77.81%> (-0.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <70.71%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.52%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `76.87% <100.00%> (-1.80%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.26% <100.00%> (-0.10%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [46 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4088944284
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.11989%` with `117 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.91%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 70.83% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [31 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 24 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-scala-tests|10|2|
>|utilities|1|0|
>|spark-java-tests|15|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 45.91% -22.50%
+ Complexity 27408 18272 -9136
=============================================
Files 2423 2376 -47
Lines 132458 127556 -4902
Branches 15972 14933 -1039
=============================================
- Hits 90623 58572 -32051
- Misses 34784 63712 +28928
+ Partials 7051 5272 -1779
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.29% <44.41%> (-11.72%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `59.15% <100.00%> (-20.66%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `42.72% <ø> (-32.95%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `86.20% <100.00%> (-3.45%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1090 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4088903462
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `67.84741%` with `118 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 38.72%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 70.83% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [32 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|utilities|1|0|
>|spark-java-tests|15|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 38.72% -29.69%
+ Complexity 27408 15709 -11699
=============================================
Files 2423 2359 -64
Lines 132458 125208 -7250
Branches 15972 14353 -1619
=============================================
- Hits 90623 48493 -42130
- Misses 34784 73020 +38236
+ Partials 7051 3695 -3356
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `59.15% <100.00%> (-20.66%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `51.68% <ø> (-10.12%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `18.18% <ø> (-57.50%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `86.20% <100.00%> (-3.45%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1242 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089036607
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `82.01635%` with `66 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.88%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [19 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 5 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|utilities|1|0|
>|spark-java-tests|15|11|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 54.88% -13.54%
+ Complexity 27408 22577 -4831
=============================================
Files 2423 2422 -1
Lines 132458 132414 -44
Branches 15972 15966 -6
=============================================
- Hits 90623 72676 -17947
- Misses 34784 53852 +19068
+ Partials 7051 5886 -1165
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.59% <79.15%> (-0.22%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.82% <71.29%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `75.93% <100.00%> (-2.74%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `78.87% <100.00%> (-0.94%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.91% <100.00%> (-1.44%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [576 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089116425
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `82.01635%` with `66 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.94%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [19 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 54.94% -13.47%
+ Complexity 27408 22602 -4806
=============================================
Files 2423 2422 -1
Lines 132458 132414 -44
Branches 15972 15966 -6
=============================================
- Hits 90623 72757 -17866
- Misses 34784 53755 +18971
+ Partials 7051 5902 -1149
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.76% <79.15%> (-0.06%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.82% <71.29%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-38.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `75.93% <100.00%> (-2.74%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `78.87% <100.00%> (-0.94%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.91% <100.00%> (-1.44%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [568 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089611536
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `63.81215%` with `131 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 42.13%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 61.53% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 70.83% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 70.58% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [38 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-scala-tests|10|1|
>|utilities|1|0|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 42.13% -26.28%
+ Complexity 27408 16248 -11160
=============================================
Files 2423 2359 -64
Lines 132458 125216 -7242
Branches 15972 14435 -1537
=============================================
- Hits 90623 52766 -37857
- Misses 34784 67323 +32539
+ Partials 7051 5127 -1924
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.45% <45.09%> (-11.56%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `78.09% <100.00%> (-17.41%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `56.80% <100.00%> (-23.01%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.00% <100.00%> (-14.29%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `42.72% <ø> (-32.95%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `65.73% <100.00%> (-20.19%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `79.31% <100.00%> (-10.35%)` | :arrow_down: |
| [...tion/restore/CopyOnWriteRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FCopyOnWriteRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0NvcHlPbldyaXRlUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `76.92% <100.00%> (-8.80%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1296 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089829582
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `79.83425%` with `73 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.87%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [22 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 12 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-scala-tests|10|8|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 55.87% -12.55%
+ Complexity 27408 22656 -4752
=============================================
Files 2423 2422 -1
Lines 132458 132408 -50
Branches 15972 15966 -6
=============================================
- Hits 90623 73981 -16642
- Misses 34784 52019 +17235
+ Partials 7051 6408 -643
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.53% <10.54%> (-26.78%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.98% <60.73%> (-6.84%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.67% <70.24%> (-0.34%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.92%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `83.80% <100.00%> (-11.69%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `71.61% <100.00%> (-7.06%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `74.17% <100.00%> (-5.64%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.59% <100.00%> (-13.70%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `59.09% <ø> (-16.59%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `86.24% <100.00%> (-3.12%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `69.93% <100.00%> (-15.99%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [698 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094588985
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.30178%` with `97 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.00%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 80.85% | [4 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 66.66% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [23 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (1ad2a5d). Click for more details.
>
> <details><summary>HEAD has 26 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (1ad2a5d) |
>|------|------|------|
>|spark-scala-tests|10|1|
>|utilities|1|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 47.00% -21.42%
+ Complexity 27408 14838 -12570
=============================================
Files 2423 1924 -499
Lines 132458 102636 -29822
Branches 15972 12275 -3697
=============================================
- Hits 90623 48244 -42379
- Misses 34784 49469 +14685
+ Partials 7051 4923 -2128
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.46% <44.67%> (-11.55%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `88.57% <100.00%> (-6.93%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `28.16% <100.00%> (-51.65%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `27.27% <ø> (-48.41%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `89.65% <100.00%> (ø)` | |
| ... and [62 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1554 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094579120
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `77.17042%` with `71 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.15%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 80.85% | [4 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 66.66% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [15 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (1ad2a5d). Click for more details.
>
> <details><summary>HEAD has 27 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (1ad2a5d) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|utilities|1|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 54.15% -14.27%
+ Complexity 27408 12141 -15267
=============================================
Files 2423 1416 -1007
Lines 132458 69689 -62769
Branches 15972 7770 -8202
=============================================
- Hits 90623 37741 -52882
+ Misses 34784 28589 -6195
+ Partials 7051 3359 -3692
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `87.61% <100.00%> (-7.88%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `28.16% <100.00%> (-51.65%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `51.68% <ø> (-10.12%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `0.00% <ø> (-75.68%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `89.65% <100.00%> (ø)` | |
| ... and [52 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1733 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core)!: centralize instant generation in TransactionManager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5265124935
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
}, {
"hash" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"triggerType" : "PUSH"
}, {
"hash" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143",
"triggerID" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"triggerType" : "PUSH"
}, {
"hash" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"triggerType" : "PUSH"
}, {
"hash" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16236",
"triggerID" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"triggerType" : "PUSH"
}, {
"hash" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16237",
"triggerID" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"triggerType" : "PUSH"
}, {
"hash" : "39e822973ae515ee45d3d98fc8368365e797b9bc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16240",
"triggerID" : "39e822973ae515ee45d3d98fc8368365e797b9bc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6edf57b229f151125b65b1a517882e48d0cdf579 UNKNOWN
* 293fe8129a6b1e331066d7ece71c04f281e68092 UNKNOWN
* f83553e65e47942f66b56ff5bae5131407fd8e26 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16237)
* 39e822973ae515ee45d3d98fc8368365e797b9bc Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16240)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4509614220
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.62434%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 159 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 71.42% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.77% -0.01%
- Complexity 28117 28138 +21
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 92841 -28
- Misses 34801 34810 +9
+ Partials 7363 7350 -13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <77.77%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.00% <100.00%> (-0.47%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (-0.09%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4508578695
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.62434%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 159 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 71.42% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.77% -0.01%
- Complexity 28117 28138 +21
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 92841 -28
- Misses 34801 34810 +9
+ Partials 7363 7350 -13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <77.77%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.00% <100.00%> (-0.47%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (-0.09%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089733053
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `73.75691%` with `95 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 49.88%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 65.38% | [8 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 42.85% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [27 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 49.88% -18.54%
+ Complexity 27408 20127 -7281
=============================================
Files 2423 2422 -1
Lines 132458 132408 -50
Branches 15972 15966 -6
=============================================
- Hits 90623 66049 -24574
- Misses 34784 60339 +25555
+ Partials 7051 6020 -1031
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.58% <60.73%> (-6.23%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <45.09%> (-12.20%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.92%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `81.90% <100.00%> (-13.60%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `65.97% <100.00%> (-12.70%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `74.17% <100.00%> (-5.64%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.00% <100.00%> (-14.29%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `45.45% <ø> (-30.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `85.57% <100.00%> (-3.79%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `67.13% <100.00%> (-18.79%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [952 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090060360
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `79.83425%` with `73 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 56.25%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [22 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 8 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-java-tests|15|7|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 56.25% -12.17%
+ Complexity 27408 22796 -4612
=============================================
Files 2423 2422 -1
Lines 132458 132408 -50
Branches 15972 15966 -6
=============================================
- Hits 90623 74481 -16142
- Misses 34784 51535 +16751
+ Partials 7051 6392 -659
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.53% <10.54%> (-26.78%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `43.09% <72.69%> (-5.73%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <70.24%> (-0.26%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.92%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `83.80% <100.00%> (-11.69%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `74.24% <100.00%> (-4.43%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `74.17% <100.00%> (-5.64%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.59% <100.00%> (-13.70%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `86.24% <100.00%> (-3.12%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `69.93% <100.00%> (-15.99%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [679 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090677046
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `81.81818%` with `68 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.83%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [19 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (998e5a5). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (998e5a5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|utilities|1|0|
>|spark-java-tests|15|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 58.83% -9.59%
+ Complexity 27408 23631 -3777
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 77908 -12715
- Misses 34784 47811 +13027
+ Partials 7051 6701 -350
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.11% <61.24%> (-15.71%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <44.67%> (-12.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `94.28% <100.00%> (-1.21%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `71.80% <100.00%> (-6.88%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `60.56% <100.00%> (-19.25%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `81.87% <100.00%> (-7.48%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [611 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094690095
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.77005%` with `42 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.40%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 97.87% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 68.40% -0.02%
- Complexity 27408 27418 +10
============================================
Files 2423 2422 -1
Lines 132458 132434 -24
Branches 15972 15971 -1
============================================
- Hits 90623 90587 -36
- Misses 34784 34800 +16
+ Partials 7051 7047 -4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <56.68%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.72% <77.51%> (-0.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <70.41%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.65% <52.52%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.19% <100.00%> (-0.49%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (+0.04%)` | :arrow_up: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094691098
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.77005%` with `42 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.40%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 97.87% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 68.40% -0.02%
- Complexity 27408 27418 +10
============================================
Files 2423 2422 -1
Lines 132458 132434 -24
Branches 15972 15971 -1
============================================
- Hits 90623 90587 -36
- Misses 34784 34800 +16
+ Partials 7051 7047 -4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <56.68%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.75% <77.51%> (-0.06%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <70.41%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.65% <52.52%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.19% <100.00%> (-0.49%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (+0.04%)` | :arrow_up: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4095127990
cc @vinothchandar for a final review. The first commit is a rebased one from the old PR with master, the following-up commits are incremental changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4088942826
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.11989%` with `117 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.45%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 70.83% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [31 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-scala-tests|10|1|
>|utilities|1|0|
>|spark-java-tests|15|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 45.45% -22.97%
+ Complexity 27408 18109 -9299
=============================================
Files 2423 2376 -47
Lines 132458 127542 -4916
Branches 15972 14851 -1121
=============================================
- Hits 90623 57971 -32652
- Misses 34784 64399 +29615
+ Partials 7051 5172 -1879
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.45% <44.41%> (-11.56%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `59.15% <100.00%> (-20.66%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `42.72% <ø> (-32.95%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `86.20% <100.00%> (-3.45%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1105 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089107484
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `82.01635%` with `66 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.94%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [19 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-java-tests|15|14|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 54.94% -13.48%
+ Complexity 27408 22602 -4806
=============================================
Files 2423 2422 -1
Lines 132458 132414 -44
Branches 15972 15966 -6
=============================================
- Hits 90623 72753 -17870
- Misses 34784 53757 +18973
+ Partials 7051 5904 -1147
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.75% <79.15%> (-0.07%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.82% <71.29%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-38.61%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `75.93% <100.00%> (-2.74%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `78.87% <100.00%> (-0.94%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.91% <100.00%> (-1.44%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [569 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3048998382
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -2171,30 +2172,32 @@ static HoodieActiveTimeline runPendingTableServicesOperationsAndRefreshTimeline(
* 2. In multi-writer scenario, a parallel operation with a greater instantTime may have completed creating a
* deltacommit.
*/
- void compactIfNecessary(BaseHoodieWriteClient<?,I,?,O> writeClient, Option<String> latestDeltaCommitTimeOpt) {
+ void compactIfNecessary(final BaseHoodieWriteClient<?,I,?,O> writeClient, Option<String> latestDeltaCommitTimeOpt) {
// IMPORTANT: Trigger compaction with max instant time that is smaller than(or equals) the earliest pending instant from DT.
// The compaction planner will manage to filter out the log files that finished with greater completion time.
Review Comment:
restrictedCompactionInstantTimeOpt is always present with the check `skipCompactions` as true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205457090
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.03704%` with `49 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 66.26%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [15 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 66.26% -2.51%
+ Complexity 28117 27022 -1095
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 89460 -3409
- Misses 34801 38155 +3354
- Partials 7363 7386 +23
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.29% <64.61%> (-10.58%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.92% <70.46%> (-0.58%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `75.63% <100.00%> (-2.84%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `77.46% <100.00%> (-2.35%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `73.63% <ø> (-2.04%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `85.09% <100.00%> (-4.40%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [329 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205497207
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.30159%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.14%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.14% -0.63%
+ Complexity 28117 27842 -275
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 92003 -866
- Misses 34801 35579 +778
- Partials 7363 7419 +56
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.73% <74.26%> (-3.14%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `77.27% <100.00%> (-1.20%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `73.63% <ø> (-2.04%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `88.07% <100.00%> (-1.42%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [117 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4204960856
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
}, {
"hash" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"triggerType" : "PUSH"
}, {
"hash" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7c0b4ccbb31148a172c028203680982b9511b9e6 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142)
* 6edf57b229f151125b65b1a517882e48d0cdf579 UNKNOWN
* 625a6b484d8569b976f8a75cba5b36695ccab7ce UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205423704
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `81.74603%` with `69 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 59.44%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [19 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 59.44% -9.33%
+ Complexity 28117 24274 -3843
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 80258 -12611
- Misses 34801 47951 +13150
+ Partials 7363 6792 -571
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.29% <64.61%> (-10.58%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.54% <44.73%> (-12.96%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-38.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `94.17% <100.00%> (-1.24%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `73.27% <100.00%> (-5.20%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `77.46% <100.00%> (-2.35%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `73.63% <ø> (-2.04%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `82.45% <100.00%> (-7.05%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [605 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049766933
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
+ return HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L);
+ }
+
+ /**
+ * Generates an instant time and executes an action that requires that instant time within a lock.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(Option.empty(), Option.empty(), instantTimeConsumingAction);
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205522324
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.62434%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.76%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 71.42% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.76% -0.02%
- Complexity 28117 28134 +17
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 92827 -42
- Misses 34801 34823 +22
+ Partials 7363 7351 -12
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.77% <77.77%> (-0.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.00% <100.00%> (-0.47%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (-0.09%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205382161
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.89947%` with `110 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.10%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [30 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (625a6b4). Click for more details.
>
> <details><summary>HEAD has 3 uploads less than BASE</summary>
>
>| Flag | BASE (0591933) | HEAD (625a6b4) |
>|------|------|------|
>|spark-java-tests|15|12|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.77% 46.10% -22.68%
+ Complexity 28117 19254 -8863
=============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
=============================================
- Hits 92869 62236 -30633
- Misses 34801 67261 +32460
+ Partials 7363 5504 -1859
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.75% <25.39%> (-20.68%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `35.62% <63.15%> (-13.24%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `30.87% <44.73%> (-14.63%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-38.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `92.23% <100.00%> (-3.18%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `76.52% <100.00%> (-3.29%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `73.63% <ø> (-2.04%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1065 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205603782
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.62434%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 71.42% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.77% -0.01%
- Complexity 28117 28138 +21
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 92841 -28
- Misses 34801 34810 +9
+ Partials 7363 7350 -13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <77.77%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.00% <100.00%> (-0.47%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (-0.09%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4288257339
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.62434%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.77%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 44 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 71.42% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.77% -0.01%
- Complexity 28117 28138 +21
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 92841 -28
- Misses 34801 34810 +9
+ Partials 7363 7350 -13
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.86% <77.77%> (-0.01%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.00% <100.00%> (-0.47%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (-0.09%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core)!: centralize instant generation in TransactionManager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5267098071
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
}, {
"hash" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"triggerType" : "PUSH"
}, {
"hash" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143",
"triggerID" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"triggerType" : "PUSH"
}, {
"hash" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"triggerType" : "PUSH"
}, {
"hash" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16236",
"triggerID" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"triggerType" : "PUSH"
}, {
"hash" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16237",
"triggerID" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"triggerType" : "PUSH"
}, {
"hash" : "39e822973ae515ee45d3d98fc8368365e797b9bc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16240",
"triggerID" : "39e822973ae515ee45d3d98fc8368365e797b9bc",
"triggerType" : "PUSH"
}, {
"hash" : "9cd1a5c573011a9c55189ce8f8417963bc49c588",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16245",
"triggerID" : "9cd1a5c573011a9c55189ce8f8417963bc49c588",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6edf57b229f151125b65b1a517882e48d0cdf579 UNKNOWN
* 293fe8129a6b1e331066d7ece71c04f281e68092 UNKNOWN
* 39e822973ae515ee45d3d98fc8368365e797b9bc Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16240)
* 9cd1a5c573011a9c55189ce8f8417963bc49c588 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16245)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core)!: centralize instant generation in TransactionManager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5263526055
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
}, {
"hash" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"triggerType" : "PUSH"
}, {
"hash" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143",
"triggerID" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"triggerType" : "PUSH"
}, {
"hash" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"triggerType" : "PUSH"
}, {
"hash" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16236",
"triggerID" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"triggerType" : "PUSH"
}, {
"hash" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6edf57b229f151125b65b1a517882e48d0cdf579 UNKNOWN
* 293fe8129a6b1e331066d7ece71c04f281e68092 UNKNOWN
* 8607225c07b146e2e4104a31942fc66bef2c529c Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16236)
* f83553e65e47942f66b56ff5bae5131407fd8e26 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3037211444
##########
hudi-common/src/main/java/org/apache/hudi/client/transaction/lock/InProcessLockProvider.java:
##########
@@ -38,14 +38,16 @@
import java.util.concurrent.locks.ReentrantReadWriteLock;
Review Comment:
🤖 nit: The updated Javadoc for `InProcessLockProvider` is much clearer about the design choice to disallow re-entrancy and its consistency with distributed locks. Good clarification.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstantTimeGenerator.java:
##########
@@ -68,15 +68,14 @@ public class HoodieInstantTimeGenerator {
* Returns next instant time in the correct format.
* Ensures each instant time is at least 1 millisecond apart since we create instant times at millisecond granularity.
*
- * @param shouldLock Whether the lock should be enabled to get the instant time.
* @param timeGenerator TimeGenerator used to generate the instant time.
* @param milliseconds Milliseconds to add to current time while generating the new instant time
*/
- public static String createNewInstantTime(boolean shouldLock, TimeGenerator timeGenerator, long milliseconds) {
+ public static String createNewInstantTime(TimeGenerator timeGenerator, long milliseconds) {
return LAST_INSTANT_TIME.updateAndGet((oldVal) -> {
String newCommitTime;
do {
- Date d = new Date(timeGenerator.generateTime(!shouldLock) + milliseconds);
+ Date d = new Date(timeGenerator.generateTime() + milliseconds);
Review Comment:
🤖 nit: Changing `ZoneId.systemDefault()` to `commitTimeZone.getZoneId()` is a good improvement for consistency and correctness, ensuring the configured time zone is always used.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -2171,30 +2172,32 @@ static HoodieActiveTimeline runPendingTableServicesOperationsAndRefreshTimeline(
* 2. In multi-writer scenario, a parallel operation with a greater instantTime may have completed creating a
* deltacommit.
*/
- void compactIfNecessary(BaseHoodieWriteClient<?,I,?,O> writeClient, Option<String> latestDeltaCommitTimeOpt) {
+ void compactIfNecessary(final BaseHoodieWriteClient<?,I,?,O> writeClient, Option<String> latestDeltaCommitTimeOpt) {
// IMPORTANT: Trigger compaction with max instant time that is smaller than(or equals) the earliest pending instant from DT.
// The compaction planner will manage to filter out the log files that finished with greater completion time.
// see BaseHoodieCompactionPlanGenerator.generateCompactionPlan for more details.
HoodieTimeline metadataCompletedTimeline = metadataMetaClient.getActiveTimeline().filterCompletedInstants();
- final String compactionInstantTime = dataMetaClient.reloadActiveTimeline()
+ final Option<String> restrictedCompactionInstantTimeOpt = dataMetaClient.reloadActiveTimeline()
// The filtering strategy is kept in line with the rollback premise, if an instant is pending on DT but completed on MDT,
// generates a compaction time smaller than it so that the instant could then been rolled back.
.filterInflightsAndRequested().filter(instant -> metadataCompletedTimeline.containsInstant(instant.requestedTime())).firstInstant()
// minus the pending instant time by 1 millisecond to avoid conflicts on the MDT.
- .map(instant -> HoodieInstantTimeGenerator.instantTimeMinusMillis(instant.requestedTime(), 1L))
- .orElse(writeClient.createNewInstantTime(false));
+ .map(instant -> HoodieInstantTimeGenerator.instantTimeMinusMillis(instant.requestedTime(), 1L));
// we need to avoid checking compaction w/ same instant again.
// let's say we trigger compaction after C5 in MDT and so compaction completes with C4001. but C5 crashed before completing in MDT.
// and again w/ C6, we will re-attempt compaction at which point latest delta commit is C4 in MDT.
// and so we try compaction w/ instant C4001. So, we can avoid compaction if we already have compaction w/ same instant time.
- boolean skipCompactions = metadataMetaClient.getActiveTimeline().filterCompletedInstants().containsInstant(compactionInstantTime);
+ boolean skipCompactions = restrictedCompactionInstantTimeOpt.map(
+ compactionInstantTime -> metadataMetaClient.getActiveTimeline().filterCompletedInstants().containsInstant(compactionInstantTime)).orElse(false);
try {
if (skipCompactions) {
- LOG.info("Compaction with same {} time is already present in the timeline.", compactionInstantTime);
- } else if (writeClient.scheduleCompactionAtInstant(compactionInstantTime, Option.empty())) {
- LOG.info("Compaction is scheduled for timestamp {}", compactionInstantTime);
- writeClient.compact(compactionInstantTime, true);
+ LOG.info("Compaction with same {} time is already present in the timeline.", restrictedCompactionInstantTimeOpt.get());
+ } else {
+ Option<String> scheduledInstantTimeOpt = scheduleCompaction(writeClient, restrictedCompactionInstantTimeOpt);
+ if (scheduledInstantTimeOpt.isPresent()) {
+ writeClient.compact(scheduledInstantTimeOpt.get(), true);
+ }
}
} catch (Exception e) {
metrics.ifPresent(m -> m.incrementMetric(HoodieMetadataMetrics.COMPACTION_FAILURES, 1));
Review Comment:
🤖 [Line 2205] nit: Similar to line 2177, `restrictedCompactionInstantTimeOpt.get()` is used here without an `isPresent()` check. A `NoSuchElementException` is possible if the `Option` is empty.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v2/TimelineArchiverV2.java:
##########
@@ -86,7 +86,7 @@ public TimelineArchiverV2(HoodieWriteConfig config, HoodieTable<T, I, K, O> tabl
this.config = config;
this.table = table;
this.metaClient = table.getMetaClient();
- this.txnManager = new TransactionManager(config, table.getStorage());
+ this.txnManager = table.getTxnManager().get();
Review Comment:
🤖 nit: Similar to `TimelineArchiverV1`, consider checking `table.getTxnManager().isPresent()` before calling `.get()` for robustness.
##########
hudi-common/src/main/java/org/apache/hudi/client/transaction/lock/InProcessLockProvider.java:
##########
Review Comment:
**Line 68:** 🤖 nit: Adding `// Disallow re-entrant behavior;` explicitly explains the design choice here, which is helpful.
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/functional/TestCleanActionExecutor.java:
##########
Review Comment:
**Line 184:** 🤖 nit: Using a method reference `cleanActionExecutor::execute` is a more concise and readable way to pass the executable to `assertThrows`.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v1/TimelineArchiverV1.java:
##########
@@ -104,7 +104,7 @@ public TimelineArchiverV1(HoodieWriteConfig config, HoodieTable<T, I, K, O> tabl
this.table = table;
this.metaClient = table.getMetaClient();
this.archiveFilePath = ArchivedTimelineV1.getArchiveLogPath(metaClient.getArchivePath());
- this.txnManager = new TransactionManager(config, table.getMetaClient().getStorage());
+ this.txnManager = table.getTxnManager().get();
Review Comment:
🤖 nit: It would be safer to check `table.getTxnManager().isPresent()` before calling `.get()` here, or handle the `Option` more gracefully, to avoid potential `NoSuchElementException`.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -226,11 +227,11 @@ private HoodieCleanMetadata runClean(HoodieTable<T, I, K, O> table, HoodieInstan
);
this.txnManager.beginStateChange(Option.of(inflightInstant), Option.empty());
writeTableMetadata(metadata, inflightInstant.requestedTime());
- table.getActiveTimeline().transitionCleanInflightToComplete(
- false,
- inflightInstant,
- Option.of(metadata),
- completedInstant -> table.getMetaClient().getTableFormat().clean(metadata, completedInstant, table.getContext(), table.getMetaClient(), table.getViewManager()));
+ TableFormatCompletionAction formatCompletionAction = completedInstant -> table.getMetaClient().getTableFormat()
+ .clean(metadata, completedInstant, table.getContext(), table.getMetaClient(), table.getViewManager());
+ HoodieInstant completedInstant = table.getActiveTimeline().transitionCleanInflightToComplete(inflightInstant, Option.of(metadata), txnManager.generateInstantTime());
+ // FIXME-vc: this is an one off..
Review Comment:
🤖 nit: This `// FIXME-vc:` comment indicates a known issue or temporary solution. Could you clarify its purpose or if it's meant to be addressed soon?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/restore/CopyOnWriteRestoreActionExecutor.java:
##########
@@ -47,17 +46,12 @@ protected HoodieRollbackMetadata rollbackInstant(HoodieInstant instantToRollback
&& !ClusteringUtils.isClusteringOrReplaceCommitAction(instantToRollback.getAction())) {
throw new HoodieRollbackException("Unsupported action in rollback instant:" + instantToRollback);
Review Comment:
🤖 nit: Prefer safer handling of `Option.get()` with `table.getTxnManager().get()` to avoid `NoSuchElementException`.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -2171,30 +2172,32 @@ static HoodieActiveTimeline runPendingTableServicesOperationsAndRefreshTimeline(
* 2. In multi-writer scenario, a parallel operation with a greater instantTime may have completed creating a
* deltacommit.
*/
- void compactIfNecessary(BaseHoodieWriteClient<?,I,?,O> writeClient, Option<String> latestDeltaCommitTimeOpt) {
+ void compactIfNecessary(final BaseHoodieWriteClient<?,I,?,O> writeClient, Option<String> latestDeltaCommitTimeOpt) {
// IMPORTANT: Trigger compaction with max instant time that is smaller than(or equals) the earliest pending instant from DT.
// The compaction planner will manage to filter out the log files that finished with greater completion time.
Review Comment:
🤖 nit: `restrictedCompactionInstantTimeOpt.get()` is used without an `isPresent()` check. This could lead to a `NoSuchElementException` if the `Option` is empty. Consider adding a check or using `orElse()`.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/index/RunIndexActionExecutor.java:
##########
@@ -96,7 +96,7 @@ public class RunIndexActionExecutor<T, I, K, O> extends BaseActionExecutor<T, I,
Review Comment:
🤖 nit: Same suggestion here regarding safer `Option.get()` usage.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/restore/BaseRestoreActionExecutor.java:
##########
@@ -143,19 +139,25 @@ private HoodieRestoreMetadata finishRestore(Map<String, List<HoodieRollbackMetad
table.getActiveTimeline().deletePending(instantGenerator.createNewInstant(HoodieInstant.State.INFLIGHT, HoodieTimeline.ROLLBACK_ACTION, entry.requestedTime()));
table.getActiveTimeline().deletePending(instantGenerator.createNewInstant(HoodieInstant.State.REQUESTED, HoodieTimeline.ROLLBACK_ACTION, entry.requestedTime()));
});
- log.info("Commits " + instantsRolledBack + " rollback is complete. Restored table to " + savepointToRestoreTimestamp);
+ log.info("Commits {} rollback is complete. Restored table to {}", instantsRolledBack, savepointToRestoreTimestamp);
return restoreMetadata;
}
/**
* Update metadata table if available. Any update to metadata table happens within data table lock.
+ * After metadata table is updated, the data table commit is marked as complete.
*
* @param restoreMetadata instance of {@link HoodieRestoreMetadata} to be applied to metadata.
+ * @param restoreInflightInstant the inflight instant to be saved as complete.
*/
- private void writeToMetadata(HoodieRestoreMetadata restoreMetadata, HoodieInstant restoreInflightInstant) {
+ private void writeToMetadataAndCompleteCommit(HoodieRestoreMetadata restoreMetadata, HoodieInstant restoreInflightInstant) {
Review Comment:
🤖 nit: This `// FIXME-vc:` comment also suggests an outstanding item. Could you provide more context or a plan for its resolution?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
+ return HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L);
+ }
+
+ /**
+ * Generates an instant time and executes an action that requires that instant time within a lock.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(Option.empty(), Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(providedInstantTime, Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param lastCompletedActionInstant optional input representing the last completed instant, used for logging purposes.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Option<HoodieInstant> lastCompletedActionInstant, Function<String, T> instantTimeConsumingAction) {
+ if (isLockRequired()) {
+ acquireLock();
+ }
+ String requestedInstant = providedInstantTime.orElseGet(() -> HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L));
+ try {
+ if (lastCompletedActionInstant.isEmpty()) {
+ LOG.info("State change starting for {}", changeActionInstant);
+ } else {
+ LOG.info("State change starting for {} with latest completed action instant {}", changeActionInstant, lastCompletedActionInstant.get());
+ }
+ return instantTimeConsumingAction.apply(requestedInstant);
+ } finally {
+ if (isLockRequired()) {
+ releaseLock();
+ LOG.info("State change ended for {}", requestedInstant);
+ }
+ }
+ }
+
+ public void beginStateChange() {
+ beginStateChange(Option.empty(), Option.empty());
}
public void beginStateChange(Option<HoodieInstant> changeActionInstant,
Option<HoodieInstant> lastCompletedActionInstant) {
if (isLockRequired) {
LOG.info("State change starting for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
- lockManager.lock();
+ acquireLock();
reset(this.changeActionInstant, changeActionInstant, lastCompletedActionInstant);
LOG.info("State change started for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
}
}
+ public void endStateChange() {
+ endStateChange(Option.empty());
+ }
+
Review Comment:
🤖 nit: There's a typo in this comment; `{ @.idea/codeStyles/codeStyleConfig.xml hasLock}` should be removed.
##########
hudi-common/src/main/java/org/apache/hudi/common/util/RetryHelper.java:
##########
@@ -98,7 +98,7 @@ public T start(CheckedFunction<T, R> func) throws R {
throw e;
Review Comment:
🤖 nit: Small grammar fix from 'retried' to 'retrying' makes the log message more natural.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/restore/MergeOnReadRestoreActionExecutor.java:
##########
@@ -51,17 +50,13 @@ protected HoodieRollbackMetadata rollbackInstant(HoodieInstant instantToRollback
default:
throw new IllegalArgumentException("invalid action name " + instantToRollback.getAction());
Review Comment:
🤖 nit: Again, for `table.getTxnManager().get()`, consider checking `isPresent()` first for safety.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackActionExecutor.java:
##########
@@ -95,7 +95,7 @@ public BaseRollbackActionExecutor(HoodieEngineContext context,
this.deleteInstants = deleteInstants;
Review Comment:
🤖 nit: Same suggestion for safer `Option.get()` usage here as well.
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/compact/HoodieFlinkMergeOnReadTableCompactor.java:
##########
@@ -59,9 +59,8 @@ public void preCompact(
? instantGenerator.getCompactionInflightInstant(instantTime)
Review Comment:
🤖 nit: Ensure `table.getTxnManager()` is present before calling `.get()`, or handle the empty case.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -202,7 +196,7 @@ protected HoodieTableMetaClient(HoodieStorage storage, String basePath, boolean
if (layoutVersion.isPresent() && tableConfigVersion.isPresent()) {
// Ensure layout version passed in config is not lower than the one seen in hoodie.properties
checkArgument(layoutVersion.get().compareTo(tableConfigVersion.get()) >= 0,
- "Layout Version defined in hoodie properties has higher version (" + tableConfigVersion.get()
+ () -> "Layout Version defined in hoodie properties has higher version (" + tableConfigVersion.get()
+ ") than the one passed in config (" + layoutVersion.get() + ")");
Review Comment:
🤖 nit: Using a lambda for assertion messages `() -> "..."` is a good practice as it defers string construction until the assertion actually fails, potentially improving performance slightly if the message is complex and the assertion rarely fails.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/FlinkTables.java:
##########
Review Comment:
**Line 37:** 🤖 nit: Using a ternary operator here makes the table creation logic more concise and readable.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
Review Comment:
**Line 62:** 🤖 nit: Similar to other instances, consider handling the `Option` from `table.getTxnManager()` more safely than directly calling `.get()`.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/restore/BaseRestoreActionExecutor.java:
##########
Review Comment:
**Line 61:** 🤖 nit: Consider adding `isPresent()` check for `table.getTxnManager()` before `.get()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205503863
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.30159%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.17%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.17% -0.61%
+ Complexity 28117 27849 -268
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 92034 -835
- Misses 34801 35548 +747
- Partials 7363 7419 +56
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.77% <74.26%> (-3.10%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `77.27% <100.00%> (-1.20%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `73.63% <ø> (-2.04%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `88.07% <100.00%> (-1.42%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [110 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4148636137
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.77005%` with `42 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.40%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 23 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 97.87% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 68.40% -0.02%
- Complexity 27408 27418 +10
============================================
Files 2423 2422 -1
Lines 132458 132434 -24
Branches 15972 15971 -1
============================================
- Hits 90623 90587 -36
- Misses 34784 34800 +16
+ Partials 7051 7047 -4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <56.68%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.79% <77.51%> (-0.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <70.41%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.65% <52.52%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.19% <100.00%> (-0.49%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (+0.04%)` | :arrow_up: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4150367468
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.77005%` with `42 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.40%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 23 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 97.87% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 68.40% -0.02%
- Complexity 27408 27418 +10
============================================
Files 2423 2422 -1
Lines 132458 132434 -24
Branches 15972 15971 -1
============================================
- Hits 90623 90587 -36
- Misses 34784 34800 +16
+ Partials 7051 7047 -4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <56.68%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.79% <77.51%> (-0.03%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <70.41%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.65% <52.52%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.19% <100.00%> (-0.49%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (+0.04%)` | :arrow_up: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [12 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049141156
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049229411
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
+ return HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L);
+ }
+
+ /**
+ * Generates an instant time and executes an action that requires that instant time within a lock.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(Option.empty(), Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(providedInstantTime, Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param lastCompletedActionInstant optional input representing the last completed instant, used for logging purposes.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Option<HoodieInstant> lastCompletedActionInstant, Function<String, T> instantTimeConsumingAction) {
+ if (isLockRequired()) {
+ acquireLock();
+ }
+ String requestedInstant = providedInstantTime.orElseGet(() -> HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L));
+ try {
+ if (lastCompletedActionInstant.isEmpty()) {
+ LOG.info("State change starting for {}", changeActionInstant);
+ } else {
+ LOG.info("State change starting for {} with latest completed action instant {}", changeActionInstant, lastCompletedActionInstant.get());
+ }
+ return instantTimeConsumingAction.apply(requestedInstant);
+ } finally {
+ if (isLockRequired()) {
+ releaseLock();
+ LOG.info("State change ended for {}", requestedInstant);
+ }
+ }
+ }
+
+ public void beginStateChange() {
+ beginStateChange(Option.empty(), Option.empty());
}
public void beginStateChange(Option<HoodieInstant> changeActionInstant,
Option<HoodieInstant> lastCompletedActionInstant) {
if (isLockRequired) {
LOG.info("State change starting for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
- lockManager.lock();
+ acquireLock();
reset(this.changeActionInstant, changeActionInstant, lastCompletedActionInstant);
LOG.info("State change started for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
}
}
+ public void endStateChange() {
+ endStateChange(Option.empty());
+ }
+
public void endStateChange(Option<HoodieInstant> changeActionInstant) {
if (isLockRequired) {
LOG.info("State change ending for action instant {}", changeActionInstant);
if (reset(changeActionInstant, Option.empty(), Option.empty())) {
- lockManager.unlock();
+ releaseLock();
LOG.info("State change ended for action instant {}", changeActionInstant);
}
}
}
+ /**
+ * Caution: the {@code hasLock} flag can not be used to skip the `#lock` eagerly if the thread switches,
+ * the corner case below can cause deadlock:
+ *
+ * <pre>
+ * threadA => acquireLock(), {@code hasLock} setup as true and got the lock acquired;
+ * threadB => acquireLock(), check the {@code hasLock} as true, returns early;
+ * threadB => releaseLock(), set up the {@code hasLock} as false;
+ * threadA => releaseLock(), detect the {@code hasLock} as false and returns early.
+ *
+ * The lock held by threadA will never be released.
+ * </pre>
+ */
+ private void acquireLock() {
+ if (lockHolderId > 0 && isLockHeldByCurrentThread()) {
+ LOG.info("{}: Lock already acquired, skipping lock acquisition.", this);
+ permits++;
+ return;
+ }
+ lockManager.lock();
+ permits++;
+ this.lockHolderId = Thread.currentThread().getId();
Review Comment:
yes, it is always unique within a JVM lifecycle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049218086
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/DirectMarkerTransactionManager.java:
##########
@@ -42,7 +42,7 @@ public class DirectMarkerTransactionManager extends TransactionManager {
private final String filePath;
public DirectMarkerTransactionManager(HoodieWriteConfig config, HoodieStorage storage, String partitionPath, String fileId) {
- super(new LockManager(config, storage, createUpdatedLockProps(config, partitionPath, fileId)), config.isLockRequired());
Review Comment:
yeah.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205492956
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.30159%` with `48 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.12%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.12% -0.66%
+ Complexity 28117 27835 -282
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 91964 -905
- Misses 34801 35606 +805
- Partials 7363 7431 +68
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.67% <74.26%> (-3.20%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.04%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `77.27% <100.00%> (-1.20%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `73.63% <ø> (-2.04%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `88.07% <100.00%> (-1.42%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [126 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205393345
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.89947%` with `110 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.31%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [30 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (625a6b4). Click for more details.
>
> <details><summary>HEAD has 3 uploads less than BASE</summary>
>
>| Flag | BASE (0591933) | HEAD (625a6b4) |
>|------|------|------|
>|spark-java-tests|15|12|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.77% 46.31% -22.47%
+ Complexity 28117 19377 -8740
=============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
=============================================
- Hits 92869 62522 -30347
- Misses 34801 66901 +32100
+ Partials 7363 5578 -1785
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.75% <25.39%> (-20.68%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `35.62% <63.15%> (-13.24%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `31.51% <44.73%> (-13.99%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-38.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `92.23% <100.00%> (-3.18%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `76.52% <100.00%> (-3.29%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `73.63% <ø> (-2.04%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1059 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205397714
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.95767%` with `106 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.42%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [28 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (625a6b4). Click for more details.
>
> <details><summary>HEAD has 2 uploads less than BASE</summary>
>
>| Flag | BASE (0591933) | HEAD (625a6b4) |
>|------|------|------|
>|spark-java-tests|15|13|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.77% 47.42% -21.36%
+ Complexity 28117 19797 -8320
=============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
=============================================
- Hits 92869 64023 -28846
- Misses 34801 65247 +30446
+ Partials 7363 5731 -1632
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.75% <25.39%> (-20.68%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.04% <64.61%> (-10.83%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.12% <44.73%> (-13.38%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-38.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `92.23% <100.00%> (-3.18%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.18% <100.00%> (-6.29%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `76.52% <100.00%> (-3.29%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `73.63% <ø> (-2.04%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1024 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205407301
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.95767%` with `106 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.44%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [28 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (625a6b4). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (0591933) | HEAD (625a6b4) |
>|------|------|------|
>|spark-java-tests|15|14|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.77% 47.44% -21.33%
+ Complexity 28117 19808 -8309
=============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
=============================================
- Hits 92869 64056 -28813
- Misses 34801 65217 +30416
+ Partials 7363 5728 -1635
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.75% <25.39%> (-20.68%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.12% <64.61%> (-10.75%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.12% <44.73%> (-13.38%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <0.00%> (-38.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `92.23% <100.00%> (-3.18%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.18% <100.00%> (-6.29%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `76.52% <100.00%> (-3.29%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `73.63% <ø> (-2.04%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1024 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4204833248
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `69.75089%` with `85 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 44.83%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`6edf57b`](https://app.codecov.io/gh/apache/hudi/commit/6edf57b229f151125b65b1a517882e48d0cdf579?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 73.46% | [7 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 61.53% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 60.86% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 70.58% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [18 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (6edf57b). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (0591933) | HEAD (6edf57b) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.77% 44.83% -23.94%
+ Complexity 28117 8476 -19641
=============================================
Files 2452 1195 -1257
Lines 135033 61841 -73192
Branches 16376 6657 -9719
=============================================
- Hits 92869 27728 -65141
+ Misses 34801 31085 -3716
+ Partials 7363 3028 -4335
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.83% <69.75%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `75.72% <100.00%> (-19.69%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `19.71% <100.00%> (-60.10%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `73.21% <100.00%> (-16.08%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `44.94% <ø> (-16.86%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `0.00% <ø> (-75.68%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `65.73% <100.00%> (-20.19%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `79.31% <100.00%> (-10.35%)` | :arrow_down: |
| [...tion/restore/CopyOnWriteRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FCopyOnWriteRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0NvcHlPbldyaXRlUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `76.92% <100.00%> (-8.80%)` | :arrow_down: |
| [...tion/restore/MergeOnReadRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FMergeOnReadRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL01lcmdlT25SZWFkUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.10%)` | :arrow_down: |
| ... and [43 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [2017 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4088950912
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.11989%` with `117 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.48%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 70.83% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [31 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|utilities|1|0|
>|spark-java-tests|15|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 45.48% -22.93%
+ Complexity 27408 18462 -8946
=============================================
Files 2423 2405 -18
Lines 132458 130110 -2348
Branches 15972 15476 -496
=============================================
- Hits 90623 59183 -31440
- Misses 34784 65500 +30716
+ Partials 7051 5427 -1624
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.07% <44.41%> (-11.93%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `59.15% <100.00%> (-20.66%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `42.72% <ø> (-32.95%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `86.20% <100.00%> (-3.45%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1073 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4088982686
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.66213%` with `104 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.07%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [28 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|utilities|1|0|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 47.07% -21.34%
+ Complexity 27408 19399 -8009
=============================================
Files 2423 2422 -1
Lines 132458 132414 -44
Branches 15972 15966 -6
=============================================
- Hits 90623 62336 -28287
- Misses 34784 64395 +29611
+ Partials 7051 5683 -1368
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <61.63%> (-16.14%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <44.41%> (-12.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `70.67% <100.00%> (-8.00%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `59.62% <100.00%> (-20.19%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1018 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089004502
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `77.38420%` with `83 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 52.13%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [24 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 14 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-scala-tests|10|7|
>|utilities|1|0|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 52.13% -16.29%
+ Complexity 27408 21397 -6011
=============================================
Files 2423 2422 -1
Lines 132458 132414 -44
Branches 15972 15966 -6
=============================================
- Hits 90623 69028 -21595
- Misses 34784 57252 +22468
+ Partials 7051 6134 -917
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.68% <61.63%> (-16.14%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.69% <71.29%> (-0.32%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.74% <100.00%> (-5.94%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `59.62% <100.00%> (-20.19%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `88.02% <100.00%> (ø)` | |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [849 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089020145
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `80.65395%` with `71 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.01%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [20 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 9 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|utilities|1|0|
>|spark-java-tests|15|7|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 54.01% -14.41%
+ Complexity 27408 22227 -5181
=============================================
Files 2423 2422 -1
Lines 132458 132414 -44
Branches 15972 15966 -6
=============================================
- Hits 90623 71525 -19098
- Misses 34784 54931 +20147
+ Partials 7051 5958 -1093
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <74.92%> (-3.83%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.82% <71.29%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `75.18% <100.00%> (-3.49%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `74.17% <100.00%> (-5.64%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `86.24% <100.00%> (-3.12%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [679 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089034603
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `80.65395%` with `71 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 54.03%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [20 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 6 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|utilities|1|0|
>|spark-java-tests|15|10|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 54.03% -14.38%
+ Complexity 27408 22233 -5175
=============================================
Files 2423 2422 -1
Lines 132458 132414 -44
Branches 15972 15966 -6
=============================================
- Hits 90623 71555 -19068
- Misses 34784 54906 +20122
+ Partials 7051 5953 -1098
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.05% <74.92%> (-3.77%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.82% <71.29%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `75.18% <100.00%> (-3.49%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `74.17% <100.00%> (-5.64%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `86.24% <100.00%> (-3.12%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [672 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089629973
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `63.81215%` with `131 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 41.54%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 61.53% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 70.83% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 70.58% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [38 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|utilities|1|0|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 41.54% -26.88%
+ Complexity 27408 16605 -10803
=============================================
Files 2423 2405 -18
Lines 132458 130074 -2384
Branches 15972 15468 -504
=============================================
- Hits 90623 54036 -36587
- Misses 34784 70646 +35862
+ Partials 7051 5392 -1659
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.08% <45.09%> (-11.93%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `78.09% <100.00%> (-17.41%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `56.80% <100.00%> (-23.01%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.00% <100.00%> (-14.29%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `42.72% <ø> (-32.95%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `65.73% <100.00%> (-20.19%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `79.31% <100.00%> (-10.35%)` | :arrow_down: |
| [...tion/restore/CopyOnWriteRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FCopyOnWriteRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0NvcHlPbldyaXRlUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `76.92% <100.00%> (-8.80%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1257 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089626671
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `63.81215%` with `131 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 41.88%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 61.53% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 70.83% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 70.58% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [38 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-scala-tests|10|2|
>|utilities|1|0|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 41.88% -26.54%
+ Complexity 27408 16415 -10993
=============================================
Files 2423 2376 -47
Lines 132458 127520 -4938
Branches 15972 14925 -1047
=============================================
- Hits 90623 53411 -37212
- Misses 34784 68871 +34087
+ Partials 7051 5238 -1813
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.28% <45.09%> (-11.73%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `78.09% <100.00%> (-17.41%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `56.80% <100.00%> (-23.01%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.00% <100.00%> (-14.29%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `42.72% <ø> (-32.95%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `65.73% <100.00%> (-20.19%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `79.31% <100.00%> (-10.35%)` | :arrow_down: |
| [...tion/restore/CopyOnWriteRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FCopyOnWriteRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0NvcHlPbldyaXRlUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `76.92% <100.00%> (-8.80%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1276 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089662383
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `68.78453%` with `113 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.52%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 61.53% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 70.58% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 42.85% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [33 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 21 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 46.52% -21.89%
+ Complexity 27408 18702 -8706
=============================================
Files 2423 2422 -1
Lines 132458 132408 -50
Branches 15972 15966 -6
=============================================
- Hits 90623 61609 -29014
- Misses 34784 64760 +29976
+ Partials 7051 6039 -1012
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <45.09%> (-12.20%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.92%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `81.90% <100.00%> (-13.60%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `62.59% <100.00%> (-16.09%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `59.15% <100.00%> (-20.66%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.00% <100.00%> (-14.29%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `45.45% <ø> (-30.23%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `67.13% <100.00%> (-18.79%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `80.28% <100.00%> (-7.75%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1103 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089730170
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `73.75691%` with `95 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 49.88%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 65.38% | [8 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 42.85% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [27 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 49.88% -18.54%
+ Complexity 27408 20127 -7281
=============================================
Files 2423 2422 -1
Lines 132458 132408 -50
Branches 15972 15966 -6
=============================================
- Hits 90623 66049 -24574
- Misses 34784 60339 +25555
+ Partials 7051 6020 -1031
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.58% <60.73%> (-6.23%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <45.09%> (-12.20%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.92%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `81.90% <100.00%> (-13.60%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `65.97% <100.00%> (-12.70%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `74.17% <100.00%> (-5.64%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.00% <100.00%> (-14.29%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `45.45% <ø> (-30.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `85.57% <100.00%> (-3.79%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `67.13% <100.00%> (-18.79%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [952 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090678294
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `81.81818%` with `68 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.83%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [19 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (998e5a5). Click for more details.
>
> <details><summary>HEAD has 18 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (998e5a5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|utilities|1|0|
>|spark-java-tests|15|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 58.83% -9.59%
+ Complexity 27408 23631 -3777
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 77908 -12715
- Misses 34784 47811 +13027
+ Partials 7051 6701 -350
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.11% <61.24%> (-15.71%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <44.67%> (-12.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `94.28% <100.00%> (-1.21%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `71.80% <100.00%> (-6.88%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `60.56% <100.00%> (-19.25%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `81.87% <100.00%> (-7.48%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [611 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090900218
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `89.03743%` with `41 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.12%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 97.87% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 68.12% -0.29%
+ Complexity 27408 27325 -83
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 90213 -410
- Misses 34784 35160 +376
+ Partials 7051 7047 -4
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.79% <77.81%> (-0.02%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <70.71%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.52%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `76.87% <100.00%> (-1.80%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.26% <100.00%> (-0.10%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [46 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094598748
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.30178%` with `97 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.97%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 80.85% | [4 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 66.66% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [23 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (1ad2a5d). Click for more details.
>
> <details><summary>HEAD has 23 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (1ad2a5d) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|utilities|1|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 45.97% -22.44%
+ Complexity 27408 15191 -12217
=============================================
Files 2423 1970 -453
Lines 132458 107640 -24818
Branches 15972 13369 -2603
=============================================
- Hits 90623 49491 -41132
- Misses 34784 52963 +18179
+ Partials 7051 5186 -1865
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.08% <44.67%> (-11.92%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `88.57% <100.00%> (-6.93%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `28.16% <100.00%> (-51.65%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `27.27% <ø> (-48.41%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `89.65% <100.00%> (ø)` | |
| ... and [62 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1509 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089833975
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `79.83425%` with `73 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.92%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [22 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 10 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 55.92% -12.49%
+ Complexity 27408 22681 -4727
=============================================
Files 2423 2422 -1
Lines 132458 132408 -50
Branches 15972 15966 -6
=============================================
- Hits 90623 74052 -16571
- Misses 34784 51943 +17159
+ Partials 7051 6413 -638
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.53% <10.54%> (-26.78%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.98% <60.73%> (-6.84%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.75% <70.24%> (-0.26%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.92%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `83.80% <100.00%> (-11.69%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `71.61% <100.00%> (-7.06%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `74.17% <100.00%> (-5.64%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.59% <100.00%> (-13.70%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `59.09% <ø> (-16.59%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `86.24% <100.00%> (-3.12%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `69.93% <100.00%> (-15.99%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [693 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094501560
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.28986%` with `82 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.12%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 72.34% | [7 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 57.69% | [10 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 62.50% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 70.58% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [18 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (1ad2a5d). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (1ad2a5d) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|utilities|1|0|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 45.12% -23.29%
+ Complexity 27408 8426 -18982
=============================================
Files 2423 1187 -1236
Lines 132458 60994 -71464
Branches 15972 6519 -9453
=============================================
- Hits 90623 27526 -63097
+ Misses 34784 30465 -4319
+ Partials 7051 3003 -4048
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `76.19% <100.00%> (-19.31%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `19.71% <100.00%> (-60.10%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `73.21% <100.00%> (-16.08%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `44.94% <ø> (-16.86%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `0.00% <ø> (-75.68%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `65.73% <100.00%> (-20.19%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `79.31% <100.00%> (-10.35%)` | :arrow_down: |
| [...tion/restore/CopyOnWriteRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FCopyOnWriteRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0NvcHlPbldyaXRlUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `76.92% <100.00%> (-8.80%)` | :arrow_down: |
| [...tion/restore/MergeOnReadRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FMergeOnReadRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL01lcmdlT25SZWFkUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.10%)` | :arrow_down: |
| ... and [43 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1986 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4099179409
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 93972a520d44e929fd3b2fe2c7a4bb5af902b92e Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702)
* 1ad2a5d9837981432070b0e91ed406e81c1e4c90 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4088803624
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `70.37037%` with `80 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 45.14%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 57.69% | [10 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 75.00% | [6 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 62.50% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 70.58% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [18 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-scala-tests|10|0|
>|utilities|1|0|
>|spark-client-hadoop-common|1|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 45.14% -23.27%
+ Complexity 27408 8432 -18976
=============================================
Files 2423 1187 -1236
Lines 132458 60974 -71484
Branches 15972 6517 -9455
=============================================
- Hits 90623 27529 -63094
+ Misses 34784 30450 -4334
+ Partials 7051 2995 -4056
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `19.71% <100.00%> (-60.10%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `73.21% <100.00%> (-16.08%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `44.94% <ø> (-16.86%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `0.00% <ø> (-75.68%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `65.73% <100.00%> (-20.19%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `79.31% <100.00%> (-10.35%)` | :arrow_down: |
| [...tion/restore/CopyOnWriteRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FCopyOnWriteRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0NvcHlPbldyaXRlUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `76.92% <100.00%> (-8.80%)` | :arrow_down: |
| [...tion/restore/MergeOnReadRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FMergeOnReadRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL01lcmdlT25SZWFkUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.10%)` | :arrow_down: |
| [...le/action/rollback/BaseRollbackActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frollback%2FBaseRollbackActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yb2xsYmFjay9CYXNlUm9sbGJhY2tBY3Rpb25FeGVjdXRvci5qYXZh) | `59.57% <100.00%> (-21.99%)` | :arrow_down: |
| ... and [43 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1985 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090696758
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `81.81818%` with `68 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 61.18%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [19 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (998e5a5). Click for more details.
>
> <details><summary>HEAD has 16 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (998e5a5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|spark-java-tests|15|4|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 61.18% -7.23%
+ Complexity 27408 24530 -2878
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 81025 -9598
- Misses 34784 44550 +9766
+ Partials 7051 6845 -206
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.67% <61.24%> (-16.15%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <44.67%> (-12.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.52%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `94.28% <100.00%> (-1.21%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `72.36% <100.00%> (-6.31%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `62.44% <100.00%> (-17.38%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `83.22% <100.00%> (-6.14%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [509 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant t… [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4088963998
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.66213%` with `104 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 47.01%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`93972a5`](https://app.codecov.io/gh/apache/hudi/commit/93972a520d44e929fd3b2fe2c7a4bb5af902b92e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 33.33% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [28 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (93972a5). Click for more details.
>
> <details><summary>HEAD has 19 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (93972a5) |
>|------|------|------|
>|spark-scala-tests|10|5|
>|utilities|1|0|
>|spark-java-tests|15|2|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 47.01% -21.41%
+ Complexity 27408 19373 -8035
=============================================
Files 2423 2422 -1
Lines 132458 132414 -44
Branches 15972 15966 -6
=============================================
- Hits 90623 62255 -28368
- Misses 34784 64465 +29681
+ Partials 7051 5694 -1357
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <23.70%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.14% <70.37%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.99% <71.42%> (-0.32%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.50% <61.63%> (-15.31%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `32.80% <44.41%> (-12.21%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `70.67% <100.00%> (-8.00%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `59.62% <100.00%> (-20.19%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1019 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094657080
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.43316%` with `47 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.59%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [15 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 67.59% -0.82%
+ Complexity 27408 27104 -304
============================================
Files 2423 2422 -1
Lines 132458 132434 -24
Branches 15972 15971 -1
============================================
- Hits 90623 89524 -1099
- Misses 34784 35807 +1023
- Partials 7051 7103 +52
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.32% <56.68%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.13% <73.37%> (-3.69%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.99% <70.41%> (-0.02%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.65% <52.52%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `77.44% <100.00%> (-1.24%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `75.11% <100.00%> (-4.70%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.74% <100.00%> (-1.61%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [117 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4089793128
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `79.83425%` with `73 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.84%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e80126f`](https://app.codecov.io/gh/apache/hudi/commit/e80126f867a5fd2e7b0c58625a8e338ea2907911?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...n/java/org/apache/hudi/table/HoodieFlinkTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieFlinkTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllRmxpbmtUYWJsZS5qYXZh) | 30.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 73.07% | [6 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rc/main/java/org/apache/hudi/util/FlinkTables.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FFlinkTables.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9GbGlua1RhYmxlcy5qYXZh) | 0.00% | [7 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/hudi/client/HoodieFlinkWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FHoodieFlinkWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L0hvb2RpZUZsaW5rV3JpdGVDbGllbnQuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/hudi/util/CompactionUtil.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-flink-datasource%2Fhudi-flink%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Futil%2FCompactionUtil.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1mbGluay1kYXRhc291cmNlL2h1ZGktZmxpbmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbC9Db21wYWN0aW9uVXRpbC5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [22 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (e80126f). Click for more details.
>
> <details><summary>HEAD has 13 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (e80126f) |
>|------|------|------|
>|spark-scala-tests|10|7|
>|spark-java-tests|15|5|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 55.84% -12.58%
+ Complexity 27408 22650 -4758
=============================================
Files 2423 2422 -1
Lines 132458 132408 -50
Branches 15972 15966 -6
=============================================
- Hits 90623 73942 -16681
- Misses 34784 52036 +17252
+ Partials 7051 6430 -621
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.64% <22.65%> (-20.71%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.07% <71.69%> (-0.09%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `21.53% <10.54%> (-26.78%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.98% <60.73%> (-6.84%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.61% <70.24%> (-0.40%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.92%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `83.80% <100.00%> (-11.69%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `71.61% <100.00%> (-7.06%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `74.17% <100.00%> (-5.64%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `75.59% <100.00%> (-13.70%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `55.05% <ø> (-6.75%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `59.09% <ø> (-16.59%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `86.24% <100.00%> (-3.12%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `69.93% <100.00%> (-15.99%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [715 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090762001
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.70053%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.23%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 67.23% -1.19%
+ Complexity 27408 26972 -436
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 89033 -1590
- Misses 34784 36293 +1509
- Partials 7051 7094 +43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.04% <73.66%> (-3.78%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <70.71%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.52%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `76.12% <100.00%> (-2.55%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `75.11% <100.00%> (-4.70%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.58% <100.00%> (-1.78%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [163 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090763317
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.70053%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.23%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 67.23% -1.19%
+ Complexity 27408 26972 -436
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 89033 -1590
- Misses 34784 36293 +1509
- Partials 7051 7094 +43
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.04% <73.66%> (-3.78%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.81% <70.71%> (-0.19%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.52%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `76.12% <100.00%> (-2.55%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `75.11% <100.00%> (-4.70%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.58% <100.00%> (-1.78%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [163 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4090751647
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `87.70053%` with `46 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.16%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`998e5a5`](https://app.codecov.io/gh/apache/hudi/commit/998e5a51472423f18510147eff5344c33f3ed62d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 76.92% | [5 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [14 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.41% 67.16% -1.25%
+ Complexity 27408 26950 -458
============================================
Files 2423 2422 -1
Lines 132458 132420 -38
Branches 15972 15967 -5
============================================
- Hits 90623 88944 -1679
- Misses 34784 36361 +1577
- Partials 7051 7115 +64
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.31% <56.68%> (-0.04%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.15% <70.03%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.98% <70.73%> (-0.33%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.03% <73.66%> (-3.79%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.68% <70.71%> (-0.32%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.21% <52.52%> (-0.40%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.23% <100.00%> (-0.26%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `76.12% <100.00%> (-2.55%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `75.11% <100.00%> (-4.70%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `85.71% <100.00%> (-3.58%)` | :arrow_down: |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `62.72% <ø> (-12.95%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `87.58% <100.00%> (-1.78%)` | :arrow_down: |
| ... and [77 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [187 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094600491
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.44379%` with `83 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.86%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 80.85% | [4 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rg/apache/hudi/table/upgrade/UpgradeDowngrade.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FUpgradeDowngrade.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvVXBncmFkZURvd25ncmFkZS5qYXZh) | 40.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 57.14% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [20 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (1ad2a5d). Click for more details.
>
> <details><summary>HEAD has 22 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (1ad2a5d) |
>|------|------|------|
>|spark-scala-tests|10|4|
>|utilities|1|0|
>|spark-java-tests|15|1|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 48.86% -19.56%
+ Complexity 27408 16092 -11316
=============================================
Files 2423 1970 -453
Lines 132458 107640 -24818
Branches 15972 13369 -2603
=============================================
- Hits 90623 52594 -38029
- Misses 34784 49645 +14861
+ Partials 7051 5401 -1650
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.90% <61.24%> (-14.92%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.08% <44.67%> (-11.92%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `92.38% <100.00%> (-3.12%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `28.63% <100.00%> (-51.18%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `56.36% <ø> (-19.32%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `61.90% <100.00%> (-10.89%)` | :arrow_down: |
| ... and [62 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1460 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4094594987
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `71.30178%` with `97 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.45%. Comparing base ([`cad08b1`](https://app.codecov.io/gh/apache/hudi/commit/cad08b1f2cfd637db050d37dee8fd9efddd5fc6a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1ad2a5d`](https://app.codecov.io/gh/apache/hudi/commit/1ad2a5d9837981432070b0e91ed406e81c1e4c90?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 0.00% | [17 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 80.85% | [4 Missing and 5 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 66.66% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 69.23% | [7 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/action/commit/BaseSparkCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-spark-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseSparkCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1zcGFyay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbW1pdC9CYXNlU3BhcmtDb21taXRBY3Rpb25FeGVjdXRvci5qYXZh) | 0.00% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 76.47% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [23 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (cad08b1) and HEAD (1ad2a5d). Click for more details.
>
> <details><summary>HEAD has 25 uploads less than BASE</summary>
>
>| Flag | BASE (cad08b1) | HEAD (1ad2a5d) |
>|------|------|------|
>|spark-scala-tests|10|2|
>|utilities|1|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.41% 46.45% -21.96%
+ Complexity 27408 15030 -12378
=============================================
Files 2423 1953 -470
Lines 132458 105190 -27268
Branches 15972 12819 -3153
=============================================
- Hits 90623 48870 -41753
- Misses 34784 51242 +16458
+ Partials 7051 5078 -1973
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.12% <70.28%> (-0.04%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.27% <70.73%> (-0.04%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `33.25% <44.67%> (-11.76%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `88.57% <100.00%> (-6.93%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `28.16% <100.00%> (-51.65%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `27.27% <ø> (-48.41%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.31%)` | :arrow_down: |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.50% <100.00%> (-3.53%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `89.65% <100.00%> (ø)` | |
| ... and [62 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [1538 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049177164
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackActionExecutor.java:
##########
@@ -266,7 +266,7 @@ protected List<HoodieRollbackStat> executeRollback(HoodieInstant instantToRollba
}
protected void finishRollback(HoodieInstant inflightInstant, HoodieRollbackMetadata rollbackMetadata) throws HoodieIOException {
- boolean enableLocking = (!skipLocking && !skipTimelinePublish);
+ boolean enableLocking = (!skipLocking || !skipTimelinePublish);
Review Comment:
it's a bug gix, the follwing-up upsert into MDT needs a lock anyway when `!skipTimelinePublish` is true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205529844
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `88.62434%` with `43 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 68.76%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 80.76% | [4 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/compact/HoodieJavaMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-java-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieJavaMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaHVkaS90YWJsZS9hY3Rpb24vY29tcGFjdC9Ib29kaWVKYXZhTWVyZ2VPblJlYWRUYWJsZUNvbXBhY3Rvci5qYXZh) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../scala/org/apache/hudi/IncrementalRelationV1.scala](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark-common%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Fhudi%2FIncrementalRelationV1.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvaHVkaS9JbmNyZW1lbnRhbFJlbGF0aW9uVjEuc2NhbGE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...java/org/apache/hudi/cli/ArchiveExecutorUtils.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-spark-datasource%2Fhudi-spark%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FArchiveExecutorUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1zcGFyay1kYXRhc291cmNlL2h1ZGktc3Bhcmsvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0FyY2hpdmVFeGVjdXRvclV0aWxzLmphdmE=) | 82.35% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/java/org/apache/hudi/cli/commands/SparkMain.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2Fcommands%2FSparkMain.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL2NvbW1hbmRzL1NwYXJrTWFpbi5qYXZh) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../compact/HoodieFlinkMergeOnReadTableCompactor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-flink-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcompact%2FHoodieFlinkMergeOnReadTableCompactor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1mbGluay1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvYWN0aW9uL2NvbXBhY3QvSG9vZGllRmxpbmtNZXJnZU9uUmVhZFRhYmxlQ29tcGFjdG9yLmphdmE=) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 71.42% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [13 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
============================================
- Coverage 68.77% 68.76% -0.01%
- Complexity 28117 28135 +18
============================================
Files 2452 2451 -1
Lines 135033 135001 -32
Branches 16376 16373 -3
============================================
- Hits 92869 92835 -34
- Misses 34801 34815 +14
+ Partials 7363 7351 -12
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.40% <56.61%> (-0.03%)` | :arrow_down: |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.37% <71.03%> (-0.03%)` | :arrow_down: |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.80% <77.77%> (-0.06%)` | :arrow_down: |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `45.47% <70.46%> (-0.03%)` | :arrow_down: |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `38.18% <52.78%> (-0.04%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...i/src/main/java/org/apache/hudi/cli/HoodieCLI.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-cli%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcli%2FHoodieCLI.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpL0hvb2RpZUNMSS5qYXZh) | `0.00% <ø> (ø)` | |
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `95.14% <100.00%> (-0.27%)` | :arrow_down: |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | `78.00% <100.00%> (-0.47%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `79.81% <100.00%> (ø)` | |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `89.28% <100.00%> (ø)` | |
| [...nt/transaction/DirectMarkerTransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FDirectMarkerTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9EaXJlY3RNYXJrZXJUcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | `71.42% <100.00%> (ø)` | |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `61.79% <ø> (ø)` | |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `75.45% <ø> (-0.23%)` | :arrow_down: |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | `89.40% <100.00%> (-0.09%)` | :arrow_down: |
| ... and [76 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [14 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on code in PR #18350:
URL: https://github.com/apache/hudi/pull/18350#discussion_r3049237175
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -41,40 +46,166 @@ public class TransactionManager implements Serializable, AutoCloseable {
protected final LockManager lockManager;
@Getter
protected final boolean isLockRequired;
+ private final transient TimeGenerator timeGenerator;
+ private volatile long lockHolderId; // lock holder ID
+ private int permits; // allows for nested transaction
protected Option<HoodieInstant> changeActionInstant = Option.empty();
private Option<HoodieInstant> lastCompletedActionInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, storage), config.isLockRequired());
+ this(config, new LockManager(config, storage));
}
- protected TransactionManager(LockManager lockManager, boolean isLockRequired) {
+ protected TransactionManager(HoodieWriteConfig writeConfig, LockManager lockManager) {
+ this(lockManager, writeConfig.isLockRequired(), TimeGenerators.getTimeGenerator(writeConfig.getTimeGeneratorConfig()));
+ }
+
+ public TransactionManager(LockManager lockManager, boolean isLockRequired, TimeGenerator timeGenerator) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
+ this.timeGenerator = timeGenerator;
+ this.lockHolderId = -1;
+ this.permits = 0;
+ }
+
+ /**
+ * Caution: the invoker needs to ensure that API called within a lock context.
+ */
+ public String generateInstantTime() {
+ if (lockHolderId < 0 && isLockRequired) {
+ throw new HoodieLockException("Cannot create instant without acquiring a lock first.");
+ }
+ return HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L);
+ }
+
+ /**
+ * Generates an instant time and executes an action that requires that instant time within a lock.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(Option.empty(), Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Function<String, T> instantTimeConsumingAction) {
+ return executeStateChangeWithInstant(providedInstantTime, Option.empty(), instantTimeConsumingAction);
+ }
+
+ /**
+ * Uses the provided instant if present or else generates an instant time and executes an action that requires that instant time within a lock.
+ * @param providedInstantTime an optional instant time provided by the caller. If not provided, a new instant time will be generated.
+ * @param lastCompletedActionInstant optional input representing the last completed instant, used for logging purposes.
+ * @param instantTimeConsumingAction a function that takes the generated instant time and performs some action
+ * @return the result of the action
+ * @param <T> type of the result
+ */
+ public <T> T executeStateChangeWithInstant(Option<String> providedInstantTime, Option<HoodieInstant> lastCompletedActionInstant, Function<String, T> instantTimeConsumingAction) {
+ if (isLockRequired()) {
+ acquireLock();
+ }
+ String requestedInstant = providedInstantTime.orElseGet(() -> HoodieInstantTimeGenerator.createNewInstantTime(timeGenerator, 0L));
+ try {
+ if (lastCompletedActionInstant.isEmpty()) {
+ LOG.info("State change starting for {}", changeActionInstant);
+ } else {
+ LOG.info("State change starting for {} with latest completed action instant {}", changeActionInstant, lastCompletedActionInstant.get());
+ }
+ return instantTimeConsumingAction.apply(requestedInstant);
+ } finally {
+ if (isLockRequired()) {
+ releaseLock();
+ LOG.info("State change ended for {}", requestedInstant);
+ }
+ }
+ }
+
+ public void beginStateChange() {
+ beginStateChange(Option.empty(), Option.empty());
}
public void beginStateChange(Option<HoodieInstant> changeActionInstant,
Option<HoodieInstant> lastCompletedActionInstant) {
if (isLockRequired) {
LOG.info("State change starting for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
- lockManager.lock();
+ acquireLock();
reset(this.changeActionInstant, changeActionInstant, lastCompletedActionInstant);
LOG.info("State change started for {} with latest completed action instant {}",
changeActionInstant, lastCompletedActionInstant);
}
}
+ public void endStateChange() {
+ endStateChange(Option.empty());
+ }
+
public void endStateChange(Option<HoodieInstant> changeActionInstant) {
if (isLockRequired) {
LOG.info("State change ending for action instant {}", changeActionInstant);
if (reset(changeActionInstant, Option.empty(), Option.empty())) {
- lockManager.unlock();
+ releaseLock();
LOG.info("State change ended for action instant {}", changeActionInstant);
}
}
}
+ /**
+ * Caution: the {@code hasLock} flag can not be used to skip the `#lock` eagerly if the thread switches,
+ * the corner case below can cause deadlock:
+ *
+ * <pre>
+ * threadA => acquireLock(), {@code hasLock} setup as true and got the lock acquired;
+ * threadB => acquireLock(), check the {@code hasLock} as true, returns early;
+ * threadB => releaseLock(), set up the {@code hasLock} as false;
+ * threadA => releaseLock(), detect the {@code hasLock} as false and returns early.
+ *
+ * The lock held by threadA will never be released.
+ * </pre>
+ */
+ private void acquireLock() {
+ if (lockHolderId > 0 && isLockHeldByCurrentThread()) {
+ LOG.info("{}: Lock already acquired, skipping lock acquisition.", this);
+ permits++;
+ return;
+ }
+ lockManager.lock();
+ permits++;
Review Comment:
> are you trying to hand implement sth like a semaphore
exactly.
> Can we think through this from both angles..
for 1: the reentrancy is only allowed from the same thread, so the table service running in a different thread would be blocked if the lock is required already. And within the same thread, the action guard by the lock happens in sequence.
for 2: no reentrancy is there so we are fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Provide new TransactionManager functionality and move instant time management to Transactionmanager [hudi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-4205030594
## [Codecov](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `69.75089%` with `85 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 44.85%. Comparing base ([`0591933`](https://app.codecov.io/gh/apache/hudi/commit/0591933bc237ab9adb616f6961bbd780deff25a2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`625a6b4`](https://app.codecov.io/gh/apache/hudi/commit/625a6b484d8569b976f8a75cba5b36695ccab7ce?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...he/hudi/client/transaction/TransactionManager.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2FTransactionManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9UcmFuc2FjdGlvbk1hbmFnZXIuamF2YQ==) | 73.46% | [7 Missing and 6 partials :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v2/ActiveTimelineV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv2%2FActiveTimelineV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjIvQWN0aXZlVGltZWxpbmVWMi5qYXZh) | 61.53% | [9 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../org/apache/hudi/client/BaseHoodieWriteClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieWriteClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllV3JpdGVDbGllbnQuamF2YQ==) | 60.86% | [9 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...c/main/java/org/apache/hudi/table/HoodieTable.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2FHoodieTable.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL0hvb2RpZVRhYmxlLmphdmE=) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/hudi/client/BaseHoodieTableServiceClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieTableServiceClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllVGFibGVTZXJ2aWNlQ2xpZW50LmphdmE=) | 70.58% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...table/timeline/versioning/v1/ActiveTimelineV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fcommon%2Ftable%2Ftimeline%2Fversioning%2Fv1%2FActiveTimelineV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL3ZlcnNpb25pbmcvdjEvQWN0aXZlVGltZWxpbmVWMS5qYXZh) | 28.57% | [5 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../table/action/commit/BaseCommitActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fcommit%2FBaseCommitActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jb21taXQvQmFzZUNvbW1pdEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...e/hudi/table/upgrade/FourToFiveUpgradeHandler.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Fupgrade%2FFourToFiveUpgradeHandler.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL3VwZ3JhZGUvRm91clRvRml2ZVVwZ3JhZGVIYW5kbGVyLmphdmE=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...hudi/metadata/HoodieBackedTableMetadataWriter.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriter.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXIuamF2YQ==) | 91.42% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...udi/table/action/index/RunIndexActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Findex%2FRunIndexActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9pbmRleC9SdW5JbmRleEFjdGlvbkV4ZWN1dG9yLmphdmE=) | 0.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [18 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
> :exclamation: There is a different number of reports uploaded between BASE (0591933) and HEAD (625a6b4). Click for more details.
>
> <details><summary>HEAD has 28 uploads less than BASE</summary>
>
>| Flag | BASE (0591933) | HEAD (625a6b4) |
>|------|------|------|
>|spark-client-hadoop-common|1|0|
>|spark-scala-tests|10|0|
>|spark-java-tests|15|0|
>|common-and-other-modules|1|0|
>|utilities|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #18350 +/- ##
=============================================
- Coverage 68.77% 44.85% -23.92%
+ Complexity 28117 8483 -19634
=============================================
Files 2452 1195 -1257
Lines 135033 61841 -73192
Branches 16376 6657 -9719
=============================================
- Hits 92869 27741 -65128
+ Misses 34801 31077 -3724
+ Partials 7363 3023 -4340
```
| [Flag](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [common-and-other-modules](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [hadoop-mr-java-client](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `44.85% <69.75%> (-0.02%)` | :arrow_down: |
| [spark-client-hadoop-common](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-java-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [spark-scala-tests](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [utilities](https://app.codecov.io/gh/apache/hudi/pull/18350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files with missing lines](https://app.codecov.io/gh/apache/hudi/pull/18350?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../java/org/apache/hudi/client/BaseHoodieClient.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2FBaseHoodieClient.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC9CYXNlSG9vZGllQ2xpZW50LmphdmE=) | `75.72% <100.00%> (-19.69%)` | :arrow_down: |
| [...ent/timeline/versioning/v1/TimelineArchiverV1.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv1%2FTimelineArchiverV1.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YxL1RpbWVsaW5lQXJjaGl2ZXJWMS5qYXZh) | `19.71% <100.00%> (-60.10%)` | :arrow_down: |
| [...ent/timeline/versioning/v2/TimelineArchiverV2.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftimeline%2Fversioning%2Fv2%2FTimelineArchiverV2.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90aW1lbGluZS92ZXJzaW9uaW5nL3YyL1RpbWVsaW5lQXJjaGl2ZXJWMi5qYXZh) | `73.21% <100.00%> (-16.08%)` | :arrow_down: |
| [.../transaction/lock/FileSystemBasedLockProvider.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FFileSystemBasedLockProvider.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0ZpbGVTeXN0ZW1CYXNlZExvY2tQcm92aWRlci5qYXZh) | `44.94% <ø> (-16.86%)` | :arrow_down: |
| [.../apache/hudi/client/transaction/lock/LockInfo.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fclient%2Ftransaction%2Flock%2FLockInfo.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL2NsaWVudC90cmFuc2FjdGlvbi9sb2NrL0xvY2tJbmZvLmphdmE=) | `12.50% <ø> (ø)` | |
| [...oodieBackedTableMetadataWriterTableVersionSix.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Fmetadata%2FHoodieBackedTableMetadataWriterTableVersionSix.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL21ldGFkYXRhL0hvb2RpZUJhY2tlZFRhYmxlTWV0YWRhdGFXcml0ZXJUYWJsZVZlcnNpb25TaXguamF2YQ==) | `0.00% <ø> (-75.68%)` | :arrow_down: |
| [...e/hudi/table/action/clean/CleanActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Fclean%2FCleanActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9jbGVhbi9DbGVhbkFjdGlvbkV4ZWN1dG9yLmphdmE=) | `65.73% <100.00%> (-20.19%)` | :arrow_down: |
| [...able/action/restore/BaseRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FBaseRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0Jhc2VSZXN0b3JlQWN0aW9uRXhlY3V0b3IuamF2YQ==) | `79.31% <100.00%> (-10.35%)` | :arrow_down: |
| [...tion/restore/CopyOnWriteRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FCopyOnWriteRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL0NvcHlPbldyaXRlUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `76.92% <100.00%> (-8.80%)` | :arrow_down: |
| [...tion/restore/MergeOnReadRestoreActionExecutor.java](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree&filepath=hudi-client%2Fhudi-client-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhudi%2Ftable%2Faction%2Frestore%2FMergeOnReadRestoreActionExecutor.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aHVkaS1jbGllbnQvaHVkaS1jbGllbnQtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RhYmxlL2FjdGlvbi9yZXN0b3JlL01lcmdlT25SZWFkUmVzdG9yZUFjdGlvbkV4ZWN1dG9yLmphdmE=) | `84.61% <100.00%> (-1.10%)` | :arrow_down: |
| ... and [43 more](https://app.codecov.io/gh/apache/hudi/pull/18350?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [2015 files with indirect coverage changes](https://app.codecov.io/gh/apache/hudi/pull/18350/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core)!: centralize instant generation in TransactionManager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5263780819
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
}, {
"hash" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"triggerType" : "PUSH"
}, {
"hash" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143",
"triggerID" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"triggerType" : "PUSH"
}, {
"hash" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"triggerType" : "PUSH"
}, {
"hash" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16236",
"triggerID" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"triggerType" : "PUSH"
}, {
"hash" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16237",
"triggerID" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6edf57b229f151125b65b1a517882e48d0cdf579 UNKNOWN
* 293fe8129a6b1e331066d7ece71c04f281e68092 UNKNOWN
* 8607225c07b146e2e4104a31942fc66bef2c529c Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16236)
* f83553e65e47942f66b56ff5bae5131407fd8e26 Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16237)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core)!: centralize instant generation in TransactionManager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5263247815
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
}, {
"hash" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"triggerType" : "PUSH"
}, {
"hash" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143",
"triggerID" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"triggerType" : "PUSH"
}, {
"hash" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"triggerType" : "PUSH"
}, {
"hash" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16236",
"triggerID" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6edf57b229f151125b65b1a517882e48d0cdf579 UNKNOWN
* 625a6b484d8569b976f8a75cba5b36695ccab7ce Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143)
* 293fe8129a6b1e331066d7ece71c04f281e68092 UNKNOWN
* 8607225c07b146e2e4104a31942fc66bef2c529c Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16236)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core)!: centralize instant generation in TransactionManager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5263383203
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
}, {
"hash" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"triggerType" : "PUSH"
}, {
"hash" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143",
"triggerID" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"triggerType" : "PUSH"
}, {
"hash" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"triggerType" : "PUSH"
}, {
"hash" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16236",
"triggerID" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"triggerType" : "PUSH"
}, {
"hash" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6edf57b229f151125b65b1a517882e48d0cdf579 UNKNOWN
* 625a6b484d8569b976f8a75cba5b36695ccab7ce Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143)
* 293fe8129a6b1e331066d7ece71c04f281e68092 UNKNOWN
* 8607225c07b146e2e4104a31942fc66bef2c529c Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16236)
* f83553e65e47942f66b56ff5bae5131407fd8e26 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core)!: centralize instant generation in TransactionManager [hudi]
Posted by "vinothchandar (via GitHub)" <gi...@apache.org>.
vinothchandar commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5295945149
Based on your last comment @danny0405 - are we abandoning this approach then? its unclear if you feel confident with the PR to be safe for production. or you feel there are caveats
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core)!: centralize instant generation in TransactionManager [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5274123433
> Whats the current state here? CI is green I guess.
>
> do we have any pending open items that are looking risky. (e.g deadlocks, reentrancy).
I removed the reentrancy: https://github.com/apache/hudi/pull/18350#discussion_r3766272833, the current per thread reentrency is not robust enough for distributed lock using for Hudi since the reentrency state is hard to maintain as correct in corner cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(core)!: centralize instant generation in TransactionManager [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #18350:
URL: https://github.com/apache/hudi/pull/18350#issuecomment-5267357183
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12702",
"triggerID" : "93972a520d44e929fd3b2fe2c7a4bb5af902b92e",
"triggerType" : "PUSH"
}, {
"hash" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=12733",
"triggerID" : "1ad2a5d9837981432070b0e91ed406e81c1e4c90",
"triggerType" : "PUSH"
}, {
"hash" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13142",
"triggerID" : "7c0b4ccbb31148a172c028203680982b9511b9e6",
"triggerType" : "PUSH"
}, {
"hash" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6edf57b229f151125b65b1a517882e48d0cdf579",
"triggerType" : "PUSH"
}, {
"hash" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=13143",
"triggerID" : "625a6b484d8569b976f8a75cba5b36695ccab7ce",
"triggerType" : "PUSH"
}, {
"hash" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "293fe8129a6b1e331066d7ece71c04f281e68092",
"triggerType" : "PUSH"
}, {
"hash" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16236",
"triggerID" : "8607225c07b146e2e4104a31942fc66bef2c529c",
"triggerType" : "PUSH"
}, {
"hash" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16237",
"triggerID" : "f83553e65e47942f66b56ff5bae5131407fd8e26",
"triggerType" : "PUSH"
}, {
"hash" : "39e822973ae515ee45d3d98fc8368365e797b9bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16240",
"triggerID" : "39e822973ae515ee45d3d98fc8368365e797b9bc",
"triggerType" : "PUSH"
}, {
"hash" : "9cd1a5c573011a9c55189ce8f8417963bc49c588",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16245",
"triggerID" : "9cd1a5c573011a9c55189ce8f8417963bc49c588",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6edf57b229f151125b65b1a517882e48d0cdf579 UNKNOWN
* 293fe8129a6b1e331066d7ece71c04f281e68092 UNKNOWN
* 9cd1a5c573011a9c55189ce8f8417963bc49c588 Azure: [FAILURE](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=16245)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org