You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/06 11:48:47 UTC
[GitHub] [arrow-rs] roee88 opened a new issue #671: Make rand an optional dependency
roee88 opened a new issue #671:
URL: https://github.com/apache/arrow-rs/issues/671
Following https://github.com/apache/arrow-rs/pull/488 arrow-rs compiles to wasm32-unknown-unknowm only with the "js" feature of rand enabled. However, when the "js" feature is enabled the produced wasm modules are no longer stand alone and require JavaScript, which is not necessarily available. For example, these modules can't run in runtimes like wasmer (in contrast to modules compiled to wasm32-unknown-unknowm with arrow-rs 4.x).
**Describe the solution you'd like**
Make rand an optional dependency so we can opt out. In arrow2 this is already the case (and at least there rand is only used in benchmarks).
**Describe alternatives you've considered**
If it's only use for benchmarks and testing in arrow-rs too then make it an optional dependency that is only enabled when feature flags for benchmarks are set (if that exists already).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on issue #671: Make rand an optional dependency
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #671:
URL: https://github.com/apache/arrow-rs/issues/671#issuecomment-894649168
sounds like a good idea to me -- @roee88 do you plan to work on this one or would you like help?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb closed issue #671: Make rand an optional dependency
Posted by GitBox <gi...@apache.org>.
alamb closed issue #671:
URL: https://github.com/apache/arrow-rs/issues/671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org