[GitHub] [flink] slinkydeveloper commented on a change in pull request #18524: [FLINK-25428][table-common][table-planner] Expose string casting for map, multiset, structured, row and raw

[GitBox <gi...@apache.org>]

slinkydeveloper commented on a change in pull request #18524:
URL: https://github.com/apache/flink/pull/18524#discussion_r810884028



##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeCasts.java
##########
@@ -318,11 +318,17 @@ private static boolean supportsCasting(
             // cast between interval and exact numeric is only supported if interval has a single
             // field
             return isSingleFieldInterval(targetType);
+        } else if ((sourceType.is(CONSTRUCTED) || sourceType.is(STRUCTURED_TYPE))
+                && targetType.is(CHARACTER_STRING)) {
+            return supportsCollectionAndStructuredToStringCasting(sourceType, allowExplicit);

Review comment:
       We don't have any at the moment, at least looking at the matrix I wrote here https://github.com/apache/flink/pull/18813. Nevertheless, isn't it better to keep this code to avoid eventual future bugs with new types?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org