You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/18 14:09:37 UTC

[GitHub] [cloudstack] Spaceman1984 opened a new pull request #4272: Fixed rolling restart on VPC network

Spaceman1984 opened a new pull request #4272:
URL: https://github.com/apache/cloudstack/pull/4272


   ## Description
   This PR fixes the problem where restarting a network with cleanup within a VPC destroys the VR first before creating a new one.
   <!--- Describe your changes in detail -->
   Fixes:  #3815 
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   This has been tested by restarting the VPC network with cleanup and observing the behavior on the Virtual Routers page.
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4272: Fixed rolling restart on VPC network

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4272:
URL: https://github.com/apache/cloudstack/pull/4272#issuecomment-677509913


   @rhtyd I tested a rolling restart of the VPC with and without cleanup, single tier, deleting the VR, and then restarting the VPC without cleanup.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4272: Fixed rolling restart on VPC network

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4272:
URL: https://github.com/apache/cloudstack/pull/4272#issuecomment-675910648


   rekicked test manually


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4272: Fixed rolling restart on VPC network

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4272:
URL: https://github.com/apache/cloudstack/pull/4272#issuecomment-675524297


   Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1780


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #4272: Fixed rolling restart on VPC network

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4272:
URL: https://github.com/apache/cloudstack/pull/4272#issuecomment-679925743


   LGTM, merging based on manual tests and Travis


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4272: Fixed rolling restart on VPC network

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4272:
URL: https://github.com/apache/cloudstack/pull/4272#issuecomment-675525527


   @Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4272: Fixed rolling restart on VPC network

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4272:
URL: https://github.com/apache/cloudstack/pull/4272#issuecomment-675501224


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #4272: Fixed rolling restart on VPC network

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4272:
URL: https://github.com/apache/cloudstack/pull/4272


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4272: Fixed rolling restart on VPC network

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #4272:
URL: https://github.com/apache/cloudstack/pull/4272#issuecomment-675525181


   @blueorangutan test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #4272: Fixed rolling restart on VPC network

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4272:
URL: https://github.com/apache/cloudstack/pull/4272#issuecomment-675501980


   @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org