You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/09/01 10:01:01 UTC
[GitHub] [zeppelin] Reamer opened a new pull request, #4455: [ZEPPELIN-5810] Allow both package names jupyter_client and jupyter-client
Reamer opened a new pull request, #4455:
URL: https://github.com/apache/zeppelin/pull/4455
### What is this PR for?
This pull request changes the Python dependency check minimally to get high flexibility for the package check.
### What type of PR is it?
- Bug Fix
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-5810
### How should this be tested?
* CI
### Questions:
* Does the licenses files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4455: [ZEPPELIN-5810] Allow both package names jupyter_client and jupyter-client
Posted by GitBox <gi...@apache.org>.
Reamer commented on PR #4455:
URL: https://github.com/apache/zeppelin/pull/4455#issuecomment-1239443337
Yes you are probably right. I wrote this bugfix without rebuilding the existing verification to fix the bug quickly.
If you want to rewrite the part, feel free to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer merged pull request #4455: [ZEPPELIN-5810] Allow both package names jupyter_client and jupyter-client
Posted by GitBox <gi...@apache.org>.
Reamer merged PR #4455:
URL: https://github.com/apache/zeppelin/pull/4455
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] ebuildy commented on pull request #4455: [ZEPPELIN-5810] Allow both package names jupyter_client and jupyter-client
Posted by GitBox <gi...@apache.org>.
ebuildy commented on PR #4455:
URL: https://github.com/apache/zeppelin/pull/4455#issuecomment-1235688109
This kind of code, very related to the environnement, should be moved from java to a shell or python script.
So this make easy to override and maitain it without recompiling all the java stuff.
Or a new setting for disable it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] zjffdu commented on a diff in pull request #4455: [ZEPPELIN-5810] Allow both package names jupyter_client and jupyter-client
Posted by GitBox <gi...@apache.org>.
zjffdu commented on code in PR #4455:
URL: https://github.com/apache/zeppelin/pull/4455#discussion_r964932667
##########
zeppelin-jupyter-interpreter/src/main/java/org/apache/zeppelin/jupyter/PythonPackagePredicate.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zeppelin.jupyter;
+
+import java.util.function.Predicate;
+
+public class PythonPackagePredicate<T> implements Predicate<T> {
Review Comment:
T is always String?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zeppelin] Reamer commented on a diff in pull request #4455: [ZEPPELIN-5810] Allow both package names jupyter_client and jupyter-client
Posted by GitBox <gi...@apache.org>.
Reamer commented on code in PR #4455:
URL: https://github.com/apache/zeppelin/pull/4455#discussion_r965550469
##########
zeppelin-jupyter-interpreter/src/main/java/org/apache/zeppelin/jupyter/PythonPackagePredicate.java:
##########
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zeppelin.jupyter;
+
+import java.util.function.Predicate;
+
+public class PythonPackagePredicate<T> implements Predicate<T> {
Review Comment:
For the moment, yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org