You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/10/15 11:02:12 UTC
[GitHub] [carbondata] nihal0107 opened a new pull request #3985: [WIP]Fixed float variable to take 4 bytes in case of adaptive encoding
nihal0107 opened a new pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985
### Why is this PR needed?
Currently, float variables are using long value 8 bytes to store float data.
### What changes were proposed in this PR?
Handled the float variables to take 4 bytes to store float data.
### Does this PR introduce any user interface change?
- No
- Yes. (please explain the change and update document)
### Is any new testcase added?
- No
- Yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-711567187
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-710085979
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4490/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-709897532
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-711465736
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 removed a comment on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
nihal0107 removed a comment on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-709897532
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-711693802
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2751/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-710015410
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4485/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3985: [WIP]Fixed float variable to take 4 bytes in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-709204135
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2709/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-709745588
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-709694022
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2714/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-709896788
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2726/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on a change in pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#discussion_r506065671
##########
File path: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/PrimitivePageStatsCollector.java
##########
@@ -256,7 +256,7 @@ private int getDecimalCount(double value) {
}
private int getDecimalCount(float value) {
- return getDecimalCount((double) value);
+ return getDecimalCount(Double.parseDouble(Float.toString(value)));
Review comment:
In `AdaptiveDeltaFloatingCodec.java` line please remove line 323 to 328. As this code is added as a cover up to this issue.
```
} else if (pageDataType == DataTypes.LONG) {
int size = pageSize * longSizeInBytes;
for (int i = 0; i < size; i += longSizeInBytes) {
vector.putDouble(rowId++, (max - ByteUtil.toLongLittleEndian(pageData, i)) / factor);
}
}
```
Similarly in `AdaptiveFloatingCodec` 309 to 313
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-710024408
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-710001432
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2731/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-711690989
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4505/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-711515303
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2746/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3985: [WIP]Fixed float variable to take 4 bytes in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-709317970
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4464/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-710113383
Build Failed with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2736/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on a change in pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on a change in pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#discussion_r506066673
##########
File path: core/src/main/java/org/apache/carbondata/core/datastore/page/statistics/PrimitivePageStatsCollector.java
##########
@@ -256,7 +256,7 @@ private int getDecimalCount(double value) {
}
private int getDecimalCount(float value) {
- return getDecimalCount((double) value);
+ return getDecimalCount(Double.parseDouble(Float.toString(value)));
Review comment:
removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] asfgit closed pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-709688032
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4468/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] ajantha-bhat commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-711712512
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] ajantha-bhat commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-709810787
LGTM.
Can merge once the build is passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3985: [WIP]Fixed float variable to take 4 bytes in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-709323198
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/2710/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
nihal0107 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-709957980
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-711500236
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4500/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA1 commented on pull request #3985: [WIP]Fixed float variable to take 4 bytes in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-709200276
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/4463/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] nihal0107 removed a comment on pull request #3985: [CARBONDATA-3965]Fixed float variable target datatype in case of adaptive encoding
Posted by GitBox <gi...@apache.org>.
nihal0107 removed a comment on pull request #3985:
URL: https://github.com/apache/carbondata/pull/3985#issuecomment-709745588
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org