You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by Ross Gardler <rg...@apache.org> on 2006/08/04 14:44:36 UTC
Re: svn commit: r428699 - /forrest/trunk/main/java/org/apache/forrest/conf/ForrestConfModule.java
thorsten@apache.org wrote:
> Author: thorsten
> Date: Fri Aug 4 04:41:38 2006
> New Revision: 428699
...
> + } catch (Exception e) {
> + getLogger().error("Opps, something went wrong.",e);
> + }
-1 (to this addition only, other changes in this commit are OK - see
discussion thread)
This chage is swallowing exceptions and preventing Cocoon reporting them
to the user.
Ross
Re: svn commit: r428699 -
/forrest/trunk/main/java/org/apache/forrest/conf/ForrestConfModule.java
Posted by Thorsten Scherler <th...@wyona.com>.
El vie, 04-08-2006 a las 13:44 +0100, Ross Gardler escribió:
> thorsten@apache.org wrote:
> > Author: thorsten
> > Date: Fri Aug 4 04:41:38 2006
> > New Revision: 428699
>
> ...
>
> > + } catch (Exception e) {
> > + getLogger().error("Opps, something went wrong.",e);
> > + }
>
> -1 (to this addition only, other changes in this commit are OK - see
> discussion thread)
>
> This chage is swallowing exceptions and preventing Cocoon reporting them
> to the user.
>
Forgot to throw them, thx for pointing out.
salu2
--
Thorsten Scherler
COO Spain
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
thorsten.scherler@wyona.com thorsten@apache.org