You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@eventmesh.apache.org by "mxsm (via GitHub)" <gi...@apache.org> on 2023/03/26 05:09:27 UTC

[GitHub] [incubator-eventmesh] mxsm opened a new pull request, #3527: [ISSUE #3526] Optimize SubStreamHandler

mxsm opened a new pull request, #3527:
URL: https://github.com/apache/incubator-eventmesh/pull/3527

<!--
### Contribution Checklist

- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.

- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.

- Each pull request should address only one issue.
Please do not mix up code from multiple issues.

- Each commit in the pull request should have a meaningful commit message.

- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.

(The sections below can be removed for hotfixes of typos)
-->

Fixes #3526

### Motivation

*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*

### Modifications

*Optimize SubStreamHandler*

### Documentation

- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

Re: [PR] [ISSUE #3526] Optimize SubStreamHandler (eventmesh)

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #3527:
URL: https://github.com/apache/eventmesh/pull/3527#issuecomment-2070570176

   It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.
   
   If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org

Re: [PR] [ISSUE #3526] Optimize SubStreamHandler (eventmesh)

Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.

Pil0tXia commented on code in PR #3527:
URL: https://github.com/apache/eventmesh/pull/3527#discussion_r1575775268


##########
eventmesh-common/src/main/java/org/apache/eventmesh/common/ThreadWrapper.java:
##########
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.eventmesh.common;
+
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicBoolean;
+
+import lombok.extern.slf4j.Slf4j;
+
+@Slf4j
+public abstract class ThreadWrapper implements Runnable {
+
+    private final AtomicBoolean started = new AtomicBoolean(false);
+    protected Thread thread;

Review Comment:
   Besides its usage in `SubStreamHandler`, could `ThreadWrapper` be utilized in other classes as well?
   
   `ThreadWrapper` appears to streamline synchronization for `SubStreamHandler`, eliminating the need for using a `latch`. However, the synchronization mechanism using `latch` in `SubStreamHandler` itself isn't overly complex. Hence, I'm curious whether introducing the additional complexity of `ThreadWrapper` for synchronization would address additional problems.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org