You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/02 09:34:15 UTC
[GitHub] [iotdb] benqhy opened a new pull request #3892: fix 2 bugs in import-csv tool
benqhy opened a new pull request #3892:
URL: https://github.com/apache/iotdb/pull/3892
## Description
fix 2 bugs in import-csv tool
### bug 1
When all measurements of a device don't have data in a timestamp, using the import-csv.bat/sh tool will meet error.
import csv file like this:
Time,root.fit.d1.s1,root.fit.d1.s2,root.fit.d2.s1,root.fit.d2.s3,root.fit.p.s1
1970-01-01T08:00:00.001+08:00,,,200,300,400
1970-01-01T08:00:00.002+08:00,500,world,600,700,800
1970-01-01T08:00:00.003+08:00,900,"hello, \"world\"",1000,1100,1200
error log:
The import-csv tool will prompt "Meet error when insert csv because 411: The size of values is 0"
The error log in iotdb sever:
org.apache.iotdb.db.exception.query.QueryProcessException: The size of values is 0
at org.apache.iotdb.db.qp.physical.crud.InsertRowPlan.checkIntegrity(InsertRowPlan.java:557)
at org.apache.iotdb.db.qp.physical.crud.InsertRowsPlan.checkIntegrity(InsertRowsPlan.java:92)
at org.apache.iotdb.db.service.TSServiceImpl.executeNonQueryPlan(TSServiceImpl.java:1909)
at org.apache.iotdb.db.service.TSServiceImpl.insertStringRecords(TSServiceImpl.java:1478)
at org.apache.iotdb.service.rpc.thrift.TSIService$Processor$insertStringRecords.getResult(TSIService.java:2803)
at org.apache.iotdb.service.rpc.thrift.TSIService$Processor$insertStringRecords.getResult(TSIService.java:2783)
at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:38)
at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:38)
at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:248)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
### bug 2
when the line of data is a multiple of 10000, using the import-csv.bat/sh tool will meet error.
error log:
The import-csv tool will prompt "Meet error when insert csv because 411: sub plan are empty."
The error log in iotdb sever:
org.apache.iotdb.db.exception.query.QueryProcessException: sub plan are empty.
at org.apache.iotdb.db.qp.physical.crud.InsertRowsPlan.checkIntegrity(InsertRowsPlan.java:89)
at org.apache.iotdb.db.service.TSServiceImpl.executeNonQueryPlan(TSServiceImpl.java:1909)
at org.apache.iotdb.db.service.TSServiceImpl.insertStringRecords(TSServiceImpl.java:1478)
at org.apache.iotdb.service.rpc.thrift.TSIService$Processor$insertStringRecords.getResult(TSIService.java:2803)
at org.apache.iotdb.service.rpc.thrift.TSIService$Processor$insertStringRecords.getResult(TSIService.java:2783)
at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:38)
at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:38)
at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:248)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
I fix the two bugs by change the cli/src/main/java/org/apache/iotdb/tool/ImportCsv.java.
赛迪信息cisdi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] benqhy commented on pull request #3892: fix 2 bugs in import-csv tool
Posted by GitBox <gi...@apache.org>.
benqhy commented on pull request #3892:
URL: https://github.com/apache/iotdb/pull/3892#issuecomment-913373510
> Hi, we are working on refactor the CSV tool, see #3820.
> Would you like to test if the PR #3820 fixed the bugs you mentioned?
Yes, I'd like to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou edited a comment on pull request #3892: fix 2 bugs in import-csv tool
Posted by GitBox <gi...@apache.org>.
HTHou edited a comment on pull request #3892:
URL: https://github.com/apache/iotdb/pull/3892#issuecomment-913290905
Hi, we are working on refactor the CSV tool, see #3820.
Would you like to test if the PR #3820 fixed the bugs you mentioned?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on pull request #3892: fix 2 bugs in import-csv tool
Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #3892:
URL: https://github.com/apache/iotdb/pull/3892#issuecomment-913290905
Hi, we are working on refactor the CSV tool, see #3820.
Would you like to test if the PR#3820 fixed the bugs you mentioned?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org