You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "fangyincheng (GitHub)" <gi...@apache.org> on 2020/03/15 07:12:04 UTC

[GitHub] [dubbo-go] fangyincheng opened pull request #410: merge from develop & refact config reader

<!--  Thanks for sending a pull request! 
-->

**What this PR does**:

**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #

**Special notes for your reviewer**:

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note

```

[ Full content available at: https://github.com/apache/dubbo-go/pull/410 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #410: merge from develop & refact config reader

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=h1) Report
> Merging [#410](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=desc) into [feature/rest](https://codecov.io/gh/apache/dubbo-go/commit/8c53128d36cf96fe20b95281ff708fc37aa59be4?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `59.01%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/410/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=tree)

```diff
@@               Coverage Diff                @@
##           feature/rest     #410      +/-   ##
================================================
- Coverage         67.63%   67.49%   -0.15%     
================================================
  Files               170      169       -1     
  Lines              8655     8570      -85     
================================================
- Hits               5854     5784      -70     
+ Misses             2256     2241      -15     
  Partials            545      545
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/generic\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29uZmlnL2dlbmVyaWNfc2VydmljZS5nbw==) | `0% <ø> (ø)` | :arrow_up: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `62.38% <ø> (-1.34%)` | :arrow_down: |
| [config\_center/parser/configuration\_parser.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9wYXJzZXIvY29uZmlndXJhdGlvbl9wYXJzZXIuZ28=) | `2.25% <0%> (+0.17%)` | :arrow_up: |
| [common/extension/confit\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maXRfcmVhZGVyLmdv) | `0% <0%> (ø)` | |
| [protocol/rest/rest\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X3Byb3RvY29sLmdv) | `75.34% <100%> (ø)` | :arrow_up: |
| [protocol/rest/rest\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2ludm9rZXIuZ28=) | `72.54% <100%> (ø)` | :arrow_up: |
| [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `68.42% <100%> (-10.43%)` | :arrow_down: |
| [common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29tbW9uL3lhbWwveWFtbC5nbw==) | `100% <100%> (ø)` | :arrow_up: |
| [protocol/grpc/client.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9jbGllbnQuZ28=) | `89.47% <100%> (-3.12%)` | :arrow_down: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `93.06% <25%> (-1.98%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=footer). Last update [8c53128...4c50edc](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/410 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #410: merge from develop & refact config reader

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=h1) Report
> Merging [#410](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=desc) into [feature/rest](https://codecov.io/gh/apache/dubbo-go/commit/8c53128d36cf96fe20b95281ff708fc37aa59be4?src=pr&el=desc) will **decrease** coverage by `0.37%`.
> The diff coverage is `57.35%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/410/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=tree)

```diff
@@               Coverage Diff                @@
##           feature/rest     #410      +/-   ##
================================================
- Coverage         67.63%   67.26%   -0.38%     
================================================
  Files               170      169       -1     
  Lines              8655     8577      -78     
================================================
- Hits               5854     5769      -85     
- Misses             2256     2263       +7     
  Partials            545      545
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <ø> (ø)` | :arrow_up: |
| [config/generic\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29uZmlnL2dlbmVyaWNfc2VydmljZS5nbw==) | `0% <ø> (ø)` | :arrow_up: |
| [config\_center/parser/configuration\_parser.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9wYXJzZXIvY29uZmlndXJhdGlvbl9wYXJzZXIuZ28=) | `2.25% <0%> (+0.17%)` | :arrow_up: |
| [common/extension/confit\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maXRfcmVhZGVyLmdv) | `0% <0%> (ø)` | |
| [protocol/rest/rest\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X3Byb3RvY29sLmdv) | `75.34% <100%> (ø)` | :arrow_up: |
| [protocol/rest/rest\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2ludm9rZXIuZ28=) | `72.54% <100%> (ø)` | :arrow_up: |
| [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `68.42% <100%> (-10.43%)` | :arrow_down: |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `56.25% <100%> (+0.93%)` | :arrow_up: |
| [common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29tbW9uL3lhbWwveWFtbC5nbw==) | `100% <100%> (ø)` | :arrow_up: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `59.37% <100%> (+1.31%)` | :arrow_up: |
| ... and [14 more](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=footer). Last update [8c53128...1e9392a](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/410 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] flycash commented on pull request #410: merge from develop & refact config reader

Posted by "flycash (GitHub)" <gi...@apache.org>.
format imports

[ Full content available at: https://github.com/apache/dubbo-go/pull/410 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #410: merge from develop & refact config reader

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=h1) Report
> Merging [#410](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=desc) into [feature/rest](https://codecov.io/gh/apache/dubbo-go/commit/8c53128d36cf96fe20b95281ff708fc37aa59be4?src=pr&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `59.01%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/410/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=tree)

```diff
@@               Coverage Diff                @@
##           feature/rest     #410      +/-   ##
================================================
- Coverage         67.63%   67.49%   -0.15%     
================================================
  Files               170      169       -1     
  Lines              8655     8570      -85     
================================================
- Hits               5854     5784      -70     
+ Misses             2256     2241      -15     
  Partials            545      545
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/generic\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29uZmlnL2dlbmVyaWNfc2VydmljZS5nbw==) | `0% <ø> (ø)` | :arrow_up: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `62.38% <ø> (-1.34%)` | :arrow_down: |
| [config\_center/parser/configuration\_parser.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9wYXJzZXIvY29uZmlndXJhdGlvbl9wYXJzZXIuZ28=) | `2.25% <0%> (+0.17%)` | :arrow_up: |
| [common/extension/confit\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maXRfcmVhZGVyLmdv) | `0% <0%> (ø)` | |
| [protocol/rest/rest\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X3Byb3RvY29sLmdv) | `75.34% <100%> (ø)` | :arrow_up: |
| [protocol/rest/rest\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9yZXN0X2ludm9rZXIuZ28=) | `72.54% <100%> (ø)` | :arrow_up: |
| [protocol/grpc/server.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9zZXJ2ZXIuZ28=) | `68.42% <100%> (-10.43%)` | :arrow_down: |
| [common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29tbW9uL3lhbWwveWFtbC5nbw==) | `100% <100%> (ø)` | :arrow_up: |
| [protocol/grpc/client.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZ3JwYy9jbGllbnQuZ28=) | `89.47% <100%> (-3.12%)` | :arrow_down: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `93.06% <25%> (-1.98%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=footer). Last update [8c53128...1e9392a](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/410 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #410: merge from develop & refact config reader

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=h1) Report
> Merging [#410](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=desc) into [feature/rest](https://codecov.io/gh/apache/dubbo-go/commit/8c53128d36cf96fe20b95281ff708fc37aa59be4&el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `55.71%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/410/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=tree)

```diff
@@               Coverage Diff                @@
##           feature/rest     #410      +/-   ##
================================================
- Coverage         67.63%   67.44%   -0.20%     
================================================
  Files               170      169       -1     
  Lines              8655     8579      -76     
================================================
- Hits               5854     5786      -68     
+ Misses             2256     2249       -7     
+ Partials            545      544       -1     
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [common/extension/confit\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9jb25maXRfcmVhZGVyLmdv) | `0.00% <0.00%> (ø)` | |
| [config/base\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29uZmlnL2Jhc2VfY29uZmlnLmdv) | `64.14% <ø> (ø)` | |
| [config/generic\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29uZmlnL2dlbmVyaWNfc2VydmljZS5nbw==) | `0.00% <ø> (ø)` | |
| [config\_center/parser/configuration\_parser.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9wYXJzZXIvY29uZmlndXJhdGlvbl9wYXJzZXIuZ28=) | `2.25% <0.00%> (+0.17%)` | :arrow_up: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `56.91% <14.28%> (-6.81%)` | :arrow_down: |
| [common/proxy/proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29tbW9uL3Byb3h5L3Byb3h5Lmdv) | `93.06% <25.00%> (-1.98%)` | :arrow_down: |
| [protocol/rest/config/reader/rest\_config\_reader.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9jb25maWcvcmVhZGVyL3Jlc3RfY29uZmlnX3JlYWRlci5nbw==) | `80.26% <81.81%> (ø)` | |
| [common/yaml/yaml.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29tbW9uL3lhbWwveWFtbC5nbw==) | `100.00% <100.00%> (ø)` | |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `56.25% <100.00%> (+0.93%)` | :arrow_up: |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `59.37% <100.00%> (+1.31%)` | :arrow_up: |
| ... and [10 more](https://codecov.io/gh/apache/dubbo-go/pull/410/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=footer). Last update [8c53128...17c29b5](https://codecov.io/gh/apache/dubbo-go/pull/410?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/410 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] flycash commented on pull request #410: merge from develop & refact config reader

Posted by "flycash (GitHub)" <gi...@apache.org>.
rename the file name to config_reader

[ Full content available at: https://github.com/apache/dubbo-go/pull/410 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org