You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/11/08 07:34:28 UTC

[GitHub] [commons-collections] aherbert commented on pull request #360: Fix flaky test in CollectionUtilsTest.Java

aherbert commented on PR #360:
URL: https://github.com/apache/commons-collections/pull/360#issuecomment-1306755028

   I believe this is fixing a non-issue artificially introduced by the `nondex` plugin. The HashMap has an unspecified iteration order, but it is a deterministic data structure. If it is not modified then the iterator will return the same order.
   
   This is different from other changes identified by `nondex` (see #341, #353) where the test assumptions about ordered iteration were false.
   
   However I think the suggested change is harmless and it will prevent others identifying the same issue in the future using the `nondex` plugin.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org