***UNCHECKED*** Re: [VOTE] Release 4.8.0, release candidate #0

[Sijie Guo <gu...@gmail.com>]

On Tue, Sep 18, 2018 at 3:54 AM Enrico Olivelli <eo...@gmail.com> wrote:

> Il giorno mar 18 set 2018 alle ore 11:41 Ivan Kelly <iv...@apache.org> ha
> scritto:
>
> > Hey Enrico,
> >
> > Thanks for putting this together. Afraid it's -1 from me though.
> >
> > The new binaries pull in grpc, which has a notice file which we are
> > not bubbling up to our notice file.
> > https://github.com/grpc/grpc-java/blob/v1.12.0/NOTICE.txt
> >
> > There's also some minor issues with the links in the LICENSE file,
> > which makes it hard to check some dependencies.
> > - link for lib/org.apache.commons-commons-lang3-3.6.jar is wrong.
> > - link for lib/org.codehaus.jackson-jackson-core-asl-1.9.11.jar is
> > wrong (there's no version 1.9.11 there)
> > - likewise for lib/org.codehaus.jackson-jackson-mapper-asl-1.9.11.jar
> > - link for lib/com.google.api.grpc-proto-google-common-protos-1.0.0.jar
> is
> > wrong
> >
> > Otherwise, GPG sigs are good, SHA512 good. build seems to be good, but
> > hasn't finished for me yet.
> >
>
>
> Ivan,
> Thank you for your early feedback.
> Would you mind create an issue ?
> It should be stuff that went in with Stream Storage and maybe the same
> issues are also in 4.7.2
>
> Do you or Sijie have time to send a patch ? I am not sure I have cycles
> this week. Otherwise I will pick in up on the weekend
>
> I am canceling this RC by now.
>
> These issues are only about license files so code won't change in the next
> RC, any other feedback on this RC is welcome !!!
>


Just FYI. The licensing issue is fixed and cherry-picked to branch-4.8.


>
> Enrico
>
>
>
> >
> > -Ivan
> >
> >
> > On Sat, Sep 15, 2018 at 11:15 AM, Enrico Olivelli <eo...@gmail.com>
> > wrote:
> > > Ping
> > >
> > > Il mer 12 set 2018, 17:28 Enrico Olivelli <eo...@apache.org> ha
> > scritto:
> > >
> > >> Hi everyone,
> > >> Please review and vote on the release candidate #0 for the version
> > 4.8.0,
> > >> as follows:
> > >> [ ] +1, Approve the release
> > >> [ ] -1, Do not approve the release (please provide specific comments)
> > >>
> > >> The complete staging area is available for your review, which
> includes:
> > >> * Release notes [1]
> > >> * The official Apache source and binary distributions to be deployed
> to
> > >> dist.apache.org [2]
> > >> * All artifacts to be deployed to the Maven Central Repository [3]
> > >> * Source code tag "release-4.8.0rc0" [4] with git sha
> > >> 6d4dd98696fa7c6b3f06067758cf79fd1137b611
> > >>
> > >> BookKeeper's KEYS file contains PGP keys we used to sign this release:
> > >> https://dist.apache.org/repos/dist/release/bookkeeper/KEYS
> > >>
> > >> Please download these packages and review this release candidate:
> > >>
> > >> - Review release notes
> > >> - Download the source package (verify shasum, and asc) and follow the
> > >> instructions to build and run the bookkeeper service.
> > >> - Download the binary package (verify shasum, and asc) and follow the
> > >> instructions to run the bookkeeper service.
> > >> - Review maven repo, release tag, licenses, and any other things you
> > think
> > >> it is important to a release.
> > >>
> > >> The vote will be open for at least 72 hours. It is adopted by majority
> > >> approval, with at least 3 PMC affirmative votes.
> > >>
> > >> Thanks,
> > >> Enrico Olivelli
> > >>
> > >> [1] https://github.com/apache/bookkeeper/pull/1676
> > >> [2]
> > >>
> https://dist.apache.org/repos/dist/dev/bookkeeper/bookkeeper-4.8.0-rc0/
> > >> [3]
> > >>
> >
> https://repository.apache.org/content/repositories/orgapachebookkeeper-1032/
> > >> [4] https://github.com/apache/bookkeeper/tree/v4.8.0-rc0
> > >>
> > > --
> > >
> > >
> > > -- Enrico Olivelli
> >
>