You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/10/27 19:40:16 UTC
[GitHub] [incubator-pinot] shahsank3t opened a new pull request #6198: Adding operation in table details page
shahsank3t opened a new pull request #6198:
URL: https://github.com/apache/incubator-pinot/pull/6198
## Description
Added Table Operations:
Support to switch Table Schema from table view to JSON view and vice-versa:
Showing Instance name and # of the segment in table details page:
Reload Status Modal:
Rebalance Server Modal:
Rebalance Server Modal Response:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] shahsank3t commented on pull request #6198: Adding operation in table details page
Posted by GitBox <gi...@apache.org>.
shahsank3t commented on pull request #6198:
URL: https://github.com/apache/incubator-pinot/pull/6198#issuecomment-718270298
@npawar
>@shahsank3t Where are you getting the state for enable/disable table? Are you reading the ideal state znode?
Currently, I am not getting the state from anywhere but rather always defaulting it to enabled and post that maintain the state locally. I'll try to get from the znode state.
>When I deleted the table, I got a blank screen. I think it happened because I edited the server config, and changed DefaultTenant to something else. If a tenant has only broker or server and not both, it seems to be crashing.
Can you share the steps to change the tenant's name? I'd like to reproduce and fix it accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #6198: Adding operation in table details page
Posted by GitBox <gi...@apache.org>.
npawar commented on pull request #6198:
URL: https://github.com/apache/incubator-pinot/pull/6198#issuecomment-718193604
When I deleted the table, I got a blank screen. I think it happened because I edited the server config, and changed DefaultTenant to something else. If a tenant has only broker or server and not both, it seems to be crashing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #6198: Adding operation in table details page
Posted by GitBox <gi...@apache.org>.
npawar commented on pull request #6198:
URL: https://github.com/apache/incubator-pinot/pull/6198#issuecomment-718299956
Another issue:
I went to Broker instance, removed DefaultTenant and added neha_BROKER
I went to Server instance, removed DefaultTenant and added neha_OFFINE
Now I wanted to go to my Table and edit the table config, but I cannot see that table. I'm guessing the call to fetch the tenant is failing, coz the table still refers to DefaultTenant.
We should still show the Table in the list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] npawar merged pull request #6198: Adding operation in table details page
Posted by GitBox <gi...@apache.org>.
npawar merged pull request #6198:
URL: https://github.com/apache/incubator-pinot/pull/6198
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] codecov-io commented on pull request #6198: Adding operation in table details page
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #6198:
URL: https://github.com/apache/incubator-pinot/pull/6198#issuecomment-717518519
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6198?src=pr&el=h1) Report
> Merging [#6198](https://codecov.io/gh/apache/incubator-pinot/pull/6198?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1beaab59b73f26c4e35f3b9bc856b03806cddf5a?el=desc) will **decrease** coverage by `2.30%`.
> The diff coverage is `38.28%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/6198?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6198 +/- ##
==========================================
- Coverage 66.44% 64.13% -2.31%
==========================================
Files 1075 1237 +162
Lines 54773 58540 +3767
Branches 8168 8663 +495
==========================================
+ Hits 36396 37547 +1151
- Misses 15700 18256 +2556
- Partials 2677 2737 +60
```
| Flag | Coverage Δ | |
|---|---|---|
| #unittests | `64.13% <38.28%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/6198?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...e/pinot/broker/api/resources/PinotBrokerDebug.java](https://codecov.io/gh/apache/incubator-pinot/pull/6198/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYXBpL3Jlc291cmNlcy9QaW5vdEJyb2tlckRlYnVnLmphdmE=) | `0.00% <0.00%> (-79.32%)` | :arrow_down: |
| [...ot/broker/broker/AllowAllAccessControlFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6198/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL0FsbG93QWxsQWNjZXNzQ29udHJvbEZhY3RvcnkuamF2YQ==) | `71.42% <ø> (-28.58%)` | :arrow_down: |
| [.../helix/BrokerUserDefinedMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/6198/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0Jyb2tlclVzZXJEZWZpbmVkTWVzc2FnZUhhbmRsZXJGYWN0b3J5LmphdmE=) | `33.96% <0.00%> (-32.71%)` | :arrow_down: |
| [...ava/org/apache/pinot/client/AbstractResultSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/6198/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Fic3RyYWN0UmVzdWx0U2V0LmphdmE=) | `66.66% <0.00%> (+9.52%)` | :arrow_up: |
| [.../main/java/org/apache/pinot/client/Connection.java](https://codecov.io/gh/apache/incubator-pinot/pull/6198/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0Nvbm5lY3Rpb24uamF2YQ==) | `35.55% <0.00%> (-13.29%)` | :arrow_down: |
| [...inot/client/JsonAsyncHttpPinotClientTransport.java](https://codecov.io/gh/apache/incubator-pinot/pull/6198/diff?src=pr&el=tree#diff-cGlub3QtY2xpZW50cy9waW5vdC1qYXZhLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY2xpZW50L0pzb25Bc3luY0h0dHBQaW5vdENsaWVudFRyYW5zcG9ydC5qYXZh) | `10.90% <0.00%> (-51.10%)` | :arrow_down: |
| [...not/common/assignment/InstancePartitionsUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/6198/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vYXNzaWdubWVudC9JbnN0YW5jZVBhcnRpdGlvbnNVdGlscy5qYXZh) | `73.80% <ø> (+0.63%)` | :arrow_up: |
| [.../apache/pinot/common/exception/QueryException.java](https://codecov.io/gh/apache/incubator-pinot/pull/6198/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZXhjZXB0aW9uL1F1ZXJ5RXhjZXB0aW9uLmphdmE=) | `90.27% <ø> (+5.55%)` | :arrow_up: |
| [...pinot/common/function/AggregationFunctionType.java](https://codecov.io/gh/apache/incubator-pinot/pull/6198/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vQWdncmVnYXRpb25GdW5jdGlvblR5cGUuamF2YQ==) | `98.27% <ø> (-1.73%)` | :arrow_down: |
| [.../pinot/common/function/DateTimePatternHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/6198/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vRGF0ZVRpbWVQYXR0ZXJuSGFuZGxlci5qYXZh) | `83.33% <ø> (ø)` | |
| ... and [1074 more](https://codecov.io/gh/apache/incubator-pinot/pull/6198/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6198?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/6198?src=pr&el=footer). Last update [0f4ee68...1924033](https://codecov.io/gh/apache/incubator-pinot/pull/6198?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] shahsank3t commented on pull request #6198: Adding operation in table details page
Posted by GitBox <gi...@apache.org>.
shahsank3t commented on pull request #6198:
URL: https://github.com/apache/incubator-pinot/pull/6198#issuecomment-718992130
@npawar - addressed & fixed all the changes you mentioned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #6198: Adding operation in table details page
Posted by GitBox <gi...@apache.org>.
npawar commented on pull request #6198:
URL: https://github.com/apache/incubator-pinot/pull/6198#issuecomment-718191872
@shahsank3t Where are you getting the state for enable/disable table? Are you reading the ideal state znode?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [incubator-pinot] npawar commented on pull request #6198: Adding operation in table details page
Posted by GitBox <gi...@apache.org>.
npawar commented on pull request #6198:
URL: https://github.com/apache/incubator-pinot/pull/6198#issuecomment-718297596
> @npawar
>
> > @shahsank3t Where are you getting the state for enable/disable table? Are you reading the ideal state znode?
>
> Currently, I am not getting the state from anywhere but rather always defaulting it to enabled and post that maintain the state locally. I'll try to get from the znode state.
Regarding the enable/disable, the problem right now is that if I disable a table and then go to a different page, the state is forgotten. I would suggest just greying out that operation for now. @galalen is working on adding an API to get the state https://github.com/apache/incubator-pinot/issues/6169
>
> > When I deleted the table, I got a blank screen. I think it happened because I edited the server config, and changed DefaultTenant to something else. If a tenant has only broker or server and not both, it seems to be crashing.
>
> Can you share the steps to change the tenant's name? I'd like to reproduce and fix it accordingly.
For the blank screen, here were my steps:
1. Started OfflineQuickStart
2. Go to Tenants -> DefaultTenant -> Broker instance.
3. Click on Edit Tags.
4. Removed DefaultTenant_OFFLINE, added neha_OFFLINE.
5. Came back to Home.
6. Clicked on Tenants -> DefaultTenant (or neha tenant). Got blank screen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org