You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "st-omarkhalid (via GitHub)" <gi...@apache.org> on 2026/04/17 21:42:10 UTC
[I] Allow subclasses to intercept BrokerResponse via overridable onQueryCompletion hook [pinot]
st-omarkhalid opened a new issue, #18248:
URL: https://github.com/apache/pinot/issues/18248
## Problem
The `BrokerQueryEventListener` SPI only receives `RequestContext` in `onQueryCompletion(RequestContext)`. Several fields that are fully populated only after query execution — `isPartialResult()`, `getPools()`, `getRLSFiltersApplied()`, `getTablesQueried()`, `isNumGroupsWarningLimitReached()` — are only available on `BrokerResponse`, not on `RequestContext`.
This makes it impossible for downstream implementations (e.g. async query-log pipelines) to capture the complete query metadata without modifying the SPI.
## Proposed Solution
1. Add a `protected onQueryCompletion(RequestContext, BrokerResponse)` hook to `BaseBrokerRequestHandler`. The default implementation delegates to the existing SPI listener (no behaviour change). Subclasses can override to intercept the full response.
2. Add a `protected createSingleStageBrokerRequestHandler(...)` factory method to `BaseBrokerStarter` so subclasses can inject a custom handler that overrides the hook. Follows the same pattern as the existing `createWorkerManager(...)` factory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] Allow subclasses to intercept BrokerResponse via overridable onQueryCompletion hook [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 closed issue #18248: Allow subclasses to intercept BrokerResponse via overridable onQueryCompletion hook
URL: https://github.com/apache/pinot/issues/18248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org