You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/12/08 22:55:29 UTC
[GitHub] [maven] AlexanderAshitkin opened a new pull request #633: [MNG-7129] Files selectors rework draft
AlexanderAshitkin opened a new pull request #633:
URL: https://github.com/apache/maven/pull/633
The idea is to replace glob section with glob/pattern based includes excludes to form determenistic files set.
Current implementtation with glob might be not flexible and expressive enough. Proposed configuration:
```xml
<defaultFileSet>
<!-- By default, include src/**, all source and resources directory -->
<include>
<globs>
<!-- glob expressions -->
<glob>*.{java,properties}</glob>
<glob>/home/*/*</glob>
</globs>
<patterns>
<pattern>(cat|dog)-[0-3][0-5][0-9]\.xml</pattern>
</patterns>
</include>
<!-- Output directories are excluded by default -->
<exclude>
<globs>
<glob>*.{iml,log}</glob>
</globs>
<patterns>
<pattern>(cat|dog)-[0-3][0-5][0-9]\.xml</pattern>
</patterns>
</exclude>
</defaultFileSet>
<!-- more directories to include -->
<fileSets>
<fileSet directory="additional-directory">
<include/>
<exclude/>
</fileSet>
</fileSets>
```
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #633: [MNG-7129] Files selectors rework draft
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #633:
URL: https://github.com/apache/maven/pull/633#issuecomment-989746160
I would prefer the `fileSet` be just like with Maven Assembly Plugin's `fileSet`: https://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#class_fileSet. It has directory, includes, excludes. The globbing and regex patterns can be replaced with the approach [here](https://maven.apache.org/plugins/maven-assembly-plugin/advanced-descriptor-topics.html). No need two different XML elements for both. That style is familiar to users and makes adoption easier. I don't know which component performs the matching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] hboutemy closed pull request #633: [MNG-7129] Files selectors rework draft
Posted by GitBox <gi...@apache.org>.
hboutemy closed pull request #633:
URL: https://github.com/apache/maven/pull/633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #633: [MNG-7129] Files selectors rework draft
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #633:
URL: https://github.com/apache/maven/pull/633#issuecomment-989737263
Question: Why does it require `defaultFileSet` what cannot be achived with a `fileSet`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org