[GitHub] [spark] mgaido91 commented on a change in pull request #25204: [SPARK-28441][SQL][Python] Fix error when non-foldable expression is used in correlated scalar subquery

[GitBox <gi...@apache.org>]

mgaido91 commented on a change in pull request #25204: [SPARK-28441][SQL][Python] Fix error when non-foldable expression is used in correlated scalar subquery
URL: https://github.com/apache/spark/pull/25204#discussion_r307183647
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
 ##########
 @@ -316,25 +316,46 @@ object RewriteCorrelatedScalarSubquery extends Rule[LogicalPlan] {
     newExpression.asInstanceOf[E]
   }
 
+  private def removeAlias(expr: Expression): Expression = expr match {
 
 Review comment:
   what if there are several aliases? Shall we use `CleanupAliases` instead?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org