You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Dan Dumont <dd...@us.ibm.com> on 2012/05/02 22:12:46 UTC
Review Request: Allow gadgets to properly manage/scroll the content area
they have been afforded by the container.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4973/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
I know this is a small review, but I wanted to be able to link to the review in email threads on the dev and spec lists.
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1333049
Diff: https://reviews.apache.org/r/4973/diff
Testing
-------
All tests pass.
Thanks,
Dan
Re: Review Request: Allow gadgets to properly manage/scroll the content area
they have been afforded by the container.
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4973/#review7560
-----------------------------------------------------------
Ship it!
Committed r1333997
- Dan
On 2012-05-03 14:54:20, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4973/
> -----------------------------------------------------------
>
> (Updated 2012-05-03 14:54:20)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> I know this is a small review, but I wanted to be able to link to the review in email threads on the dev and spec lists.
>
>
> This addresses bug SHINDIG-1766.
> https://issues.apache.org/jira/browse/SHINDIG-1766
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1333049
>
> Diff: https://reviews.apache.org/r/4973/diff
>
>
> Testing
> -------
>
> All tests pass.
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Allow gadgets to properly manage/scroll the content area
they have been afforded by the container.
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4973/#review7558
-----------------------------------------------------------
Ship it!
LGTM
- Ryan
On 2012-05-03 14:54:20, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4973/
> -----------------------------------------------------------
>
> (Updated 2012-05-03 14:54:20)
>
>
> Review request for shindig.
>
>
> Summary
> -------
>
> I know this is a small review, but I wanted to be able to link to the review in email threads on the dev and spec lists.
>
>
> This addresses bug SHINDIG-1766.
> https://issues.apache.org/jira/browse/SHINDIG-1766
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1333049
>
> Diff: https://reviews.apache.org/r/4973/diff
>
>
> Testing
> -------
>
> All tests pass.
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: Allow gadgets to properly manage/scroll the content area
they have been afforded by the container.
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4973/
-----------------------------------------------------------
(Updated 2012-05-03 14:54:20.611954)
Review request for shindig.
Changes
-------
Adding JIRA
Summary
-------
I know this is a small review, but I wanted to be able to link to the review in email threads on the dev and spec lists.
This addresses bug SHINDIG-1766.
https://issues.apache.org/jira/browse/SHINDIG-1766
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1333049
Diff: https://reviews.apache.org/r/4973/diff
Testing
-------
All tests pass.
Thanks,
Dan