You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Anna Szonyi <sz...@cloudera.com> on 2016/10/26 08:48:20 UTC
Review Request 53169: Minor convenience feature: Added flag
(remoteDebug) to ant test to enable remote debuging
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53169/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-3037
https://issues.apache.org/jira/browse/SQOOP-3037
Repository: sqoop-trunk
Description
-------
Minor convenience feature: Added flag to ant test for remote debugging, so the build.xml won't have to be modified to remote debug tests
Diffs
-----
build.xml 7f948b3
Diff: https://reviews.apache.org/r/53169/diff/
Testing
-------
ran ant test without any flag, ant test with -DremoteDebug=true, -DremoteDebug=false, ant compile, etc.
Thanks,
Anna Szonyi
Re: Review Request 53169: Minor convenience feature: Added flag
(remoteDebug) to ant test to enable remote debuging
Posted by Attila Szabo <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53169/#review155579
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Szabo
On Oct. 26, 2016, 8:48 a.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53169/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2016, 8:48 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3037
> https://issues.apache.org/jira/browse/SQOOP-3037
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Minor convenience feature: Added flag to ant test for remote debugging, so the build.xml won't have to be modified to remote debug tests
>
>
> Diffs
> -----
>
> build.xml 7f948b3
>
> Diff: https://reviews.apache.org/r/53169/diff/
>
>
> Testing
> -------
>
> ran ant test without any flag, ant test with -DremoteDebug=true, -DremoteDebug=false, ant compile, etc.
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 53169: Minor convenience feature: Added flag
(remoteDebug) to ant test to enable remote debuging
Posted by Boglarka Egyed <eg...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53169/#review153987
-----------------------------------------------------------
Ship it!
Ship It!
- Boglarka Egyed
On Oct. 26, 2016, 8:48 a.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53169/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2016, 8:48 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3037
> https://issues.apache.org/jira/browse/SQOOP-3037
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Minor convenience feature: Added flag to ant test for remote debugging, so the build.xml won't have to be modified to remote debug tests
>
>
> Diffs
> -----
>
> build.xml 7f948b3
>
> Diff: https://reviews.apache.org/r/53169/diff/
>
>
> Testing
> -------
>
> ran ant test without any flag, ant test with -DremoteDebug=true, -DremoteDebug=false, ant compile, etc.
>
>
> Thanks,
>
> Anna Szonyi
>
>
Re: Review Request 53169: Minor convenience feature: Added flag
(remoteDebug) to ant test to enable remote debuging
Posted by Szabolcs Vasas <va...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53169/#review153870
-----------------------------------------------------------
Ship it!
Hi Ana!
Thank you for adding this small enhancement, it will be much cleaner than uncommenting lines in build.xml$
- Szabolcs Vasas
On Oct. 26, 2016, 8:48 a.m., Anna Szonyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53169/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2016, 8:48 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3037
> https://issues.apache.org/jira/browse/SQOOP-3037
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Minor convenience feature: Added flag to ant test for remote debugging, so the build.xml won't have to be modified to remote debug tests
>
>
> Diffs
> -----
>
> build.xml 7f948b3
>
> Diff: https://reviews.apache.org/r/53169/diff/
>
>
> Testing
> -------
>
> ran ant test without any flag, ant test with -DremoteDebug=true, -DremoteDebug=false, ant compile, etc.
>
>
> Thanks,
>
> Anna Szonyi
>
>