You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "hailin0 (via GitHub)" <gi...@apache.org> on 2024/01/18 14:42:37 UTC

[PR] [Fix][Oracle-CDC] Fix invalid split key when no primary key [seatunnel]

hailin0 opened a new pull request, #6251:
URL: https://github.com/apache/seatunnel/pull/6251

   
   ### Purpose of this pull request
   
   [Oracle-CDC] Fix invalid split key when no primary key
   
   supported no primary-key & custom primary-key
   https://github.com/apache/seatunnel/pull/6209
   https://github.com/apache/seatunnel/pull/6216
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   https://github.com/apache/seatunnel/pull/6209/files#diff-2ce020b038574b0a89a2903359d5806b57f2f672a144ad7dfdac74d231ac2ee8
   
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If you are contributing the connector code, please check that the following files are updated:
     1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/seatunnel/tree/dev/docs/en/connector-v2)
     2. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
     3. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
   * [ ] Update the [`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Oracle-CDC] Fix invalid split key when no primary key [seatunnel]

Posted by "Carl-Zhou-CN (via GitHub)" <gi...@apache.org>.
Carl-Zhou-CN commented on code in PR #6251:
URL: https://github.com/apache/seatunnel/pull/6251#discussion_r1458244922


##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-oracle/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/oracle/source/eumerator/OracleChunkSplitter.java:
##########
@@ -104,21 +103,4 @@ protected int ObjectCompare(Object obj1, Object obj2) {
             return ObjectUtils.compare(obj1, obj2);
         }
     }
-

Review Comment:
   ok,In a certain scenario, there can be a bug with the ROWID when a table has existing data before enabling logging, causing the inability to read snapshots.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Oracle-CDC] Fix invalid split key when no primary key [seatunnel]

Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #6251:
URL: https://github.com/apache/seatunnel/pull/6251#discussion_r1458203075


##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-oracle/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/oracle/source/eumerator/OracleChunkSplitter.java:
##########
@@ -104,21 +103,4 @@ protected int ObjectCompare(Object obj1, Object obj2) {
             return ObjectUtils.compare(obj1, obj2);
         }
     }
-

Review Comment:
   If you select this field as the split column, output the column to the sink.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Oracle-CDC] Fix invalid split key when no primary key [seatunnel]

Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #6251:
URL: https://github.com/apache/seatunnel/pull/6251#issuecomment-1900230605

   ci pssed
   <img width="1062" alt="image" src="https://github.com/apache/seatunnel/assets/14371345/85ccc0c2-1d0e-4bd8-b405-72b3a9159be0">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Oracle-CDC] Fix invalid split key when no primary key [seatunnel]

Posted by "Carl-Zhou-CN (via GitHub)" <gi...@apache.org>.
Carl-Zhou-CN commented on code in PR #6251:
URL: https://github.com/apache/seatunnel/pull/6251#discussion_r1458168423


##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-oracle/src/main/java/org/apache/seatunnel/connectors/seatunnel/cdc/oracle/source/eumerator/OracleChunkSplitter.java:
##########
@@ -104,21 +103,4 @@ protected int ObjectCompare(Object obj1, Object obj2) {
             return ObjectUtils.compare(obj1, obj2);
         }
     }
-

Review Comment:
   Why does he need to be removed? I think choosing it in the absence of a primary key is also a valid option.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Fix][Oracle-CDC] Fix invalid split key when no primary key [seatunnel]

Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 merged PR #6251:
URL: https://github.com/apache/seatunnel/pull/6251


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org