You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cactus-dev@jakarta.apache.org by Vincent Massol <vm...@pivolis.com> on 2003/05/28 09:25:22 UTC

suggestion for improving an error case in cactifywar task

Hi (Chris),

If you have a webapp with no web.xml, the error printed by the cactus
cactifywar task is not very user-friendly:

java.lang.IllegalArgumentException: InputStream cannot be null
        at javax.xml.parsers.DocumentBuilder.parse(Unknown Source)
        at
org.apache.cactus.integration.ant.deployment.WebXmlIo.parseWebXml(WebXml
Io.java:222)
        at
org.apache.cactus.integration.ant.deployment.WarArchive.getWebXml(WarArc
hive.java:133)
        at
org.apache.cactus.integration.ant.CactifyWarTask.getOriginalWebXml(Cacti
fyWarTask.java:50
5)
        at
org.apache.cactus.integration.ant.CactifyWarTask.execute(CactifyWarTask.
java:234)

Of course I could improve it but it will take me some time so I'm
putting this request here in the hope someone (hint!) will beat me to
it... :-)

Thanks
-Vincent


---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org

RE: suggestion for improving an error case in cactifywar task

Posted by Vincent Massol <vm...@pivolis.com>.
Way cool! Thanks Chris. You rock! :-)

-Vincent

> -----Original Message-----
> From: news [mailto:news@main.gmane.org] On Behalf Of Christopher Lenz
> Sent: 28 May 2003 11:37
> To: cactus-dev@jakarta.apache.org
> Subject: Re: suggestion for improving an error case in cactifywar task
> 
> Hi Vincent,
> 
> fix + testcase committed :-)
> 
> -chris
> 
> Vincent Massol wrote:
> > Hi (Chris),
> >
> > If you have a webapp with no web.xml, the error printed by the
cactus
> > cactifywar task is not very user-friendly:
> >
> > java.lang.IllegalArgumentException: InputStream cannot be null
> >         at javax.xml.parsers.DocumentBuilder.parse(Unknown Source)
> >         at
> >
org.apache.cactus.integration.ant.deployment.WebXmlIo.parseWebXml(WebXml
> > Io.java:222)
> >         at
> >
org.apache.cactus.integration.ant.deployment.WarArchive.getWebXml(WarArc
> > hive.java:133)
> >         at
> >
org.apache.cactus.integration.ant.CactifyWarTask.getOriginalWebXml(Cacti
> > fyWarTask.java:50
> > 5)
> >         at
> >
org.apache.cactus.integration.ant.CactifyWarTask.execute(CactifyWarTask.
> > java:234)
> >
> > Of course I could improve it but it will take me some time so I'm
> > putting this request here in the hope someone (hint!) will beat me
to
> > it... :-)
> >
> > Thanks
> > -Vincent
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: cactus-dev-help@jakarta.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org

Re: suggestion for improving an error case in cactifywar task

Posted by Christopher Lenz <cm...@gmx.de>.
Hi Vincent,

fix + testcase committed :-)

-chris

Vincent Massol wrote:
> Hi (Chris),
> 
> If you have a webapp with no web.xml, the error printed by the cactus
> cactifywar task is not very user-friendly:
> 
> java.lang.IllegalArgumentException: InputStream cannot be null
>         at javax.xml.parsers.DocumentBuilder.parse(Unknown Source)
>         at
> org.apache.cactus.integration.ant.deployment.WebXmlIo.parseWebXml(WebXml
> Io.java:222)
>         at
> org.apache.cactus.integration.ant.deployment.WarArchive.getWebXml(WarArc
> hive.java:133)
>         at
> org.apache.cactus.integration.ant.CactifyWarTask.getOriginalWebXml(Cacti
> fyWarTask.java:50
> 5)
>         at
> org.apache.cactus.integration.ant.CactifyWarTask.execute(CactifyWarTask.
> java:234)
> 
> Of course I could improve it but it will take me some time so I'm
> putting this request here in the hope someone (hint!) will beat me to
> it... :-)
> 
> Thanks
> -Vincent



---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org